[GitHub] [lucene] stefanvodita opened a new pull request, #11780: GH#11601: Add ability to compute reader states after refresh

2022-09-18 Thread GitBox
stefanvodita opened a new pull request, #11780: URL: https://github.com/apache/lucene/pull/11780 This PR is only meant as a starting point for a conversation and not to be merged as is. It is a proposal to let users retrieve new `SortedSedDocValuesReaderState` objects after doing a refre

[GitHub] [lucene] msokolov opened a new pull request, #11781: Diversity check bugfix

2022-09-18 Thread GitBox
msokolov opened a new pull request, #11781: URL: https://github.com/apache/lucene/pull/11781 I was looking into the changes in recall we have been observing in various test cases. Thanks @jtibshirani for pointing out we should not see any change at all! I found a couple of related bugs in t

[GitHub] [lucene] msokolov opened a new issue, #11782: Fix bugs in HNSW diversity check introduced in LUCENE-10577

2022-09-18 Thread GitBox
msokolov opened a new issue, #11782: URL: https://github.com/apache/lucene/issues/11782 ### Description we observed changes in recall that can be traced to these diversity checks done while indexing. ### Version and environment details _No response_ -- This is an auto

[GitHub] [lucene] msokolov commented on issue #11782: Fix bugs in HNSW diversity check introduced in LUCENE-10577

2022-09-18 Thread GitBox
msokolov commented on issue #11782: URL: https://github.com/apache/lucene/issues/11782#issuecomment-1250373809 https://github.com/apache/lucene/pull/11781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene] msokolov commented on pull request #591: LUCENE-10365 Wizard changes contributed from Solr

2022-09-18 Thread GitBox
msokolov commented on PR #591: URL: https://github.com/apache/lucene/pull/591#issuecomment-1250375265 ah thanks Jan! Since I went through all the GPG setup I feel I should use it! But ... probably will backport -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene] msokolov opened a new issue, #11783: Make NeighborArray fixed size

2022-09-18 Thread GitBox
msokolov opened a new issue, #11783: URL: https://github.com/apache/lucene/issues/11783 ### Description Today we allow NeighborArray to grow dynamically, but we always allocate at its full size, and then grow it by 1 because when it is full-sized, we store a new neighbor at index *si

[GitHub] [lucene] msokolov opened a new pull request, #11784: NeighborArray is now fixed size

2022-09-18 Thread GitBox
msokolov opened a new pull request, #11784: URL: https://github.com/apache/lucene/pull/11784 Remove the ability for `NeighborArray` to grow. Always allocates it one larger than requested, to reserve space for a temporary neighbor. -- This is an automated message from the Apache Git Servic

[GitHub] [lucene] msokolov commented on pull request #11784: NeighborArray is now fixed size

2022-09-18 Thread GitBox
msokolov commented on PR #11784: URL: https://github.com/apache/lucene/pull/11784#issuecomment-1250379348 Fixes https://github.com/apache/lucene/issues/11783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [lucene] msokolov commented on issue #11769: TestKnnVectorQuery.testScoreEuclidean fails

2022-09-18 Thread GitBox
msokolov commented on issue #11769: URL: https://github.com/apache/lucene/issues/11769#issuecomment-1250380506 I believe https://github.com/apache/lucene/commit/e69c48b8d941f44bb73f0594b5f72947efe80948 should fix. I guess LuceneTestCase.newIndexWriterConfig can randomly commit, or result i

[GitHub] [lucene] msokolov commented on a diff in pull request #11781: Diversity check bugfix

2022-09-18 Thread GitBox
msokolov commented on code in PR #11781: URL: https://github.com/apache/lucene/pull/11781#discussion_r973782739 ## lucene/core/src/test/org/apache/lucene/util/hnsw/TestHnswGraph.java: ## @@ -555,6 +556,78 @@ public void testDiversity() throws IOException { assertLevel0Neigh