[GitHub] [lucene] romseygeek merged pull request #11762: Removed duplicate check in SpanGradientFormatter

2022-09-14 Thread GitBox
romseygeek merged PR #11762: URL: https://github.com/apache/lucene/pull/11762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] kotman12 opened a new issue, #11771: KeywordRepeatFilter + OpenNLPLLemmatizer Early Exit

2022-09-14 Thread GitBox
kotman12 opened a new issue, #11771: URL: https://github.com/apache/lucene/issues/11771 ### Description KeywordRepeatFilter + OpenNLPLLemmatizer leads to arbitrarily early exit of token stream. Steps to reproduce: run this [test](https://github.com/kotman12/lucene/blob/illustr

[GitHub] [lucene] rmuir commented on pull request #11766: Retry gradle wrapper download on http 500 and 503.

2022-09-14 Thread GitBox
rmuir commented on PR #11766: URL: https://github.com/apache/lucene/pull/11766#issuecomment-1246912736 @dweiss we haven't seen any issues from this commit in jenkins, should be backport to 9.x branch as well? -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [lucene] rmuir opened a new issue, #11772: remove WindowsDirectory

2022-09-14 Thread GitBox
rmuir opened a new issue, #11772: URL: https://github.com/apache/lucene/issues/11772 ### Description Having native code complicates the gradle build and causes bugs. The Direct-IO directory no longer needs native code, it uses JDK APIs. So the only thing left is WindowsDirector

[GitHub] [lucene] dweiss commented on pull request #11766: Retry gradle wrapper download on http 500 and 503.

2022-09-14 Thread GitBox
dweiss commented on PR #11766: URL: https://github.com/apache/lucene/pull/11766#issuecomment-1246965355 Darn, I've cherry picked it on branch_9x but didn't push the changes. I've rebased it now and pushed. Sorry. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [lucene] dweiss commented on issue #11772: remove WindowsDirectory

2022-09-14 Thread GitBox
dweiss commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1246968550 I've no idea who uses this thing but I'm open to removing this - it does complicate things a bit. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [lucene] uschindler commented on issue #11772: remove WindowsDirectory

2022-09-14 Thread GitBox
uschindler commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1246968656 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [lucene] rmuir commented on issue #11772: remove WindowsDirectory

2022-09-14 Thread GitBox
rmuir commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1246969693 I kinda feel that going forwards, we would not do things this way with C code, but instead look to use the new FFI interfaces being added to openjdk if we really need to call native s

[GitHub] [lucene] dweiss commented on issue #11772: remove WindowsDirectory

2022-09-14 Thread GitBox
dweiss commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1246971638 If there are no objections, I'll handle the removal - there are some gradle scripts involved there that will also benefit from the cleanup. -- This is an automated message from the

[GitHub] [lucene] uschindler commented on issue #11772: remove WindowsDirectory

2022-09-14 Thread GitBox
uschindler commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1246972037 Project Panama is the way to go, no need for FFI or anything like that. You can create a MethodHandle that downcalls into libc/kernel.dll. I have an example in some talk.

[GitHub] [lucene] uschindler commented on issue #11772: remove WindowsDirectory

2022-09-14 Thread GitBox
uschindler commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1246993380 This is how to call `getpid()` with Java 19 (you need to enable preview APIS and also enable access to native code (disabled for secuirty by default): ```java var cLinke

[GitHub] [lucene] rmuir commented on issue #11772: remove WindowsDirectory

2022-09-14 Thread GitBox
rmuir commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1247019862 yeah, sorry when i said FFI i meant panama (its an FFI to me). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [lucene] dweiss commented on issue #11772: remove WindowsDirectory

2022-09-14 Thread GitBox
dweiss commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1247202311 That's pretty neat. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [lucene] mdmarshmallow commented on pull request #11729: LUCENE-11728: Improve code clarity for OrdinalMap

2022-09-14 Thread GitBox
mdmarshmallow commented on PR #11729: URL: https://github.com/apache/lucene/pull/11729#issuecomment-1247251315 Removed some of the comments that were maybe just paraphrasing the code too much. I also renamed some variables to what I think are more clear names. Hopefully the comments/variabl

[GitHub] [lucene] LuXugang opened a new issue, #11773: Could `PointRangeQuery`'s boundary values used for `NumericComparator` to calculate `estimatedNumberOfMatches`

2022-09-14 Thread GitBox
LuXugang opened a new issue, #11773: URL: https://github.com/apache/lucene/issues/11773 ### Description Now when we do TopK search, we could rebuild `DocIdSetIterator` to reduce candidate docs since [LUCENE-9280](https://issues.apache.org/jira/browse/LUCENE-9280) . One conditi

[GitHub] [lucene] tang-hi commented on issue #11770: Optimization for time series data

2022-09-14 Thread GitBox
tang-hi commented on issue #11770: URL: https://github.com/apache/lucene/issues/11770#issuecomment-1247622672 Hi,LuXugang. I have roughly read that paper. And I think it has a lot of interesting optimizations for lucene. I' m really interested about **the reverse binary search al

[GitHub] [lucene] dweiss commented on pull request #11774: GH-1172: remove WindowsDirectory and native subproject.

2022-09-14 Thread GitBox
dweiss commented on PR #11774: URL: https://github.com/apache/lucene/pull/11774#issuecomment-1247630649 Fixes #11772. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [lucene] dweiss commented on issue #11772: remove WindowsDirectory

2022-09-14 Thread GitBox
dweiss commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1247631506 We should apply this to main, but I think there's no harm to backport to 9.x, right? It's not a stable API and there is a safe replacement. -- This is an automated message from the