[GitHub] [lucene-solr] risdenk merged pull request #2669: SOLR-16324: Upgrade commons-configuration2 to 2.8.0 and commons-text to 1.9

2022-09-07 Thread GitBox
risdenk merged PR #2669: URL: https://github.com/apache/lucene-solr/pull/2669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] jpountz commented on a diff in pull request #11756: LUCENE-10577: Remove LeafReader#searchNearestVectorsExhaustively

2022-09-07 Thread GitBox
jpountz commented on code in PR #11756: URL: https://github.com/apache/lucene/pull/11756#discussion_r965022161 ## lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java: ## @@ -175,9 +176,42 @@ private TopDocs approximateSearch(LeafReaderContext context, Bits acceptD

[GitHub] [lucene] jmazanec15 commented on issue #11354: Reuse HNSW graphs when merging segments? [LUCENE-10318]

2022-09-07 Thread GitBox
jmazanec15 commented on issue #11354: URL: https://github.com/apache/lucene/issues/11354#issuecomment-1239660422 Right, I think the scores are required when checking if an already added node becomes a new node's neighbor and we [check](https://github.com/apache/lucene/blob/main/lucene/core/

[GitHub] [lucene] jtibshirani commented on a diff in pull request #11756: LUCENE-10577: Remove LeafReader#searchNearestVectorsExhaustively

2022-09-07 Thread GitBox
jtibshirani commented on code in PR #11756: URL: https://github.com/apache/lucene/pull/11756#discussion_r965154356 ## lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java: ## @@ -175,9 +176,42 @@ private TopDocs approximateSearch(LeafReaderContext context, Bits acc

[GitHub] [lucene] jtibshirani commented on a diff in pull request #11756: LUCENE-10577: Remove LeafReader#searchNearestVectorsExhaustively

2022-09-07 Thread GitBox
jtibshirani commented on code in PR #11756: URL: https://github.com/apache/lucene/pull/11756#discussion_r965171139 ## lucene/core/src/java/org/apache/lucene/search/VectorScorer.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [lucene] jmazanec15 commented on issue #11354: Reuse HNSW graphs when merging segments? [LUCENE-10318]

2022-09-07 Thread GitBox
jmazanec15 commented on issue #11354: URL: https://github.com/apache/lucene/issues/11354#issuecomment-1239961308 I just finished the initial set of experiments. Seems like there still may be some issues with the implementation. ### Setup For the data set, I used the [sift data set

[GitHub] [lucene] gsmiller commented on pull request #1035: LUCENE-10652: Add a top-n range faceting example to RangeFacetsExample

2022-09-07 Thread GitBox
gsmiller commented on PR #1035: URL: https://github.com/apache/lucene/pull/1035#issuecomment-1240036505 @Yuti-G thanks for reminding me about this PR! I'll look in the next day or two. Apologies it's been out there for so long! -- This is an automated message from the Apache Git Service.

[GitHub] [lucene] Yuti-G commented on pull request #1035: LUCENE-10652: Add a top-n range faceting example to RangeFacetsExample

2022-09-07 Thread GitBox
Yuti-G commented on PR #1035: URL: https://github.com/apache/lucene/pull/1035#issuecomment-1240055428 Thanks @gsmiller! It's not urgent at all, and just wanted to let you know that the new PR has incorporated your previous feedback. Thanks again for making time :) -- This is an automated

[GitHub] [lucene] gsmiller commented on a diff in pull request #1035: LUCENE-10652: Add a top-n range faceting example to RangeFacetsExample

2022-09-07 Thread GitBox
gsmiller commented on code in PR #1035: URL: https://github.com/apache/lucene/pull/1035#discussion_r965402810 ## lucene/demo/src/java/org/apache/lucene/demo/facet/RangeFacetsExample.java: ## @@ -73,6 +77,31 @@ public void index() throws IOException { indexWriter.addDocume

[GitHub] [lucene] rmuir commented on issue #11755: TestIndexWriterOnDiskFull.testAddDocumentOnDiskFull failure

2022-09-07 Thread GitBox
rmuir commented on issue #11755: URL: https://github.com/apache/lucene/issues/11755#issuecomment-1240105751 The issue is caused by an exception-handling inconsistency in IndexWriter: if a fatal error (tragedy) happens to IndexWriter, you may receive exception in one of two ways: * `IOExc

[GitHub] [lucene] rmuir commented on issue #11755: TestIndexWriterOnDiskFull.testAddDocumentOnDiskFull failure

2022-09-07 Thread GitBox
rmuir commented on issue #11755: URL: https://github.com/apache/lucene/issues/11755#issuecomment-1240113769 The failure doesn't reproduce/debug very easily because CMS needs to hit disk full after `prepareCommit()` (which calls `ensureOpen` and delivers `IOException` for a tragedy), and ins

[GitHub] [lucene] rmuir commented on issue #11755: TestIndexWriterOnDiskFull.testAddDocumentOnDiskFull failure

2022-09-07 Thread GitBox
rmuir commented on issue #11755: URL: https://github.com/apache/lucene/issues/11755#issuecomment-1240123892 Maybe i'm being overly picky, if you look at the rest of the tests. This test is named `testAddDocumentOnDiskFull` and looks for an ACE (IOException) on addDocument(). But rarel

[GitHub] [lucene] rmuir opened a new pull request, #11757: Fix TestIndexWriterOnDiskFull.testAddDocumentOnDiskFull to handle IllegalStateException from startCommit()

2022-09-07 Thread GitBox
rmuir opened a new pull request, #11757: URL: https://github.com/apache/lucene/pull/11757 If ConcurrentMergeScheduler is used, and the merge hits fatal exception (such as disk full) after prepareCommit()'s ensureOpen() check, then startCommit() will throw IllegalStateException instead of A

[GitHub] [lucene] rmuir commented on issue #11755: TestIndexWriterOnDiskFull.testAddDocumentOnDiskFull failure

2022-09-07 Thread GitBox
rmuir commented on issue #11755: URL: https://github.com/apache/lucene/issues/11755#issuecomment-1240128853 I made a PR just fixing this test to handle this around the `commit()` call so it won't randomly fail in CI again. -- This is an automated message from the Apache Git Service. To re

[GitHub] [lucene] rmuir commented on a diff in pull request #11738: Optimize MultiTermQueryConstantScoreWrapper for case when a term matches all docs in a segment.

2022-09-07 Thread GitBox
rmuir commented on code in PR #11738: URL: https://github.com/apache/lucene/pull/11738#discussion_r965442751 ## lucene/core/src/java/org/apache/lucene/search/MultiTermQueryConstantScoreWrapper.java: ## @@ -165,9 +143,46 @@ private WeightOrDocIdSet rewrite(LeafReaderContext cont

[GitHub] [lucene] rmuir commented on a diff in pull request #11738: Optimize MultiTermQueryConstantScoreWrapper for case when a term matches all docs in a segment.

2022-09-07 Thread GitBox
rmuir commented on code in PR #11738: URL: https://github.com/apache/lucene/pull/11738#discussion_r965449782 ## lucene/core/src/java/org/apache/lucene/search/MultiTermQueryConstantScoreWrapper.java: ## @@ -165,9 +143,46 @@ private WeightOrDocIdSet rewrite(LeafReaderContext cont

[GitHub] [lucene] jmazanec15 commented on pull request #1068: LUCENE-10674: Update subiterators when BitSetConjDISI exhausts

2022-09-07 Thread GitBox
jmazanec15 commented on PR #1068: URL: https://github.com/apache/lucene/pull/1068#issuecomment-1240159528 @zhaih Thanks! Added entry for 9.5 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene] Yuti-G commented on a diff in pull request #1035: LUCENE-10652: Add a top-n range faceting example to RangeFacetsExample

2022-09-07 Thread GitBox
Yuti-G commented on code in PR #1035: URL: https://github.com/apache/lucene/pull/1035#discussion_r965481865 ## lucene/CHANGES.txt: ## @@ -52,6 +52,8 @@ Improvements * LUCENE-10614: Properly support getTopChildren in RangeFacetCounts. (Yuting Gan) +* LUCENE-10652: Add a top