[GitHub] [lucene] jpountz commented on a diff in pull request #11743: LUCENE-10592 Better estimate memory for HNSW graph

2022-09-05 Thread GitBox
jpountz commented on code in PR #11743: URL: https://github.com/apache/lucene/pull/11743#discussion_r962569779 ## lucene/core/src/test/org/apache/lucene/util/TestRamUsageEstimator.java: ## @@ -222,6 +229,28 @@ public void testPrintValues() { System.out.println("LONG_SIZE =

[GitHub] [lucene] dweiss commented on a diff in pull request #11743: LUCENE-10592 Better estimate memory for HNSW graph

2022-09-05 Thread GitBox
dweiss commented on code in PR #11743: URL: https://github.com/apache/lucene/pull/11743#discussion_r962606272 ## lucene/core/src/test/org/apache/lucene/util/hnsw/TestHnswGraph.java: ## @@ -74,12 +74,8 @@ public void setup() { similarityFunction = VectorSimilarityFu

[GitHub] [lucene] msokolov commented on pull request #11743: LUCENE-10592 Better estimate memory for HNSW graph

2022-09-05 Thread GitBox
msokolov commented on PR #11743: URL: https://github.com/apache/lucene/pull/11743#issuecomment-1236890998 > One thing I wonder we did not observe longer total indexing time (combined indexing + refresh time). Did combined total indexing time + refresh time became larger for you? The

[GitHub] [lucene] msokolov commented on pull request #11743: LUCENE-10592 Better estimate memory for HNSW graph

2022-09-05 Thread GitBox
msokolov commented on PR #11743: URL: https://github.com/apache/lucene/pull/11743#issuecomment-1236894645 > I wonder if we should consider rolling back the "build graph during indexing" change? It seems to make indexing take > 10% longer and of course requires more RAM, which will tend to m

[GitHub] [lucene] jpountz commented on pull request #11743: LUCENE-10592 Better estimate memory for HNSW graph

2022-09-05 Thread GitBox
jpountz commented on PR #11743: URL: https://github.com/apache/lucene/pull/11743#issuecomment-1236975827 I like the idea of exploring a combination of the current approach and on-disk buffering to flush less often. For the record, the approach of building the graph at flush time has a

[GitHub] [lucene] jpountz commented on pull request #11743: LUCENE-10592 Better estimate memory for HNSW graph

2022-09-05 Thread GitBox
jpountz commented on PR #11743: URL: https://github.com/apache/lucene/pull/11743#issuecomment-1236990320 Woops I just reread @msokolov 's comment and it was not actually about buffering on disk, more about moving them to disk before starting to build the graph. Sorry for the confusion. I th

[GitHub] [lucene-solr] jtibshirani closed pull request #1314: LUCENE-9136: Coarse quantization that reuses existing formats.

2022-09-05 Thread GitBox
jtibshirani closed pull request #1314: LUCENE-9136: Coarse quantization that reuses existing formats. URL: https://github.com/apache/lucene-solr/pull/1314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene-solr] itygh commented on pull request #1314: LUCENE-9136: Coarse quantization that reuses existing formats.

2022-09-05 Thread GitBox
itygh commented on PR #1314: URL: https://github.com/apache/lucene-solr/pull/1314#issuecomment-1237543254 这是来自QQ邮箱的假期自动回复邮件。您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR