[GitHub] [lucene] dweiss commented on pull request #11748: Add tidy after addVersion is called.

dweiss commented on PR #11748: URL: https://github.com/apache/lucene/pull/11748#issuecomment-1236275582 Jan (@janhoy), do you know if this is the right syntax/ way to format code after an automatic addition of a new version? -- This is an automated message from the Apache Git Service. To

[GitHub] [lucene] matriv opened a new pull request, #11749: Remove usages of System.currentTimeMillis() from tests

matriv opened a new pull request, #11749: URL: https://github.com/apache/lucene/pull/11749 ### Description - Use Random from `RandomizedRunner` to be able to use a Seed to reproduce tests, instead of a seed coming from wall clock. - Replace time based tests, using wall clock to

[GitHub] [lucene] iamorchid opened a new issue, #11750: Why we don't drop changes in pendingDVUpdates here?

iamorchid opened a new issue, #11750: URL: https://github.com/apache/lucene/issues/11750 https://github.com/apache/lucene/blob/84cae4f27cfd3feb3bb42d5a9f7ce034f7a31573/lucene/core/src/java/org/apache/lucene/index/ReadersAndUpdates.java#L264 -- This is an automated message from the Apache

[GitHub] [lucene] iamorchid opened a new issue, #11751: DV updates files used by a merge could be deleted by other concurrent flushes

iamorchid opened a new issue, #11751: URL: https://github.com/apache/lucene/issues/11751 https://github.com/apache/lucene/blob/84cae4f27cfd3feb3bb42d5a9f7ce034f7a31573/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java#L5075 For merge, I see that the following logic are use

[GitHub] [lucene] msokolov commented on pull request #11743: LUCENE-10592 Better estimate memory for HNSW graph

msokolov commented on PR #11743: URL: https://github.com/apache/lucene/pull/11743#issuecomment-1236325605 I ran a test using KnnGraphTester, setting IndexWriterConfig max buffer size to 250MB. I indexed 1M 256-dim docs (1K each, so 1GB in total) Results with 9.3: ``` 4 segments

[GitHub] [lucene] msokolov commented on pull request #11743: LUCENE-10592 Better estimate memory for HNSW graph

msokolov commented on PR #11743: URL: https://github.com/apache/lucene/pull/11743#issuecomment-1236326177 I wonder if we should consider rolling back the "build graph during indexing" change? It seems to make indexing take > 10% longer and of course requires more RAM, which will tend to mak

[GitHub] [lucene] janhoy commented on pull request #11748: Add tidy after addVersion is called.

janhoy commented on PR #11748: URL: https://github.com/apache/lucene/pull/11748#issuecomment-1236384399 > Jan (@janhoy), do you know if this is the right syntax/ way to format code after an automatic addition of a new version? Please use `{{ gradle_cmd }}`, Else it looks good. It migh

[GitHub] [lucene] dweiss commented on pull request #11748: Add tidy after addVersion is called.

dweiss commented on PR #11748: URL: https://github.com/apache/lucene/pull/11748#issuecomment-1236387310 Thanks, Jan! I missed it somehow. I'll leave tidy to run on an entire project - it's fast enough and if anything ever changes, it prevents accidental regressions. -- This is an automa

[GitHub] [lucene] dweiss merged pull request #11748: Add tidy after addVersion is called.

dweiss merged PR #11748: URL: https://github.com/apache/lucene/pull/11748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] navneet1v opened a new issue, #11752: Enable Relate Interface of Shape Doc Values to be used by clients of Lucene

navneet1v opened a new issue, #11752: URL: https://github.com/apache/lucene/issues/11752 ### Description With the release of ShapeDocValues and ShapeDoc Values field(LUCENE-10654), it provides various interfaces to create the query and create the different ShapeDoc values. But it doe

[GitHub] [lucene] navneet1v opened a new pull request, #11753: Added interface to relate a LatLonShape with another shape represented as Component2D

navneet1v opened a new pull request, #11753: URL: https://github.com/apache/lucene/pull/11753 ### Description Added interface to relate a LatLonShape with another shape represented as Component2D. ### Issues #11752 -- This is an automated message from the Apache Git Serv

[GitHub] [lucene] mayya-sharipova commented on pull request #11743: LUCENE-10592 Better estimate memory for HNSW graph

mayya-sharipova commented on PR #11743: URL: https://github.com/apache/lucene/pull/11743#issuecomment-1236414077 @msokolov Thanks for your feedback. I have done a similar analysis comparing 9.3 branch with this change on `glove-100-angular` 1 million documents, M:16 efConstruction:10