[GitHub] [lucene] uschindler commented on pull request #11726: Prevent term vectors from exceeding the maximum dictionary size.

2022-08-30 Thread GitBox
uschindler commented on PR #11726: URL: https://github.com/apache/lucene/pull/11726#issuecomment-1231864154 I figured out that you can tell JIRA to attach the compressed build log to the error mail. I will try this on Policeman Jenkins. In addition I will add a simple Regex on all rep

[GitHub] [lucene] MarcusSorealheis opened a new issue, #11730: FSTs are Always Run in OFF_HEAP Load Mode

2022-08-30 Thread GitBox
MarcusSorealheis opened a new issue, #11730: URL: https://github.com/apache/lucene/issues/11730 ### Description In testing internally, we have found that FSTs always load in OFF_HEAP mode. If you are not using an MMAP directory, some queries could result in system call overhead via N

[GitHub] [lucene] MarcusSorealheis commented on issue #11730: FSTs are Always Run in OFF_HEAP Load Mode

2022-08-30 Thread GitBox
MarcusSorealheis commented on issue #11730: URL: https://github.com/apache/lucene/issues/11730#issuecomment-1232004896 I'm not totally sure about this, and I don't think the team is either based on their comments, but there's a chance I'm missing something. -- This is an automated message

[GitHub] [lucene] MarcusSorealheis opened a new pull request, #11731: 11730 removed unused fst load mode

2022-08-30 Thread GitBox
MarcusSorealheis opened a new pull request, #11731: URL: https://github.com/apache/lucene/pull/11731 ### Description This pull request removes the `ON_HEAP` load mode for finite state machines. If FSTs are not MMAPped, they are read from disk using NIO FS. I did not see a way to force `O

[GitHub] [lucene] MarcusSorealheis commented on pull request #11731: 11730 removed unused fst load mode

2022-08-30 Thread GitBox
MarcusSorealheis commented on PR #11731: URL: https://github.com/apache/lucene/pull/11731#issuecomment-1232014930 It's linked to this issue: https://github.com/apache/lucene/issues/11730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [lucene] MarcusSorealheis commented on pull request #11731: 11730 removed unused fst load mode

2022-08-30 Thread GitBox
MarcusSorealheis commented on PR #11731: URL: https://github.com/apache/lucene/pull/11731#issuecomment-1232015684 The MLT commit did not belong in the working tree. I removed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene] elliotzlin commented on pull request #11724: LUCENE-10520 / #11556 HTMLStripCharFilter bugfix

2022-08-30 Thread GitBox
elliotzlin commented on PR #11724: URL: https://github.com/apache/lucene/pull/11724#issuecomment-1232037743 I hadn't even noticed that! I hope it's not some JFlex side-effect that I unwittingly triggered with my change. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #3125: LUCENE-10633 Disable sort optimization for SortedSetSortField

2022-08-30 Thread GitBox
mayya-sharipova commented on code in PR #3125: URL: https://github.com/apache/lucene/pull/3125#discussion_r958911334 ## lucene/core/src/java/org/apache/lucene/search/SortField.java: ## @@ -627,31 +634,35 @@ public IndexSorter getIndexSorter() { } /** - * Enables/disabl

[GitHub] [lucene] mayya-sharipova merged pull request #3125: LUCENE-10633 Disable sort optimization for SortedSetSortField

2022-08-30 Thread GitBox
mayya-sharipova merged PR #3125: URL: https://github.com/apache/lucene/pull/3125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@luce

[GitHub] [lucene] rmuir commented on pull request #11724: LUCENE-10520 / #11556 HTMLStripCharFilter bugfix

2022-08-30 Thread GitBox
rmuir commented on PR #11724: URL: https://github.com/apache/lucene/pull/11724#issuecomment-1232192192 I don't think you did anything wrong. The changes look fine, it is just a real puzzler. I even cloned your repo and inspected the enormous diff to the generated code and I only see

[GitHub] [lucene] MarcusSorealheis commented on pull request #11731: 11730 removed unused fst load mode

2022-08-30 Thread GitBox
MarcusSorealheis commented on PR #11731: URL: https://github.com/apache/lucene/pull/11731#issuecomment-1232250879 Ok, so I did identify how an advanced user can still get FSTs to be loaded in heap (via service provider initialization). -- This is an automated message from the Apache Git