[GitHub] [lucene] msokolov commented on a diff in pull request #1076: Add safety checks to KnnVectorField; fixed issue with copying BytesRef

msokolov commented on code in PR #1076: URL: https://github.com/apache/lucene/pull/1076#discussion_r950691134 ## lucene/core/src/java/org/apache/lucene/index/VectorEncoding.java: ## @@ -21,12 +21,8 @@ public enum VectorEncoding { /** - * Encodes vector using 8 bits of pr

[GitHub] [lucene] msokolov merged pull request #1076: Add safety checks to KnnVectorField; fixed issue with copying BytesRef

msokolov merged PR #1076: URL: https://github.com/apache/lucene/pull/1076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] msokolov merged pull request #1075: don't call BitSet.cardinality() more than needed

msokolov merged PR #1075: URL: https://github.com/apache/lucene/pull/1075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] msokolov commented on pull request #1074: Fix for bad cast when sorting a KnnVectors index over BytesRef

msokolov commented on PR #1074: URL: https://github.com/apache/lucene/pull/1074#issuecomment-1221307962 hmm new testRandomBytes failed with seed CBC12662A8273C68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] msokolov commented on a diff in pull request #1073: fix VectorUtil.dotProductScore normalization

msokolov commented on code in PR #1073: URL: https://github.com/apache/lucene/pull/1073#discussion_r950691627 ## lucene/core/src/java/org/apache/lucene/util/VectorUtil.java: ## @@ -270,7 +270,8 @@ public static float dotProduct(BytesRef a, BytesRef b) { */ public static f

[GitHub] [lucene] msokolov merged pull request #1073: fix VectorUtil.dotProductScore normalization

msokolov merged PR #1073: URL: https://github.com/apache/lucene/pull/1073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] msokolov merged pull request #1074: Fix for bad cast when sorting a KnnVectors index over BytesRef

msokolov merged PR #1074: URL: https://github.com/apache/lucene/pull/1074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac