[jira] [Commented] (LUCENE-10658) Merges should periodically check for abort

2022-07-20 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568962#comment-17568962 ] Michael McCandless commented on LUCENE-10658: - +1, merges should abort prom

[jira] [Updated] (LUCENE-10656) It is unnecessary that using `limit` to check boundary

2022-07-20 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lu Xugang updated LUCENE-10656: --- Fix Version/s: (was: 9.3) > It is unnecessary that using `limit` to check boundary > --

[GitHub] [lucene] luyuncheng commented on a diff in pull request #987: LUCENE-10627: Using ByteBuffersDataInput reduce memory copy on compressing data

2022-07-20 Thread GitBox
luyuncheng commented on code in PR #987: URL: https://github.com/apache/lucene/pull/987#discussion_r925476227 ## lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java: ## @@ -165,6 +165,36 @@ public void readBytes(byte[] arr, int off, int len) throws EOFExcepti

[GitHub] [lucene-jira-archive] mocobeta commented on issue #27: Improve the `Jira Information` header?

2022-07-20 Thread GitBox
mocobeta commented on issue #27: URL: https://github.com/apache/lucene-jira-archive/issues/27#issuecomment-1190202161 Hi @mikemccand, I plan to start the next (hopefully last) migration test for all issues on July 25th. Could you merge improvements in your mind for `jira2github_import.py`

[GitHub] [lucene-jira-archive] mocobeta commented on issue #54: Hyperlinks are sometimes not actual links on import

2022-07-20 Thread GitBox
mocobeta commented on issue #54: URL: https://github.com/apache/lucene-jira-archive/issues/54#issuecomment-1190208864 I'll take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [lucene-jira-archive] mocobeta commented on issue #54: Hyperlinks are sometimes not actual links on import

2022-07-20 Thread GitBox
mocobeta commented on issue #54: URL: https://github.com/apache/lucene-jira-archive/issues/54#issuecomment-1190235323 It looks like it's an expected behavior of GitHub's Markdown rendering. Any string surrounded by `[]` is not interpreted as a hyperlink. ![Screenshot from 2022-07-20

[GitHub] [lucene-jira-archive] mikemccand commented on issue #54: Hyperlinks are sometimes not actual links on import

2022-07-20 Thread GitBox
mikemccand commented on issue #54: URL: https://github.com/apache/lucene-jira-archive/issues/54#issuecomment-1190282496 Ahh thanks @mocobeta! I wonder why GitHub doesn't render links in [ .. ]? The problem is, this is a fairly frequent occurrence since `commitbot` formats the link i

[GitHub] [lucene-jira-archive] mikemccand commented on issue #27: Improve the `Jira Information` header?

2022-07-20 Thread GitBox
mikemccand commented on issue #27: URL: https://github.com/apache/lucene-jira-archive/issues/27#issuecomment-1190337880 > Hi @mikemccand, I plan to start the next (hopefully last) migration test for all issues on July 25th. Could you merge improvements in your mind for `jira2github_import.

[GitHub] [lucene-jira-archive] mocobeta commented on issue #54: Hyperlinks are sometimes not actual links on import

2022-07-20 Thread GitBox
mocobeta commented on issue #54: URL: https://github.com/apache/lucene-jira-archive/issues/54#issuecomment-1190347139 I think humans are unlikely to make comments such as `[ http:// ]`? I'm +1 to only apply a special conversion for commitbot's comments; it's easy to filter commen

[GitHub] [lucene-jira-archive] mocobeta commented on issue #54: Hyperlinks are sometimes not actual links on import

2022-07-20 Thread GitBox
mocobeta commented on issue #54: URL: https://github.com/apache/lucene-jira-archive/issues/54#issuecomment-1190348875 > Or perhaps we specialize this to commitbot comments only? If this is okay with you, I can make a PR. -- This is an automated message from the Apache Git Service.

[GitHub] [lucene] mayya-sharipova commented on pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-20 Thread GitBox
mayya-sharipova commented on PR #992: URL: https://github.com/apache/lucene/pull/992#issuecomment-1190373448 > Would you be able to check how the indexing rate compares when index sorting is enabled? @jpountz Thanks, I will do the comparison. -- This is an automated message from t

[GitHub] [lucene] JoeHF commented on a diff in pull request #1003: LUCENE-10616: optimizing decompress when only retrieving some fields

2022-07-20 Thread GitBox
JoeHF commented on code in PR #1003: URL: https://github.com/apache/lucene/pull/1003#discussion_r925768424 ## lucene/core/src/java/org/apache/lucene/document/DocumentStoredFieldVisitor.java: ## @@ -98,6 +100,16 @@ public void doubleField(FieldInfo fieldInfo, double value) {

[GitHub] [lucene] gsmiller commented on pull request #1013: LUCENE-10644: Facets#getAllChildren testing should ignore child order

2022-07-20 Thread GitBox
gsmiller commented on PR #1013: URL: https://github.com/apache/lucene/pull/1013#issuecomment-1190614346 Sounds good. Thanks @Yuti-G! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Created] (LUCENE-10659) Fix random TestDisiPriorityQueue bug

2022-07-20 Thread Greg Miller (Jira)
Greg Miller created LUCENE-10659: Summary: Fix random TestDisiPriorityQueue bug Key: LUCENE-10659 URL: https://issues.apache.org/jira/browse/LUCENE-10659 Project: Lucene - Core Issue Type: Bu

[GitHub] [lucene] mayya-sharipova commented on pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-20 Thread GitBox
mayya-sharipova commented on PR #992: URL: https://github.com/apache/lucene/pull/992#issuecomment-1190803247 @jpountz I have run another set of benchmarks on dataset **sift-128-euclidean M:16 efConstruction:100 with index sort on SortField.Type.LONG**, where I added an extra index sort

[jira] [Commented] (LUCENE-10659) Fix random TestDisiPriorityQueue bug

2022-07-20 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569184#comment-17569184 ] Greg Miller commented on LUCENE-10659: -- PR for pulling this fix into 9.3: https://

[jira] [Updated] (LUCENE-10659) Fix random TestDisiPriorityQueue bug

2022-07-20 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller updated LUCENE-10659: - Priority: Blocker (was: Minor) > Fix random TestDisiPriorityQueue bug > --

[GitHub] [lucene-jira-archive] mikemccand commented on issue #54: Hyperlinks are sometimes not actual links on import

2022-07-20 Thread GitBox
mikemccand commented on issue #54: URL: https://github.com/apache/lucene-jira-archive/issues/54#issuecomment-1190854358 > If this is okay with you, I can make a PR. +1, thank you @mocobeta! -- This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Commented] (LUCENE-10655) can we optimize visited bitset usage in HNSW graph search/indexing?

2022-07-20 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569208#comment-17569208 ] Julie Tibshirani commented on LUCENE-10655: --- [~sokolov] I ran a bunch of simi

[GitHub] [lucene] jtibshirani commented on pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-20 Thread GitBox
jtibshirani commented on PR #992: URL: https://github.com/apache/lucene/pull/992#issuecomment-1190948650 Thanks for running these new benchmarks. It's good to see that the remapping time isn't too high. It's a bit confusing that the baseline slows down so much from 533s to 654s, whic

[jira] [Commented] (LUCENE-10404) Use hash set for visited nodes in HNSW search?

2022-07-20 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569237#comment-17569237 ] Julie Tibshirani commented on LUCENE-10404: --- As a note, LUCENE-10592 changes

[GitHub] [lucene] jtibshirani commented on a diff in pull request #992: LUCENE-10592 Build HNSW Graph on indexing

2022-07-20 Thread GitBox
jtibshirani commented on code in PR #992: URL: https://github.com/apache/lucene/pull/992#discussion_r926196192 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java: ## @@ -203,8 +204,11 @@ private NeighborQueue searchLevel( return results; } - pr

[GitHub] [lucene] zacharymorn opened a new pull request, #1039: LUCENE-10635: Ensure test coverage for WANDScorer by using a test query

2022-07-20 Thread GitBox
zacharymorn opened a new pull request, #1039: URL: https://github.com/apache/lucene/pull/1039 ### Description (or a Jira issue link if you have one) Ensure test coverage for WANDScorer by using a test query -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [lucene] zacharymorn commented on pull request #1039: LUCENE-10635: Ensure test coverage for WANDScorer by using a test query

2022-07-20 Thread GitBox
zacharymorn commented on PR #1039: URL: https://github.com/apache/lucene/pull/1039#issuecomment-1191043324 I guess this will go into `10.0.0`, as `9.3` has already been cut and the PR is test only? -- This is an automated message from the Apache Git Service. To respond to the message, ple