[GitHub] [lucene] shaie commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-16 Thread GitBox
shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1157313525 Actually there weren't many conflicts so pushed my commit, we can now compare the two options side-by-side. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [lucene] jpountz commented on pull request #961: Handle more cases in `BooleanWeight#count`.

2022-06-16 Thread GitBox
jpountz commented on PR #961: URL: https://github.com/apache/lucene/pull/961#issuecomment-1157403188 Thanks for the review, I pushed a comment to clarify that more cases could be handled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Created] (LUCENE-10620) Can we pass the Weight to Collector?

2022-06-16 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10620: - Summary: Can we pass the Weight to Collector? Key: LUCENE-10620 URL: https://issues.apache.org/jira/browse/LUCENE-10620 Project: Lucene - Core Issue Type:

[GitHub] [lucene] jpountz opened a new pull request, #964: LUCENE-10620: Pass the Weight to Collectors.

2022-06-16 Thread GitBox
jpountz opened a new pull request, #964: URL: https://github.com/apache/lucene/pull/964 This allows `Collector`s to use `Weight#count` when appropriate. See [LUCENE-10620](https://issues.apache.org/jira/browse/LUCENE-10620). -- This is an automated message from the Apache Git Servic

[jira] [Commented] (LUCENE-10620) Can we pass the Weight to Collector?

2022-06-16 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555001#comment-17555001 ] Adrien Grand commented on LUCENE-10620: --- I opened a draft PR that demonstrates th

[GitHub] [lucene] kaivalnp commented on a diff in pull request #958: LUCENE-10611: Fix Heap Error in HnswGraphSearcher

2022-06-16 Thread GitBox
kaivalnp commented on code in PR #958: URL: https://github.com/apache/lucene/pull/958#discussion_r898955669 ## lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java: ## @@ -498,7 +498,7 @@ public void testRandom() throws IOException { /** Tests with random v

[GitHub] [lucene] kaivalnp commented on a diff in pull request #958: LUCENE-10611: Fix Heap Error in HnswGraphSearcher

2022-06-16 Thread GitBox
kaivalnp commented on code in PR #958: URL: https://github.com/apache/lucene/pull/958#discussion_r898967077 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java: ## @@ -87,10 +87,14 @@ public static NeighborQueue search( int numVisited = 0; for (i

[GitHub] [lucene] romseygeek commented on a diff in pull request #964: LUCENE-10620: Pass the Weight to Collectors.

2022-06-16 Thread GitBox
romseygeek commented on code in PR #964: URL: https://github.com/apache/lucene/pull/964#discussion_r898969670 ## lucene/core/src/java/org/apache/lucene/search/TotalHitCountCollector.java: ## @@ -16,13 +16,17 @@ */ package org.apache.lucene.search; +import java.io.IOExceptio

[jira] [Created] (LUCENE-10621) Upgrade to OpenNLP 2.0 and add

2022-06-16 Thread Jeff Zemerick (Jira)
Jeff Zemerick created LUCENE-10621: -- Summary: Upgrade to OpenNLP 2.0 and add Key: LUCENE-10621 URL: https://issues.apache.org/jira/browse/LUCENE-10621 Project: Lucene - Core Issue Type: Tas

[jira] [Updated] (LUCENE-10621) Upgrade to OpenNLP 2.0 and add

2022-06-16 Thread Jeff Zemerick (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Zemerick updated LUCENE-10621: --- Description: Apache OpenNLP 2.0.0 has been released. This [version|https://opennlp.apache.

[jira] [Updated] (LUCENE-10619) Optimize the writeBytes in TermsHashPerField

2022-06-16 Thread tangdh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tangdh updated LUCENE-10619: Description: Because we don't know the length of slice, writeBytes will always write byte one after anot

[GitHub] [lucene] LuXugang merged pull request #962: LUCENE-10600: (backport)SortedSetDocValues#docValueCount should be an int, not long (#960)

2022-06-16 Thread GitBox
LuXugang merged PR #962: URL: https://github.com/apache/lucene/pull/962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache

[jira] [Commented] (LUCENE-10600) SortedSetDocValues#docValueCount should be an int, not long

2022-06-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555127#comment-17555127 ] ASF subversion and git services commented on LUCENE-10600: -- Co

[GitHub] [lucene] gsmiller commented on a diff in pull request #922: Index only the docs for FacetField posting list

2022-06-16 Thread GitBox
gsmiller commented on code in PR #922: URL: https://github.com/apache/lucene/pull/922#discussion_r899250685 ## lucene/CHANGES.txt: ## @@ -67,6 +67,8 @@ Other * LUCENE-10493: Factor out Viterbi algorithm in Kuromoji and Nori to analysis-common. (Tomoko Uchida) +* Remove unu

[jira] [Commented] (LUCENE-10577) Quantize vector values

2022-06-16 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555170#comment-17555170 ] Michael Sokolov commented on LUCENE-10577: -- I'm open to doing this with a diff

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #922: Index only the docs for FacetField posting list

2022-06-16 Thread GitBox
gautamworah96 commented on code in PR #922: URL: https://github.com/apache/lucene/pull/922#discussion_r899384834 ## lucene/CHANGES.txt: ## @@ -67,6 +67,8 @@ Other * LUCENE-10493: Factor out Viterbi algorithm in Kuromoji and Nori to analysis-common. (Tomoko Uchida) +* Remov

[GitHub] [lucene] jtibshirani merged pull request #958: LUCENE-10611: Fix Heap Error in HnswGraphSearcher

2022-06-16 Thread GitBox
jtibshirani merged PR #958: URL: https://github.com/apache/lucene/pull/958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[jira] [Commented] (LUCENE-10611) KnnVectorQuery throwing Heap Error for Restrictive Filters

2022-06-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555258#comment-17555258 ] ASF subversion and git services commented on LUCENE-10611: -- Co

[jira] [Commented] (LUCENE-10611) KnnVectorQuery throwing Heap Error for Restrictive Filters

2022-06-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555259#comment-17555259 ] ASF subversion and git services commented on LUCENE-10611: -- Co

[jira] [Commented] (LUCENE-10611) KnnVectorQuery throwing Heap Error for Restrictive Filters

2022-06-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555263#comment-17555263 ] ASF subversion and git services commented on LUCENE-10611: -- Co

[jira] [Resolved] (LUCENE-10611) KnnVectorQuery throwing Heap Error for Restrictive Filters

2022-06-16 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani resolved LUCENE-10611. --- Fix Version/s: 9.3 Resolution: Fixed > KnnVectorQuery throwing Heap Error fo

[jira] [Commented] (LUCENE-10583) Deadlock with MMapDirectory while waitForMerges

2022-06-16 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555272#comment-17555272 ] Vigya Sharma commented on LUCENE-10583: --- Created [PR #963|https://github.com/apac

[GitHub] [lucene] JoeHF opened a new pull request, #965: LUCENE-10618: Implement BooleanQuery rewrite rules based for minimumShouldMatch

2022-06-16 Thread GitBox
JoeHF opened a new pull request, #965: URL: https://github.com/apache/lucene/pull/965 ### Description (or a Jira issue link if you have one) Detailed discussion see: https://issues.apache.org/jira/browse/LUCENE-10618 -- This is an automated message from the Apache Git Service. T

[jira] [Updated] (LUCENE-10557) Migrate to GitHub issue from Jira

2022-06-16 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10557: --- Description: A few (not the majority) Apache projects already use the GitHub issue instead

[jira] [Updated] (LUCENE-10557) Migrate to GitHub issue from Jira

2022-06-16 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10557: --- Description: A few (not the majority) Apache projects already use the GitHub issue instead

[GitHub] [lucene] Yuti-G commented on a diff in pull request #914: LUCENE-10550: Add getAllChildren functionality to facets

2022-06-16 Thread GitBox
Yuti-G commented on code in PR #914: URL: https://github.com/apache/lucene/pull/914#discussion_r899773538 ## lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java: ## @@ -346,6 +346,43 @@ private void increment(long value) { } } + @Override + public