uschindler commented on PR #895:
URL: https://github.com/apache/lucene/pull/895#issuecomment-1128502847
What I wanted to add: Merging is mostly an IO thing. More cores would not
necessarily make it faster (your SSD has a limited amount of parallelism). It
may be better on different indexes
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128594358
The previous CI run result looks good to me. I also enabled GUI tests in the
smoke tester.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128599401
How about renaming the action's directory name
`.github/actions/yarn-caches/` to `.github/actions/gradle-caches/`? @dweiss
--
This is an automated message from the Apache Git Service.
To
dweiss commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128601383
up to you, entirely. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dweiss commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128601991
The yarn-caches name is wrong - it's something else I was working (!).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128605453
I'll update the directory name later.
This time, the test timed out on Windows... I think this could occasionally
happen :/
--
This is an automated message from the Apache Git Serv
dweiss commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128610332
Increase the timeout, maybe? Windows boxes on github are slow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128612813
I increased the timeout to 120 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128664466
sorry couldn't resist.
"Build Duke"
--
This is an automa
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128676036
Passed all checks and I think we've done all I wanted to do here - we
disabled the GUI test in the mandatory test runs, instead, we enabled it on all
CI runs (Jenkins, GH Actions) and the s
[
https://issues.apache.org/jira/browse/LUCENE-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-10575.
Fix Version/s: 9.2
Resolution: Fixed
> Broken links in some javadocs
> ---
jpountz commented on PR #895:
URL: https://github.com/apache/lucene/pull/895#issuecomment-1128736566
The current calculation makes sense to me. Merge policies like to organize
segments into tiers, where the number of segments on each tier is typically
also the number of segments that can be
jpountz closed pull request #892: LUCENE-10573: Improve stored fields bulk
merge for degenerate O(n^2) merges.
URL: https://github.com/apache/lucene/pull/892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/LUCENE-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10573.
---
Resolution: Won't Fix
> Improve stored fields bulk merge for degenerate O(n^2) merges
> ---
[
https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538131#comment-17538131
]
Adrien Grand commented on LUCENE-10572:
---
If this is memory-bound, I wonder if we
[
https://issues.apache.org/jira/browse/LUCENE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538134#comment-17538134
]
Adrien Grand commented on LUCENE-10392:
---
[~shahrs87] I set the priority to minor,
jpountz commented on PR #873:
URL: https://github.com/apache/lucene/pull/873#issuecomment-1128797150
When the order is reversed, your change negates the `node` twice so that we
keep tie-breaking by increasing node IDs in all cases. With this fix, I wonder
if we could simplify the encoding l
[
https://issues.apache.org/jira/browse/LUCENE-10266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538150#comment-17538150
]
Adrien Grand commented on LUCENE-10266:
---
Let's add a method to `LatLonPoint` with
jpountz merged PR #876:
URL: https://github.com/apache/lucene/pull/876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538153#comment-17538153
]
ASF subversion and git services commented on LUCENE-9356:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538158#comment-17538158
]
ASF subversion and git services commented on LUCENE-9356:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-9356.
--
Fix Version/s: 9.2
Resolution: Fixed
I pushed to the 9.2 branch since it included some
[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538160#comment-17538160
]
ASF subversion and git services commented on LUCENE-9356:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-9356:
-
Summary: Add tests for mismatched checksums (was: Add tests for
corruptions caused by byte flip
risdenk commented on PR #895:
URL: https://github.com/apache/lucene/pull/895#issuecomment-1128827348
Fair enough - appreciate all the comments and additional context I couldn't
find in the linked jiras.
--
This is an automated message from the Apache Git Service.
To respond to the messag
risdenk closed pull request #895: LUCENE-10576: ConcurrentMergeScheduler
maxThreadCount calculation is artificially low
URL: https://github.com/apache/lucene/pull/895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
[
https://issues.apache.org/jira/browse/LUCENE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10576:
--
Resolution: Won't Fix
Status: Resolved (was: Patch Available)
> ConcurrentMergeSched
[
https://issues.apache.org/jira/browse/LUCENE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538164#comment-17538164
]
Kevin Risden commented on LUCENE-10576:
---
This is marked as won't fix since some r
jpountz opened a new pull request, #896:
URL: https://github.com/apache/lucene/pull/896
- Removed dependency on LineFileDocs to improve reproducibility.
- Relaxed the expected exception type: any exception is ok.
- Ignore rare cases when a file still appears to have a well-formed foo
[
https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538183#comment-17538183
]
Adrien Grand commented on LUCENE-10574:
---
I was assuming we wanted to have strong
mayya-sharipova commented on PR #876:
URL: https://github.com/apache/lucene/pull/876#issuecomment-1128871222
Thanks Adrien for catching errors with vector files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538194#comment-17538194
]
Robert Muir commented on LUCENE-10574:
--
I think another approach is to actually re
[
https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538198#comment-17538198
]
Uwe Schindler commented on LUCENE-10572:
If we have 2 hash tables, we could hav
[
https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538211#comment-17538211
]
Robert Muir commented on LUCENE-10572:
--
These measurements are also going to be st
jpountz commented on PR #896:
URL: https://github.com/apache/lucene/pull/896#issuecomment-1128913704
The test would still pass without the new checks (another check would fail
later), but I thought it was more consistent if we call `checkFooter` for every
`IndexInput` we open across all fil
[
https://issues.apache.org/jira/browse/LUCENE-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538284#comment-17538284
]
Mike Drob commented on LUCENE-10236:
[~zacharymorn] is this still relevant for 8.11
madrob commented on PR #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#issuecomment-1129013348
@anshumg does 8.11.2 need this, or should we close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/LUCENE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538321#comment-17538321
]
Chris M. Hostetter commented on LUCENE-10576:
-
Should those "reasonable ite
shahrs87 opened a new pull request, #897:
URL: https://github.com/apache/lucene/pull/897
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a short description of the approach taken
shahrs87 commented on PR #897:
URL: https://github.com/apache/lucene/pull/897#issuecomment-1129107476
@jpountz I have created this PR as per your suggestion in LUCENE-10266 jira.
I have made the following assumptions. Please correct me if needed.
1. I have deleted LatLonPointPrototypeQuer
[
https://issues.apache.org/jira/browse/LUCENE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538347#comment-17538347
]
Rushabh Shah commented on LUCENE-10392:
---
> unless you're already very familiar wi
cpoerschke opened a new pull request, #2656:
URL: https://github.com/apache/lucene-solr/pull/2656
backport of https://github.com/apache/lucene/pull/737 and
https://github.com/apache/lucene/pull/758
for https://issues.apache.org/jira/browse/LUCENE-10477 and
https://issues.apache.org/j
[
https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke reopened LUCENE-10477:
--
re-opening for potential backport:
https://github.com/apache/lucene-solr/pull/26
[
https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538389#comment-17538389
]
Michael Sokolov commented on LUCENE-10574:
--
I'm not sure if I understand, but
[
https://issues.apache.org/jira/browse/LUCENE-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538395#comment-17538395
]
Michael Sokolov commented on LUCENE-9625:
-
There's no support for using an exist
shahrs87 opened a new pull request, #898:
URL: https://github.com/apache/lucene/pull/898
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a short description of the approach ta
shahrs87 commented on PR #898:
URL: https://github.com/apache/lucene/pull/898#issuecomment-1129196482
Hi @dsmiley
Can you please help me review this patch ? I have tried to implement this
using your suggestion in the jira. Thank you.
--
This is an automated message from the Apache Git
thelabdude opened a new pull request, #2657:
URL: https://github.com/apache/lucene-solr/pull/2657
Backport of https://github.com/apache/solr/pull/865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538424#comment-17538424
]
Greg Miller commented on LUCENE-10544:
--
+1 to pursuing this delegating bulk scorer
Michael Sokolov created LUCENE-10577:
Summary: Quantize vector values
Key: LUCENE-10577
URL: https://issues.apache.org/jira/browse/LUCENE-10577
Project: Lucene - Core
Issue Type: Improvem
[
https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538448#comment-17538448
]
Adrien Grand commented on LUCENE-10574:
---
It's not about absolute segment sizes, i
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538451#comment-17538451
]
Robert Muir commented on LUCENE-10577:
--
I think a 2-byte float would be a better d
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538456#comment-17538456
]
Robert Muir commented on LUCENE-10577:
--
at least for fp16 we see some movement on
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538457#comment-17538457
]
Michael Sokolov commented on LUCENE-10577:
--
Actually what I have in mind is si
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538460#comment-17538460
]
Adrien Grand commented on LUCENE-10577:
---
Would it be possible to implement (1) wi
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538459#comment-17538459
]
Robert Muir commented on LUCENE-10577:
--
the actual operations you want to do need
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538467#comment-17538467
]
Michael Sokolov commented on LUCENE-10577:
--
Okay, thanks for the link [~rcmuir
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538467#comment-17538467
]
Michael Sokolov edited comment on LUCENE-10577 at 5/17/22 8:57 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538474#comment-17538474
]
Robert Muir commented on LUCENE-10577:
--
My main concern with some custom encoding
dsmiley commented on code in PR #898:
URL: https://github.com/apache/lucene/pull/898#discussion_r875264422
##
lucene/CHANGES.txt:
##
@@ -38,6 +38,8 @@ Improvements
* LUCENE-10416: Update Korean Dictionary to mecab-ko-dic-2.1.1-20180720 for
Nori.
(Uihyun Kim)
+* LUCENE-851
mdmarshmallow commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r875205786
##
lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/HyperRectangleFacetCounts.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundatio
shahrs87 commented on code in PR #898:
URL: https://github.com/apache/lucene/pull/898#discussion_r875270812
##
lucene/CHANGES.txt:
##
@@ -38,6 +38,8 @@ Improvements
* LUCENE-10416: Update Korean Dictionary to mecab-ko-dic-2.1.1-20180720 for
Nori.
(Uihyun Kim)
+* LUCENE-85
dsmiley commented on code in PR #898:
URL: https://github.com/apache/lucene/pull/898#discussion_r875271168
##
lucene/CHANGES.txt:
##
@@ -38,6 +38,8 @@ Improvements
* LUCENE-10416: Update Korean Dictionary to mecab-ko-dic-2.1.1-20180720 for
Nori.
(Uihyun Kim)
+* LUCENE-851
shahrs87 commented on code in PR #898:
URL: https://github.com/apache/lucene/pull/898#discussion_r875273788
##
lucene/CHANGES.txt:
##
@@ -38,6 +38,8 @@ Improvements
* LUCENE-10416: Update Korean Dictionary to mecab-ko-dic-2.1.1-20180720 for
Nori.
(Uihyun Kim)
+* LUCENE-85
msokolov opened a new pull request, #899:
URL: https://github.com/apache/lucene/pull/899
This is SCRATCH - not to be committed. It has numerous problems, but was
useful for testing and I share it as a first broken impl that can be improved.
Things TBD:
1. work out a better way to fi
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538494#comment-17538494
]
Michael Sokolov commented on LUCENE-10577:
--
> So if you can do stuff directly
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538499#comment-17538499
]
Robert Muir commented on LUCENE-10577:
--
Well, but comparing latency to the current
rmuir commented on code in PR #899:
URL: https://github.com/apache/lucene/pull/899#discussion_r875319253
##
lucene/core/src/java/org/apache/lucene/codecs/lucene92/ExpandingRandomAccessVectorValues.java:
##
@@ -0,0 +1,57 @@
+package org.apache.lucene.codecs.lucene92;
+
+import or
rmuir commented on code in PR #899:
URL: https://github.com/apache/lucene/pull/899#discussion_r875320987
##
lucene/core/src/java/org/apache/lucene/codecs/lucene92/ExpandingRandomAccessVectorValues.java:
##
@@ -0,0 +1,57 @@
+package org.apache.lucene.codecs.lucene92;
+
+import or
rmuir commented on code in PR #899:
URL: https://github.com/apache/lucene/pull/899#discussion_r875321513
##
lucene/core/src/java/org/apache/lucene/codecs/lucene92/ExpandingRandomAccessVectorValues.java:
##
@@ -0,0 +1,57 @@
+package org.apache.lucene.codecs.lucene92;
+
+import or
jtibshirani commented on PR #873:
URL: https://github.com/apache/lucene/pull/873#issuecomment-1129427428
Sorry for jumping in late with some thoughts. Because of the approximate
nature of HNSW, we are not guaranteed that the graph search will collect all
documents with the same score. There
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1129442757
I'm merging this only to main - let me know if it's worth backporting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
mocobeta merged PR #893:
URL: https://github.com/apache/lucene/pull/893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache
[
https://issues.apache.org/jira/browse/LUCENE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538521#comment-17538521
]
ASF subversion and git services commented on LUCENE-10531:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538522#comment-17538522
]
ASF subversion and git services commented on LUCENE-10531:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-10531.
Fix Version/s: 10.0 (main)
Resolution: Fixed
> Mark testLukeCanBeLaunched @Nightly
shaie commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r875458505
##
lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/DoubleHyperRectangle.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
dweiss commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1129612104
I'd apply this to 9x as well since it'll ease backports of other things/
decrease the potential of a conflict in the future?
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538598#comment-17538598
]
Uwe Schindler commented on LUCENE-10572:
bq. The stopwords are going to skew ev
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1129641582
Ok I'll backport it to the 9x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
80 matches
Mail list logo
