[GitHub] [lucene] uschindler commented on a diff in pull request #890: Detect CI builds and enable errorprone by default for those CI builds

2022-05-15 Thread GitBox
uschindler commented on code in PR #890: URL: https://github.com/apache/lucene/pull/890#discussion_r873128714 ## lucene/CHANGES.txt: ## @@ -211,7 +211,9 @@ Build * Upgrade forbiddenapis to version 3.3. (Uwe Schindler) -* LUCENE-10532: Remove LuceneTestCase.Slow annotation.

[GitHub] [lucene] uschindler commented on a diff in pull request #890: Detect CI builds and enable errorprone by default for those CI builds

2022-05-15 Thread GitBox
uschindler commented on code in PR #890: URL: https://github.com/apache/lucene/pull/890#discussion_r873138044 ## lucene/CHANGES.txt: ## @@ -211,7 +211,9 @@ Build * Upgrade forbiddenapis to version 3.3. (Uwe Schindler) -* LUCENE-10532: Remove LuceneTestCase.Slow annotation.

[GitHub] [lucene] mocobeta commented on a diff in pull request #890: Detect CI builds and enable errorprone by default for those CI builds

2022-05-15 Thread GitBox
mocobeta commented on code in PR #890: URL: https://github.com/apache/lucene/pull/890#discussion_r873140596 ## lucene/CHANGES.txt: ## @@ -211,7 +211,9 @@ Build * Upgrade forbiddenapis to version 3.3. (Uwe Schindler) -* LUCENE-10532: Remove LuceneTestCase.Slow annotation. A

[GitHub] [lucene] mocobeta commented on a diff in pull request #890: Detect CI builds and enable errorprone by default for those CI builds

2022-05-15 Thread GitBox
mocobeta commented on code in PR #890: URL: https://github.com/apache/lucene/pull/890#discussion_r873140812 ## lucene/CHANGES.txt: ## @@ -211,7 +211,9 @@ Build * Upgrade forbiddenapis to version 3.3. (Uwe Schindler) -* LUCENE-10532: Remove LuceneTestCase.Slow annotation. A

[GitHub] [lucene] mocobeta commented on a diff in pull request #884: LUCENE-10568: fix javadocs errors in IndexWriter.DocStats

2022-05-15 Thread GitBox
mocobeta commented on code in PR #884: URL: https://github.com/apache/lucene/pull/884#discussion_r873143938 ## lucene/core/src/java/org/apache/lucene/index/IndexWriter.java: ## @@ -6198,14 +6198,15 @@ public synchronized DocStats getDocStats() { /** DocStats for this index */

[GitHub] [lucene] mocobeta commented on a diff in pull request #884: LUCENE-10568: fix javadocs errors in IndexWriter.DocStats

2022-05-15 Thread GitBox
mocobeta commented on code in PR #884: URL: https://github.com/apache/lucene/pull/884#discussion_r873144139 ## lucene/core/src/java/org/apache/lucene/index/IndexWriter.java: ## @@ -6199,13 +6199,14 @@ public synchronized DocStats getDocStats() { public static final class DocS

[GitHub] [lucene] mocobeta commented on a diff in pull request #884: LUCENE-10568: fix javadocs errors in IndexWriter.DocStats

2022-05-15 Thread GitBox
mocobeta commented on code in PR #884: URL: https://github.com/apache/lucene/pull/884#discussion_r873143938 ## lucene/core/src/java/org/apache/lucene/index/IndexWriter.java: ## @@ -6198,14 +6198,15 @@ public synchronized DocStats getDocStats() { /** DocStats for this index */

[GitHub] [lucene] wormday commented on a diff in pull request #884: LUCENE-10568: fix javadocs errors in IndexWriter.DocStats

2022-05-15 Thread GitBox
wormday commented on code in PR #884: URL: https://github.com/apache/lucene/pull/884#discussion_r873248454 ## lucene/core/src/java/org/apache/lucene/index/IndexWriter.java: ## @@ -6198,14 +6198,15 @@ public synchronized DocStats getDocStats() { /** DocStats for this index */

[GitHub] [lucene] mocobeta commented on pull request #884: LUCENE-10568: fix javadocs errors in IndexWriter.DocStats

2022-05-15 Thread GitBox
mocobeta commented on PR #884: URL: https://github.com/apache/lucene/pull/884#issuecomment-1127136929 @wormday looks like the gradle check fails due to the invalid Javadocs formatting. Can you apply `gradlew tidy`? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene] zacharymorn opened a new pull request, #891: LUCENE-10411: (Backport) Add NN vectors support to ExitableDirectoryReader

2022-05-15 Thread GitBox
zacharymorn opened a new pull request, #891: URL: https://github.com/apache/lucene/pull/891 Backporting https://github.com/apache/lucene/pull/833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] zacharymorn merged pull request #891: LUCENE-10411: (Backport) Add NN vectors support to ExitableDirectoryReader

2022-05-15 Thread GitBox
zacharymorn merged PR #891: URL: https://github.com/apache/lucene/pull/891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[jira] [Commented] (LUCENE-10411) Add NN vectors support to ExitableDirectoryReader

2022-05-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537300#comment-17537300 ] ASF subversion and git services commented on LUCENE-10411: -- Co

[GitHub] [lucene] zacharymorn commented on pull request #833: LUCENE-10411: Add NN vectors support to ExitableDirectoryReader

2022-05-15 Thread GitBox
zacharymorn commented on PR #833: URL: https://github.com/apache/lucene/pull/833#issuecomment-1127149687 > @zacharymorn do you plan to backport this to `branch_9x`? It'd be nice to do that soon as the 9.2 release is coming up (and we will be cutting a new branch any day now). Hi @jti

[GitHub] [lucene] wormday commented on pull request #884: LUCENE-10568: fix javadocs errors in IndexWriter.DocStats

2022-05-15 Thread GitBox
wormday commented on PR #884: URL: https://github.com/apache/lucene/pull/884#issuecomment-1127161146 @mocobeta I'll pay attention next time, sorry to inconvenience you. I submitted the code again -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [lucene] mocobeta commented on pull request #884: LUCENE-10568: fix javadocs errors in IndexWriter.DocStats

2022-05-15 Thread GitBox
mocobeta commented on PR #884: URL: https://github.com/apache/lucene/pull/884#issuecomment-1127210543 No problem, CI workflows report problems on behalf of humans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [lucene] mocobeta merged pull request #884: LUCENE-10568: fix javadocs errors in IndexWriter.DocStats

2022-05-15 Thread GitBox
mocobeta merged PR #884: URL: https://github.com/apache/lucene/pull/884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache

[jira] [Commented] (LUCENE-10568) Javadocs errors in IndexWriter.DocStats

2022-05-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537332#comment-17537332 ] ASF subversion and git services commented on LUCENE-10568: -- Co

[jira] [Commented] (LUCENE-10568) Javadocs errors in IndexWriter.DocStats

2022-05-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537333#comment-17537333 ] ASF subversion and git services commented on LUCENE-10568: -- Co

[jira] [Resolved] (LUCENE-10568) Javadocs errors in IndexWriter.DocStats

2022-05-15 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-10568. Fix Version/s: 10.0 (main) 9.2 Resolution: Fixed > Javadocs err

[GitHub] [lucene] shaie commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-05-15 Thread GitBox
shaie commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r873326117 ## lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/DoubleHyperRectangle.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (LUCENE-10572) Can we optimize BytesRefHash?

2022-05-15 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537353#comment-17537353 ] Dawid Weiss commented on LUCENE-10572: -- As much as I love BE (long live M68k), I t

[jira] [Commented] (LUCENE-10572) Can we optimize BytesRefHash?

2022-05-15 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537354#comment-17537354 ] Dawid Weiss commented on LUCENE-10572: -- This is the issue I filed it under, actual