[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535952#comment-17535952
]
Tomoko Uchida commented on LUCENE-10557:
[~nightowl888] thanks for giving valua
jpountz merged PR #838:
URL: https://github.com/apache/lucene/pull/838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
jpountz commented on PR #838:
URL: https://github.com/apache/lucene/pull/838#issuecomment-1124690454
I used the new OrdinalMapBenchmark in luceneutil to check if this change
would make things any slower, and as far as I can tell there wasn't any
difference.
--
This is an automated messag
[
https://issues.apache.org/jira/browse/LUCENE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535967#comment-17535967
]
ASF subversion and git services commented on LUCENE-10536:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535971#comment-17535971
]
ASF subversion and git services commented on LUCENE-10536:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10536.
---
Fix Version/s: 9.2
Resolution: Fixed
> Doc values terms dicts should use the first t
jpountz commented on PR #859:
URL: https://github.com/apache/lucene/pull/859#issuecomment-1124695511
@msokolov Should this be backported to branch_9x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10417.
---
Fix Version/s: 9.2
Resolution: Fixed
This got addressed via LUCENE-10315.
> IntNRQ
[
https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10315.
---
Fix Version/s: 9.2
Resolution: Fixed
> Speed up BKD leaf block ids codec by a 512 in
wormday closed pull request #879: fix errors in DocStats comments
URL: https://github.com/apache/lucene/pull/879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
janhoy opened a new pull request, #2653:
URL: https://github.com/apache/lucene-solr/pull/2653
I have backported five bugfixes from main to branch_8_11
There were some merge conflict resolution, I mostly used IntelliJ
auto-resolve and some manual fixing. Ran the new tests. Currently ru
janhoy commented on PR #2653:
URL: https://github.com/apache/lucene-solr/pull/2653#issuecomment-1124886394
Btw, will NOT squash-merge this one, but do a manual git merge to preserve
commit history.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
mocobeta commented on PR #879:
URL: https://github.com/apache/lucene/pull/879#issuecomment-1124887768
Hi @wormday - sorry for the late reply. Do you have the idea of the
reviewer? Committers are usually too busy to watch all pull requests and often
overlook good PRs.
--
This is an automa
sun wuqiang created LUCENE-10568:
Summary: Javadocs errors in IndexWriter.DocStats
Key: LUCENE-10568
URL: https://issues.apache.org/jira/browse/LUCENE-10568
Project: Lucene - Core
Issue Type:
mayya-sharipova commented on PR #881:
URL: https://github.com/apache/lucene/pull/881#issuecomment-1124910640
@LuXugang Thanks for your work, please feel free to open PR against
`branch_9x` cherry-picking this commit and also
6040d1648f6e30107086c1f9a159c1979498fb4e
--
This is an automate
wormday opened a new pull request, #884:
URL: https://github.com/apache/lucene/pull/884
# Description
org.apache.lucene.index.IndexWriter.DocStats
This class has two fields.
The field maxDoc should contain numDeletedDocs, and numDocs does not contain
numDeletedDocs
However, the j
mocobeta commented on PR #884:
URL: https://github.com/apache/lucene/pull/884#issuecomment-1124938507
Thanks for opening Jira. I'll take a look tomorrow if other people do not
respond here before that.
--
This is an automated message from the Apache Git Service.
To respond to the message,
LuXugang opened a new pull request, #885:
URL: https://github.com/apache/lucene/pull/885
Backports
https://github.com/apache/lucene/commit/6040d1648f6e30107086c1f9a159c1979498fb4e
and https://github.com/apache/lucene/pull/881 .
--
This is an automated message from the Apache Git Service.
LuXugang commented on PR #881:
URL: https://github.com/apache/lucene/pull/881#issuecomment-1124945233
> @LuXugang Thanks for your work, please feel free to open PR against
`branch_9x` cherry-picking this commit and also
[6040d16](https://github.com/apache/lucene/commit/6040d1648f6e30107086c
mayya-sharipova merged PR #885:
URL: https://github.com/apache/lucene/pull/885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
[
https://issues.apache.org/jira/browse/LUCENE-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayya Sharipova resolved LUCENE-10502.
--
Fix Version/s: 9.2
Resolution: Fixed
> Use IndexedDISI to store docIds and Dir
[
https://issues.apache.org/jira/browse/LUCENE-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayya Sharipova closed LUCENE-10502.
> Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle
> ordToDoc
> -
[
https://issues.apache.org/jira/browse/LUCENE-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536119#comment-17536119
]
ASF subversion and git services commented on LUCENE-10502:
--
Co
mayya-sharipova commented on PR #885:
URL: https://github.com/apache/lucene/pull/885#issuecomment-1125018199
@LuXugang Thanks for your great work! I've marked the corresponding Lucene
issue resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
mayya-sharipova commented on PR #872:
URL: https://github.com/apache/lucene/pull/872#issuecomment-1125028616
@jtibshirani @mocobeta Thanks for your review. I've changed the current PR
based on the recent vector format changes from `main` branch – mostly copy,
just in `OnHeapHnswGraph`, I'v
jpountz opened a new pull request, #886:
URL: https://github.com/apache/lucene/pull/886
This changes OrdinalMap construction to work on windows of 4096 terms at a
time
and identify shared prefixes within the window, so that the PriorityQueue can
ignore these shared prefixes when compar
jpountz commented on PR #886:
URL: https://github.com/apache/lucene/pull/886#issuecomment-1125050627
I tried to run this against a dataset of random byte[16] that all share the
same 12-bytes prefix, to simulate the case of IPv6-mapped IPv4 addresses, but
unfortunately, this did not speed up
janhoy merged PR #2653:
URL: https://github.com/apache/lucene-solr/pull/2653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
jpountz commented on PR #886:
URL: https://github.com/apache/lucene/pull/886#issuecomment-1125073172
If I hack this further to add the same optimization as #875 on top of the
shared-prefix idea, I get a ~25% speedup for the case described above, while
neither this nor #875 make this case fa
rmuir commented on code in PR #886:
URL: https://github.com/apache/lucene/pull/886#discussion_r871487727
##
lucene/core/src/java/org/apache/lucene/index/TermsEnum.java:
##
@@ -105,6 +105,9 @@ public enum SeekStatus {
*/
public abstract long ord() throws IOException;
+
mikemccand commented on code in PR #884:
URL: https://github.com/apache/lucene/pull/884#discussion_r871492434
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -6199,13 +6199,14 @@ public synchronized DocStats getDocStats() {
public static final class Do
[
https://issues.apache.org/jira/browse/LUCENE-10568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536173#comment-17536173
]
Michael McCandless commented on LUCENE-10568:
-
Thanks [~wormday] – the word
jpountz commented on code in PR #886:
URL: https://github.com/apache/lucene/pull/886#discussion_r871499487
##
lucene/core/src/java/org/apache/lucene/index/TermsEnum.java:
##
@@ -105,6 +105,9 @@ public enum SeekStatus {
*/
public abstract long ord() throws IOException;
+
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536176#comment-17536176
]
Michael McCandless commented on LUCENE-10557:
-
Oh that's great news; thanks
msokolov commented on PR #859:
URL: https://github.com/apache/lucene/pull/859#issuecomment-1125113064
I think it's really not significant since this query will never be cached?
@jtibshirani pointed out that the filter gets applied during `rewrite()`
--
This is an automated message from t
gsmiller commented on code in PR #779:
URL: https://github.com/apache/lucene/pull/779#discussion_r871508282
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java:
##
@@ -222,41 +262,162 @@ public FacetResult getTopChildren(int topN, String dim,
String
gsmiller commented on PR #777:
URL: https://github.com/apache/lucene/pull/777#issuecomment-1125119517
@Yuti-G just FYI, I'm planning to merge this at the same time as #779 and
#806 since they're all related and tracked in LUCENE-10488. Just letting you
know in case you're wondering why it's
jpountz commented on PR #859:
URL: https://github.com/apache/lucene/pull/859#issuecomment-1125144256
FWIW I found about this PR because it is in the 9.2 changelog on `main` but
not on `branch_9x`. We could fix the changelog, but it looks like it's as easy
to backport the change to `branch_9
mikemccand commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1125152117
> The favicon looks good to me as is, thanks and sorry for the noise!
No need to apologize! This noise (beautiful art works) are the best part of
this PR, to me! I wish all of our
[
https://issues.apache.org/jira/browse/LUCENE-10556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536201#comment-17536201
]
Adrien Grand commented on LUCENE-10556:
---
I played with tuning the threshold on lu
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1125179505
FYI, it's oss with decent licenses so I created a repository for the new
mascots.
https://github.com/mocobeta/unofficial-lucene-mascot
--
This is an automated message from the Apache G
[
https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536218#comment-17536218
]
Mike Drob commented on LUCENE-10481:
[~jpountz] - what would you think about a back
[
https://issues.apache.org/jira/browse/LUCENE-10556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536219#comment-17536219
]
Robert Muir commented on LUCENE-10556:
--
maybe we could try playing instead with th
[
https://issues.apache.org/jira/browse/LUCENE-10556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536227#comment-17536227
]
Adrien Grand commented on LUCENE-10556:
---
I dug a bit further into the benchmark t
[
https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536228#comment-17536228
]
Adrien Grand commented on LUCENE-10481:
---
[~mdrob] It sounds reasonable to me, the
shahrs87 commented on PR #883:
URL: https://github.com/apache/lucene/pull/883#issuecomment-1125209240
Hi @mocobeta
I have updated the PR as per your's and @rmuir's feedback. I have reduced
class visibility of most of normalizer and stemmer related classes. Couldn't
change for `StempelSt
jtibshirani commented on code in PR #882:
URL: https://github.com/apache/lucene/pull/882#discussion_r871615361
##
lucene/core/src/test/org/apache/lucene/util/TestSparseFixedBitSet.java:
##
@@ -71,4 +71,27 @@ public void testApproximateCardinalityOnDenseSet() {
}
assert
[
https://issues.apache.org/jira/browse/LUCENE-10556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536233#comment-17536233
]
Robert Muir commented on LUCENE-10556:
--
Yes, the original code i wrote for this th
madrob opened a new pull request, #2654:
URL: https://github.com/apache/lucene-solr/pull/2654
Backport to 8.11.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
jtibshirani commented on PR #833:
URL: https://github.com/apache/lucene/pull/833#issuecomment-1125295130
@zacharymorn do you plan to backport this to `branch_9x`? It'd be nice to do
that soon as the 9.2 release is coming up (and we will be cutting a new branch
any day now).
--
This is an
[
https://issues.apache.org/jira/browse/LUCENE-10556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536285#comment-17536285
]
Michael McCandless commented on LUCENE-10556:
-
{quote}I'm not sure if we sh
jtibshirani commented on code in PR #882:
URL: https://github.com/apache/lucene/pull/882#discussion_r871722263
##
lucene/core/src/test/org/apache/lucene/util/TestSparseFixedBitSet.java:
##
@@ -71,4 +71,27 @@ public void testApproximateCardinalityOnDenseSet() {
}
assert
mayya-sharipova merged PR #872:
URL: https://github.com/apache/lucene/pull/872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
[
https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536299#comment-17536299
]
ASF subversion and git services commented on LUCENE-10527:
--
Co
mayya-sharipova opened a new pull request, #887:
URL: https://github.com/apache/lucene/pull/887
The original HNSW paper (https://arxiv.org/pdf/1603.09320.pdf) suggests
to use a different maxConn for the upper layers vs. the bottom one
(which contains the full neighborhood graph). Specif
mayya-sharipova merged PR #887:
URL: https://github.com/apache/lucene/pull/887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
[
https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536315#comment-17536315
]
ASF subversion and git services commented on LUCENE-10527:
--
Co
jtibshirani merged PR #882:
URL: https://github.com/apache/lucene/pull/882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
[
https://issues.apache.org/jira/browse/LUCENE-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536324#comment-17536324
]
ASF subversion and git services commented on LUCENE-10564:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536333#comment-17536333
]
ASF subversion and git services commented on LUCENE-10564:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-10564:
--
Fix Version/s: 9.2
> SparseFixedBitSet#or doesn't update memory accounting
>
[
https://issues.apache.org/jira/browse/LUCENE-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536338#comment-17536338
]
ASF subversion and git services commented on LUCENE-10564:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani resolved LUCENE-10564.
---
Resolution: Fixed
> SparseFixedBitSet#or doesn't update memory accounting
> ---
jtibshirani commented on PR #859:
URL: https://github.com/apache/lucene/pull/859#issuecomment-1125422896
I just backported this to `branch_9x` to match the changelog/ fix version in
JIRA. It went smoothly and seems low risk.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/LUCENE-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536343#comment-17536343
]
ASF subversion and git services commented on LUCENE-10552:
--
Co
Adrien Grand created LUCENE-10569:
-
Summary: Think again about the floor segment size?
Key: LUCENE-10569
URL: https://issues.apache.org/jira/browse/LUCENE-10569
Project: Lucene - Core
Issue T
[
https://issues.apache.org/jira/browse/LUCENE-10565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536357#comment-17536357
]
Greg Miller commented on LUCENE-10565:
--
A tricky aspect of this is identifying whi
[
https://issues.apache.org/jira/browse/LUCENE-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536370#comment-17536370
]
Rushabh Shah commented on LUCENE-10550:
---
Hi [~yutinggan]
Can I work on this if
[
https://issues.apache.org/jira/browse/LUCENE-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536386#comment-17536386
]
ASF subversion and git services commented on LUCENE-10564:
--
Co
wormday commented on code in PR #884:
URL: https://github.com/apache/lucene/pull/884#discussion_r871932093
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -6199,13 +6199,14 @@ public synchronized DocStats getDocStats() {
public static final class DocSt
[
https://issues.apache.org/jira/browse/LUCENE-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536400#comment-17536400
]
ASF subversion and git services commented on LUCENE-10564:
--
Co
mocobeta commented on PR #883:
URL: https://github.com/apache/lucene/pull/883#issuecomment-1125578473
> Couldn't change for StempelStemmer since PolishAnalyzer depends on some
member variable of StempelStemmer
`StempelStemmer` is supposed to be used from other packages/modules
(accor
[
https://issues.apache.org/jira/browse/LUCENE-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536407#comment-17536407
]
Yuting Gan commented on LUCENE-10550:
-
Hi [~shahrs87], thank you so much for being
wormday commented on code in PR #884:
URL: https://github.com/apache/lucene/pull/884#discussion_r871939563
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -6199,13 +6199,14 @@ public synchronized DocStats getDocStats() {
public static final class DocSt
mocobeta commented on PR #883:
URL: https://github.com/apache/lucene/pull/883#issuecomment-1125583595
I feel it's a bit confusing that package-private classes have `public`
members. Should we also change all public variables/methods to package-private
(in other words, remove the `public` ac
wormday commented on PR #879:
URL: https://github.com/apache/lucene/pull/879#issuecomment-1125588968
> Hi @wormday - sorry for the late reply. Do you have the idea of the
reviewer? Committers are usually too busy to watch all pull requests and often
overlook good PRs.
What work d
mocobeta commented on PR #879:
URL: https://github.com/apache/lucene/pull/879#issuecomment-1125595908
Anyone can be a reviewer for this project. Browse the opened/active pull
requests (there are always tons of PRs), choose one you are interested in and
able to review, and make comments on i
wormday commented on PR #879:
URL: https://github.com/apache/lucene/pull/879#issuecomment-1125607070
> Anyone can be a reviewer for this project. Browse the opened/active pull
requests (there are always tons of PRs), choose one you are interested in and
able to review, and make comments on
Yuti-G commented on PR #779:
URL: https://github.com/apache/lucene/pull/779#issuecomment-1125607347
Thanks! I changed the parameter name to `pathLength` and added more
documentation to avoid confusion. Thanks for your feedback again and please let
me know if there is any question!
--
Thi
shahrs87 commented on PR #883:
URL: https://github.com/apache/lucene/pull/883#issuecomment-1125674862
@mocobeta Thank you for your review. Addressed your review comment in latest
revision. Please review again.
--
This is an automated message from the Apache Git Service.
To respond to the
shahrs87 commented on PR #883:
URL: https://github.com/apache/lucene/pull/883#issuecomment-1125684436
@mocobeta Can you please suggest some starter jiras which will give me
overview on Lucene and will be helpful to community also. Thank you.
--
This is an automated message from the Apache
81 matches
Mail list logo
