[GitHub] [lucene] uschindler commented on pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler commented on PR #868: URL: https://github.com/apache/lucene/pull/868#issuecomment-1118870659 I pushed a fix forthe deprecated one (+ test). I will fix Nori when back at home. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [lucene] sonatype-lift[bot] commented on a diff in pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

sonatype-lift[bot] commented on code in PR #868: URL: https://github.com/apache/lucene/pull/868#discussion_r866182772 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoDictionary.java: ## @@ -82,6 +76,25 @@ public TokenInfoDictionary(Path targetMap

[GitHub] [lucene] sonatype-lift[bot] commented on a diff in pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

sonatype-lift[bot] commented on code in PR #868: URL: https://github.com/apache/lucene/pull/868#discussion_r866182540 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/UnknownDictionary.java: ## @@ -64,6 +59,20 @@ public UnknownDictionary(Path targetMapFile

[GitHub] [lucene] sonatype-lift[bot] commented on a diff in pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

sonatype-lift[bot] commented on code in PR #868: URL: https://github.com/apache/lucene/pull/868#discussion_r866182923 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoDictionary.java: ## @@ -82,6 +76,25 @@ public TokenInfoDictionary(Path targetMap

[GitHub] [lucene] raminmjj commented on pull request #540: LUCENE-10312: Add PersianStemmer

raminmjj commented on PR #540: URL: https://github.com/apache/lucene/pull/540#issuecomment-1118935565 Hi Tomoko(@mocobeta). I added "PersiaStem" in org.apache.lucene.analysis.TokenFilterFactory file. What should I do to pass this error? Thank you. -- This is an automated message

[GitHub] [lucene] taroplus commented on pull request #861: LUCENE-10551: switch to PUAFIF

taroplus commented on PR #861: URL: https://github.com/apache/lucene/pull/861#issuecomment-1118935923 I actually see this exception, trying to figure out the situation ``` java.lang.IllegalStateException: 7 <> 9 execservicetest.oc1.iad.amaait4ivdqawqdvv26mn2naeqgm22k5hnei3von6shgqu

[GitHub] [lucene] uschindler commented on pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler commented on PR #868: URL: https://github.com/apache/lucene/pull/868#issuecomment-1118958254 I know how to disable lift it by telling him to scan no files at all: we can place a gitignore like file -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [lucene] uschindler commented on pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler commented on PR #868: URL: https://github.com/apache/lucene/pull/868#issuecomment-1119040833 Liftbot was disabled by INFRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [lucene] uschindler commented on pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler commented on PR #868: URL: https://github.com/apache/lucene/pull/868#issuecomment-1119059880 Hi @msokolov: I restored the original behaviour of the deprecated ctor. Could you try with your original code of 9.0 using the deprecated APIs that the custom dictionaries are loaded from

[GitHub] [lucene] uschindler commented on a diff in pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

uschindler commented on code in PR #868: URL: https://github.com/apache/lucene/pull/868#discussion_r866333077 ## lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/BinaryDictionary.java: ## @@ -140,19 +140,15 @@ public static final InputStream getResource(Reso

[GitHub] [lucene] mocobeta commented on pull request #868: LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries

mocobeta commented on PR #868: URL: https://github.com/apache/lucene/pull/868#issuecomment-1119154290 > Liftbot was disabled by INFRA. Many thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene] mocobeta commented on pull request #540: LUCENE-10312: Add PersianStemmer

mocobeta commented on PR #540: URL: https://github.com/apache/lucene/pull/540#issuecomment-1119184125 > I added "PersianStem" in org.apache.lucene.analysis.TokenFilterFactory file. Yes it's correct, now this has passed the tests/checks. -- This is an automated message from the Apac

[jira] [Commented] (LUCENE-10550) Add getAllChildren functionality to facets

[ https://issues.apache.org/jira/browse/LUCENE-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532586#comment-17532586 ] Yuting Gan commented on LUCENE-10550: - Thanks [~mikemccand] and [~gsmiller] for sup

[GitHub] [lucene] LuXugang opened a new pull request, #870: LUCENE-10502: Refactor hnswVectors format

LuXugang opened a new pull request, #870: URL: https://github.com/apache/lucene/pull/870 follow-up of https://github.com/apache/lucene/pull/792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene] wjp719 commented on pull request #864: LUCENE-10555: avoid repeated NumericLeafComparator#setScorer calls

wjp719 commented on PR #864: URL: https://github.com/apache/lucene/pull/864#issuecomment-1119295501 @jpountz Hi, can you help to review this pr? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene] wjp719 commented on pull request #863: LUCENE-10554: fix bkd test case logic error and java doc error

wjp719 commented on PR #863: URL: https://github.com/apache/lucene/pull/863#issuecomment-1119295798 @jpountz Hi, can you help to review this pr? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene] vigyasharma commented on a diff in pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

vigyasharma commented on code in PR #633: URL: https://github.com/apache/lucene/pull/633#discussion_r866530117 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java: ## @@ -86,6 +86,20 @@ public MergeSpecification findMerges( return merg

<    1   2