[GitHub] [lucene] jpountz commented on a change in pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

2022-04-01 Thread GitBox
jpountz commented on a change in pull request #767: URL: https://github.com/apache/lucene/pull/767#discussion_r840305767 ## File path: lucene/core/src/java/org/apache/lucene/search/DocValuesFieldExistsQuery.java ## @@ -31,42 +28,21 @@ /** * A {@link Query} that matches docu

[GitHub] [lucene] javanna commented on pull request #765: LUCENE-10484: Add support for concurrent facets random sampling

2022-04-01 Thread GitBox
javanna commented on pull request #765: URL: https://github.com/apache/lucene/pull/765#issuecomment-1085528669 @mikemccand would you happen to have time to merge this for me? ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene] jpountz commented on a change in pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

2022-04-01 Thread GitBox
jpountz commented on a change in pull request #767: URL: https://github.com/apache/lucene/pull/767#discussion_r840308477 ## File path: lucene/core/src/java/org/apache/lucene/search/FieldExistsQuery.java ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Foundation (AS

[jira] [Commented] (LUCENE-10485) Limit o.a.l.a.morph package visibility only to kuromoji and nori

2022-04-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515848#comment-17515848 ] Tomoko Uchida commented on LUCENE-10485: Apart from toolings, I noticed `Attrib

[GitHub] [lucene] iverase commented on pull request #756: LUCENE-10470: [Tessellator] Prevent bridges that introduce collinear edges

2022-04-01 Thread GitBox
iverase commented on pull request #756: URL: https://github.com/apache/lucene/pull/756#issuecomment-1085761493 @yixunx thanks for the input. I revised the issue again and it seems the fix is much simpler. We are actually tessellating properly the polygons but we are not detecting it

[GitHub] [lucene] reta commented on a change in pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

2022-04-01 Thread GitBox
reta commented on a change in pull request #749: URL: https://github.com/apache/lucene/pull/749#discussion_r840528970 ## File path: lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestIndexSortSortedNumericDocValuesRangeQuery.java ## @@ -155,15 +156,23 @@ public void

[GitHub] [lucene] jpountz merged pull request #776: LUCENE-10492 Remove redundant taxonomy.8.10.0-cfs.zip backward compatibility index

2022-04-01 Thread GitBox
jpountz merged pull request #776: URL: https://github.com/apache/lucene/pull/776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Resolved] (LUCENE-10492) Remove redundant taxonomy.8.10.0-cfs.zip backward compatibility index

2022-04-01 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10492. --- Fix Version/s: 10.0 (main) Resolution: Fixed > Remove redundant taxonomy.8.10.0-cfs.

[GitHub] [lucene] reta commented on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

2022-04-01 Thread GitBox
reta commented on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1085853778 @jtibshirani @nknize comments addressed, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [lucene] iverase edited a comment on pull request #756: LUCENE-10470: [Tessellator] Prevent bridges that introduce collinear edges

2022-04-01 Thread GitBox
iverase edited a comment on pull request #756: URL: https://github.com/apache/lucene/pull/756#issuecomment-1085761493 @yixunx thanks for the input. I revised the issue again and it seems the fix is much simpler. We are actually tessellating properly the polygons but we are not detect

[jira] [Commented] (LUCENE-10493) Can we unify the viterbi search logic in the tokenizers of kuromoji and nori?

2022-04-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515909#comment-17515909 ] Tomoko Uchida commented on LUCENE-10493: I looked through the `parse()` method

[jira] [Commented] (LUCENE-10315) Speed up BKD leaf block ids codec by a 512 ints ForUtil

2022-04-01 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516013#comment-17516013 ] Adrien Grand commented on LUCENE-10315: --- Oh, thanks for looking into this [~ivera

[jira] [Commented] (LUCENE-10085) Implement Weight#count on DocValuesFieldExistsQuery

2022-04-01 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516122#comment-17516122 ] Julie Tibshirani commented on LUCENE-10085: --- I noticed a (possibly rare) fail

[jira] [Commented] (LUCENE-10204) Support iteration of sub-matches in join queries (ToParentBlockJoinQuery / ToChildBlockJoinQuery)

2022-04-01 Thread Marc D'Mello (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516171#comment-17516171 ] Marc D'Mello commented on LUCENE-10204: --- I think what you say makes sense about h

[GitHub] [lucene] LuXugang commented on pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

2022-04-01 Thread GitBox
LuXugang commented on pull request #767: URL: https://github.com/apache/lucene/pull/767#issuecomment-1086537083 Since at search phase, vector's all docs of all fields have been loaded into memory, when `FieldExistsQuery` as a lead iterator, should we always try to supply a `Scorer` by vec

[jira] [Closed] (LUCENE-10490) Query implement Cloneable interface

2022-04-01 Thread jianping weng (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jianping weng closed LUCENE-10490. -- > Query implement Cloneable interface > --- > > K

[jira] [Resolved] (LUCENE-10490) Query implement Cloneable interface

2022-04-01 Thread jianping weng (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jianping weng resolved LUCENE-10490. Resolution: Abandoned > Query implement Cloneable interface > ---