[jira] [Commented] (LUCENE-10393) Should we unify the dictionary builder/loader of kuromoji and nori?

2022-03-10 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504211#comment-17504211 ] Tomoko Uchida commented on LUCENE-10393: Both Kuromoji and Nori have `BinaryDic

[GitHub] [lucene] rmuir commented on pull request #740: LUCENE-10393: Unify binary dictionary and dictionary writer in kuromoji and nori

2022-03-10 Thread GitBox
rmuir commented on pull request #740: URL: https://github.com/apache/lucene/pull/740#issuecomment-1064044898 I only looked at the high-level design so far, this seems to be a good approach @mocobeta ! Thank you for tackling it. I think the bottom-up approach is a good one, and splitting ou

[GitHub] [lucene] kkewwei opened a new pull request #741: LUCENE-9998: avoid the instant writing rate bigger than the limited rate in merge process

2022-03-10 Thread GitBox
kkewwei opened a new pull request #741: URL: https://github.com/apache/lucene/pull/741 # Description In the merge write process, if there is a long interval between two chunk writes, then the second chunk write will be not paused, as the result, the instant writing rate of the secon

[GitHub] [lucene] rmuir commented on pull request #740: LUCENE-10393: Unify binary dictionary and dictionary writer in kuromoji and nori

2022-03-10 Thread GitBox
rmuir commented on pull request #740: URL: https://github.com/apache/lucene/pull/740#issuecomment-1064048298 I ran `./gradlew regenerate --rerun-tasks` on your branch as an additional test and all binary data files were unchanged. So I feel good about correctness! -- This is an automated

[jira] [Commented] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-10 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504268#comment-17504268 ] kkewwei commented on LUCENE-10448: -- With many the statistics, all the detailBytes(mb)

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-10 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504268#comment-17504268 ] kkewwei edited comment on LUCENE-10448 at 3/10/22, 1:39 PM:

[GitHub] [lucene] msokolov commented on a change in pull request #738: LUCENE-10448: Avoid instant rate write bursts by writing bytes buffer in chunks

2022-03-10 Thread GitBox
msokolov commented on a change in pull request #738: URL: https://github.com/apache/lucene/pull/738#discussion_r823760258 ## File path: lucene/core/src/java/org/apache/lucene/store/RateLimitedIndexOutput.java ## @@ -68,9 +68,14 @@ public void writeByte(byte b) throws IOExcepti

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-10 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504268#comment-17504268 ] kkewwei edited comment on LUCENE-10448 at 3/10/22, 2:24 PM:

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-10 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504268#comment-17504268 ] kkewwei edited comment on LUCENE-10448 at 3/10/22, 2:25 PM:

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-10 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504268#comment-17504268 ] kkewwei edited comment on LUCENE-10448 at 3/10/22, 2:28 PM:

[GitHub] [lucene] jtibshirani commented on a change in pull request #739: Adapt release smoke tester for 9.1

2022-03-10 Thread GitBox
jtibshirani commented on a change in pull request #739: URL: https://github.com/apache/lucene/pull/739#discussion_r824045245 ## File path: dev-tools/scripts/smokeTestRelease.py ## @@ -658,7 +659,7 @@ def testDemo(run_java, isSrc, version, jdk): searchFilesCmd = 'java -cp "

[jira] [Commented] (LUCENE-10459) Update smoke tester for 9.1

2022-03-10 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504547#comment-17504547 ] Julie Tibshirani commented on LUCENE-10459: --- I did some digging into previous

[jira] [Updated] (LUCENE-10459) Update smoke tester for 9.1

2022-03-10 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-10459: -- Affects Version/s: 9.1 > Update smoke tester for 9.1 > --- >

[jira] [Comment Edited] (LUCENE-10459) Update smoke tester for 9.1

2022-03-10 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504547#comment-17504547 ] Julie Tibshirani edited comment on LUCENE-10459 at 3/10/22, 8:03 PM:

[jira] [Commented] (LUCENE-10459) Update smoke tester for 9.1

2022-03-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504557#comment-17504557 ] Dawid Weiss commented on LUCENE-10459: -- Hi Julie. I'll try to help out tomorrow. T

[jira] [Commented] (LUCENE-10459) Update smoke tester for 9.1

2022-03-10 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504565#comment-17504565 ] Uwe Schindler commented on LUCENE-10459: There is a job on Jenkins, but it was

[GitHub] [lucene] vigyasharma commented on a change in pull request #741: LUCENE-9998: avoid the instant writing rate bigger than the limited rate in merge process

2022-03-10 Thread GitBox
vigyasharma commented on a change in pull request #741: URL: https://github.com/apache/lucene/pull/741#discussion_r824040011 ## File path: lucene/core/src/java/org/apache/lucene/index/MergeRateLimiter.java ## @@ -124,16 +125,21 @@ private long maybePause(long bytes, long curNS)

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-10 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504574#comment-17504574 ] Vigya Sharma edited comment on LUCENE-10448 at 3/10/22, 8:45 PM:

[jira] [Commented] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-10 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504574#comment-17504574 ] Vigya Sharma commented on LUCENE-10448: --- {quote}With many the statistics, all the

[GitHub] [lucene] vigyasharma commented on a change in pull request #738: LUCENE-10448: Avoid instant rate write bursts by writing bytes buffer in chunks

2022-03-10 Thread GitBox
vigyasharma commented on a change in pull request #738: URL: https://github.com/apache/lucene/pull/738#discussion_r824239962 ## File path: lucene/core/src/java/org/apache/lucene/store/RateLimitedIndexOutput.java ## @@ -68,9 +68,14 @@ public void writeByte(byte b) throws IOExce

[GitHub] [lucene] vigyasharma commented on a change in pull request #633: [WIP] LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-03-10 Thread GitBox
vigyasharma commented on a change in pull request #633: URL: https://github.com/apache/lucene/pull/633#discussion_r824243569 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3121,147 +3125,265 @@ private void validateMergeReader(CodecReader lea

[jira] [Created] (LUCENE-10460) Delegating DocIdSetIterator could be replaced to DocIdSetIterator#range(int minDoc, int maxDoc) in IndexSortSortedNumericDocValuesRangeQuery

2022-03-10 Thread Lu Xugang (Jira)
Lu Xugang created LUCENE-10460: -- Summary: Delegating DocIdSetIterator could be replaced to DocIdSetIterator#range(int minDoc, int maxDoc) in IndexSortSortedNumericDocValuesRangeQuery Key: LUCENE-10460 URL: https://i

[GitHub] [lucene] LuXugang opened a new pull request #742: LUCENE-10460: Delegating DocIdSetIterator could be replaced to DocIdSetIterator#range(int minDoc, int maxDoc) in IndexSortSortedNumericDocVal

2022-03-10 Thread GitBox
LuXugang opened a new pull request #742: URL: https://github.com/apache/lucene/pull/742 While taking advantage of of index sort In IndexSortSortedNumericDocValuesRangeQuery, if MissingValue disabled, all Documents between a range of firstDoc and lastDoc must contain docValues. So In Bound

[GitHub] [lucene] kkewwei commented on a change in pull request #741: LUCENE-10448: avoid the instant writing rate bigger than the limited rate in merge process

2022-03-10 Thread GitBox
kkewwei commented on a change in pull request #741: URL: https://github.com/apache/lucene/pull/741#discussion_r824358504 ## File path: lucene/core/src/java/org/apache/lucene/index/MergeRateLimiter.java ## @@ -124,16 +125,21 @@ private long maybePause(long bytes, long curNS) thr

[GitHub] [lucene] kkewwei commented on a change in pull request #741: LUCENE-10448: avoid the instant writing rate bigger than the limited rate in merge process

2022-03-10 Thread GitBox
kkewwei commented on a change in pull request #741: URL: https://github.com/apache/lucene/pull/741#discussion_r824361800 ## File path: lucene/core/src/java/org/apache/lucene/index/MergeRateLimiter.java ## @@ -124,16 +125,21 @@ private long maybePause(long bytes, long curNS) thr

[GitHub] [lucene] kkewwei commented on a change in pull request #741: LUCENE-10448: avoid the instant writing rate bigger than the limited rate in merge process

2022-03-10 Thread GitBox
kkewwei commented on a change in pull request #741: URL: https://github.com/apache/lucene/pull/741#discussion_r824389661 ## File path: lucene/core/src/java/org/apache/lucene/store/RateLimitedIndexOutput.java ## @@ -61,42 +64,57 @@ public long getChecksum() throws IOException {

[GitHub] [lucene] kkewwei commented on a change in pull request #741: LUCENE-10448: avoid the instant writing rate bigger than the limited rate in merge process

2022-03-10 Thread GitBox
kkewwei commented on a change in pull request #741: URL: https://github.com/apache/lucene/pull/741#discussion_r824361800 ## File path: lucene/core/src/java/org/apache/lucene/index/MergeRateLimiter.java ## @@ -124,16 +125,21 @@ private long maybePause(long bytes, long curNS) thr

[GitHub] [lucene] vigyasharma commented on a change in pull request #741: LUCENE-10448: avoid the instant writing rate bigger than the limited rate in merge process

2022-03-10 Thread GitBox
vigyasharma commented on a change in pull request #741: URL: https://github.com/apache/lucene/pull/741#discussion_r824421924 ## File path: lucene/core/src/java/org/apache/lucene/index/MergeRateLimiter.java ## @@ -124,16 +125,21 @@ private long maybePause(long bytes, long curNS)

[GitHub] [lucene] kkewwei commented on a change in pull request #741: LUCENE-10448: avoid the instant writing rate bigger than the limited rate in merge process

2022-03-10 Thread GitBox
kkewwei commented on a change in pull request #741: URL: https://github.com/apache/lucene/pull/741#discussion_r824389661 ## File path: lucene/core/src/java/org/apache/lucene/store/RateLimitedIndexOutput.java ## @@ -61,42 +64,57 @@ public long getChecksum() throws IOException {

[jira] [Commented] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-10 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504753#comment-17504753 ] kkewwei commented on LUCENE-10448: -- When we write into the new chunk, the time is time

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-10 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504753#comment-17504753 ] kkewwei edited comment on LUCENE-10448 at 3/11/22, 7:10 AM:

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-10 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504753#comment-17504753 ] kkewwei edited comment on LUCENE-10448 at 3/11/22, 7:10 AM:

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-10 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504753#comment-17504753 ] kkewwei edited comment on LUCENE-10448 at 3/11/22, 7:11 AM:

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-10 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504753#comment-17504753 ] kkewwei edited comment on LUCENE-10448 at 3/11/22, 7:13 AM:

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-10 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504753#comment-17504753 ] kkewwei edited comment on LUCENE-10448 at 3/11/22, 7:14 AM:

[jira] [Comment Edited] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-10 Thread kkewwei (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504753#comment-17504753 ] kkewwei edited comment on LUCENE-10448 at 3/11/22, 7:15 AM:

[jira] [Created] (LUCENE-10461) Luke: Windows launch script passes integration tests but fails to run

2022-03-10 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10461: Summary: Luke: Windows launch script passes integration tests but fails to run Key: LUCENE-10461 URL: https://issues.apache.org/jira/browse/LUCENE-10461 Project: Luce

[GitHub] [lucene] dweiss commented on pull request #743: LUCENE-10461: fix windows launch script for luke so that it works with ITs

2022-03-10 Thread GitBox
dweiss commented on pull request #743: URL: https://github.com/apache/lucene/pull/743#issuecomment-1064865748 @uschindler would you have a look as a fellow Windows user? cmd and start are crazy but I verified it works manually and from within the test, so we should be ok this time. -- T