[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502076#comment-17502076
]
kkewwei edited comment on LUCENE-10448 at 3/7/22, 9:25 AM:
---
[
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502076#comment-17502076
]
kkewwei edited comment on LUCENE-10448 at 3/7/22, 9:31 AM:
---
[
mayya-sharipova opened a new pull request #734:
URL: https://github.com/apache/lucene/pull/734
Use double instead of float to test vector values checksum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/LUCENE-10408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502211#comment-17502211
]
Mayya Sharipova commented on LUCENE-10408:
--
[~julietibs] I've changed a dataty
mayya-sharipova commented on pull request #734:
URL: https://github.com/apache/lucene/pull/734#issuecomment-1060581581
As @jtibshirani reported, currently without this patch this test fails:
```txt
./gradlew test --tests
TestPerFieldKnnVectorsFormat.testVectorValuesReportCorrect
[
https://issues.apache.org/jira/browse/LUCENE-10408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502211#comment-17502211
]
Mayya Sharipova edited comment on LUCENE-10408 at 3/7/22, 11:31 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502211#comment-17502211
]
Mayya Sharipova edited comment on LUCENE-10408 at 3/7/22, 11:31 AM:
-
msokolov commented on pull request #732:
URL: https://github.com/apache/lucene/pull/732#issuecomment-1060653437
Ah, I see - sorry if I jumped the gun and now your commit is recorded
against the wrong github id! Sadly there is no fixing github.
--
This is an automated message from the Apa
msokolov edited a comment on pull request #732:
URL: https://github.com/apache/lucene/pull/732#issuecomment-1060653437
Ah, I see - sorry if I jumped the gun and now your commit is recorded
against the wrong github id! Sadly there is no fixing git history.
--
This is an automated message
[
https://issues.apache.org/jira/browse/LUCENE-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502254#comment-17502254
]
Michael Sokolov commented on LUCENE-10425:
--
> Thinking through this a bit more
[
https://issues.apache.org/jira/browse/LUCENE-10427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502344#comment-17502344
]
Suhan Mao commented on LUCENE-10427:
[~jpountz] sorry to interrupt you, could you s
magibney commented on pull request #380:
URL: https://github.com/apache/lucene/pull/380#issuecomment-1060886236
Yes, essentially. Perhaps something like?:
```
* LUCENE-10171: OpenNLPOpsFactory.getLemmatizerDictionary(String,
ResourceLoader) now returns a
DictionaryLemmatizer obje
epugh commented on pull request #380:
URL: https://github.com/apache/lucene/pull/380#issuecomment-1060934405
CHANGES.txt does change a lot ;-).Nice patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
Yuti-G commented on pull request #732:
URL: https://github.com/apache/lucene/pull/732#issuecomment-1060939698
> Ah, I see - sorry if I jumped the gun and now your commit is recorded
against the wrong github id! Sadly there is no fixing git history.
No worries! I think it is against m
dblock opened a new pull request #735:
URL: https://github.com/apache/lucene/pull/735
# Description
A typo snuck into https://github.com/apache/lucene/pull/711.
# Solution
Fix typo, remove `+ +`.
# Checklist
Please review the following and check all that ap
jtibshirani commented on pull request #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1061011001
@rmuir's perspective makes total sense to me too, that we should stream to
the format instead of buffering on disk within `IndexingChain`.
One related thought: in a scen
[
https://issues.apache.org/jira/browse/LUCENE-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502516#comment-17502516
]
Holger Rehn commented on LUCENE-10430:
--
Thanks for the hint! I totally missed the
jtibshirani commented on pull request #734:
URL: https://github.com/apache/lucene/pull/734#issuecomment-1061145754
I just noticed: we need a similar fix for
`BaseKnnVectorsFormatTestCase#testSparseVectors`. I saw this test fail in CI
because of a slight checksum mismatch (unfortunately the
jtibshirani removed a comment on pull request #734:
URL: https://github.com/apache/lucene/pull/734#issuecomment-1061145754
I just noticed: we need a similar fix for
`BaseKnnVectorsFormatTestCase#testSparseVectors`. I saw this test fail in CI
because of a slight checksum mismatch (unfortuna
Mike Drob created LUCENE-10457:
--
Summary: LuceneTestCase.createTempDir could randomly return
symbolic links
Key: LUCENE-10457
URL: https://issues.apache.org/jira/browse/LUCENE-10457
Project: Lucene - Cor
[
https://issues.apache.org/jira/browse/LUCENE-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502623#comment-17502623
]
Robert Muir commented on LUCENE-10457:
--
I don't think createTempDir should do this
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502076#comment-17502076
]
kkewwei edited comment on LUCENE-10448 at 3/8/22, 12:42 AM:
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502076#comment-17502076
]
kkewwei edited comment on LUCENE-10448 at 3/8/22, 12:43 AM:
[
https://issues.apache.org/jira/browse/LUCENE-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502663#comment-17502663
]
Mike Drob commented on LUCENE-10457:
> we should suffer the complexity of fixing al
Lu Xugang created LUCENE-10458:
--
Summary: BoundedDocSetIdIterator may supply error count in
Weigth#count(LeafReaderContext) when missingValue enables
Key: LUCENE-10458
URL: https://issues.apache.org/jira/browse/LUCEN
[
https://issues.apache.org/jira/browse/LUCENE-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502773#comment-17502773
]
Lu Xugang commented on LUCENE-10458:
That is why in BoundedDocSetIdIterator#advance
[
https://issues.apache.org/jira/browse/LUCENE-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502773#comment-17502773
]
Lu Xugang edited comment on LUCENE-10458 at 3/8/22, 7:32 AM:
LuXugang opened a new pull request #736:
URL: https://github.com/apache/lucene/pull/736
When IndexSortSortedNumericDocValuesRangeQuery can take advantage of index
sort, Weight#count will use BoundedDocSetIdIterator's lastDoc and firstDoc to
calculate count, but if missingValue enables, tho
28 matches
Mail list logo
