jpountz opened a new pull request #724:
URL: https://github.com/apache/lucene/pull/724
As @rmuir noted, it would be as simple and create less cognitive overhead to
use `Long#bitCount` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Adrien Grand created LUCENE-10453:
-
Summary: Speed up VectorUtil#squareDistance
Key: LUCENE-10453
URL: https://issues.apache.org/jira/browse/LUCENE-10453
Project: Lucene - Core
Issue Type: Ta
jpountz merged pull request #711:
URL: https://github.com/apache/lucene/pull/711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
jpountz commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057807344
Thanks all for the feedback and contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
[
https://issues.apache.org/jira/browse/LUCENE-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500591#comment-17500591
]
ASF subversion and git services commented on LUCENE-10428:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500594#comment-17500594
]
ASF subversion and git services commented on LUCENE-10428:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500595#comment-17500595
]
Adrien Grand commented on LUCENE-10428:
---
[~akjain] While the underlying issue has
[
https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500606#comment-17500606
]
ASF subversion and git services commented on LUCENE-10002:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500605#comment-17500605
]
ASF subversion and git services commented on LUCENE-10002:
--
Co
romseygeek commented on a change in pull request #722:
URL: https://github.com/apache/lucene/pull/722#discussion_r818496740
##
File path: lucene/core/src/java/org/apache/lucene/search/FuzzyQuery.java
##
@@ -113,11 +138,40 @@ public FuzzyQuery(Term term, int maxEdits) {
thi
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500655#comment-17500655
]
kkewwei commented on LUCENE-10448:
--
[~vigyas] you mill nothing, there maybe exists a s
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500655#comment-17500655
]
kkewwei edited comment on LUCENE-10448 at 3/3/22, 10:44 AM:
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500655#comment-17500655
]
kkewwei edited comment on LUCENE-10448 at 3/3/22, 10:45 AM:
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500655#comment-17500655
]
kkewwei edited comment on LUCENE-10448 at 3/3/22, 10:46 AM:
romseygeek merged pull request #722:
URL: https://github.com/apache/lucene/pull/722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
[
https://issues.apache.org/jira/browse/LUCENE-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500662#comment-17500662
]
ASF subversion and git services commented on LUCENE-10431:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500678#comment-17500678
]
ASF subversion and git services commented on LUCENE-10431:
--
Co
romseygeek opened a new pull request #727:
URL: https://github.com/apache/lucene/pull/727
BooleanQuery assumes that its children's hashcodes are stable, and has some
assertions to this effect. This did not apply to MultiTermQuery, which has
a
mutable RewriteMethod member variable th
[
https://issues.apache.org/jira/browse/LUCENE-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500706#comment-17500706
]
Alan Woodward commented on LUCENE-10431:
Follow up PRs:
* For main, removing t
dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1058085879
Thanks for fixing the issue @jpountz and everyone for your support and ideas!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/LUCENE-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500789#comment-17500789
]
Daniel Doubrovkine edited comment on LUCENE-10428 at 3/3/22, 2:27 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500789#comment-17500789
]
Daniel Doubrovkine commented on LUCENE-10428:
-
I agree with the above. The
[
https://issues.apache.org/jira/browse/LUCENE-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-10302:
--
Attachment: LUCENE_PriorityQueue_Builder_with_heapify.patch
> PriorityQueue: optimize where w
[
https://issues.apache.org/jira/browse/LUCENE-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500803#comment-17500803
]
David Smiley commented on LUCENE-10302:
---
I attached my WIP as a patch file. Look
mayya-sharipova opened a new pull request #728:
URL: https://github.com/apache/lucene/pull/728
Currently VectorValuesWriter buffers vectors in memory.
The problem is that as multi-dimensional vectors consume a lot of memory,
a lot of flushes are triggered. Each flush is a very expensi
mayya-sharipova commented on pull request #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1058148842
I've benchmarked the results with ann-benchmarks on glove-100-angular (M:16,
efConstruction:100)
- baseline: main branch where we unset RAMBufferSizeMB, which defau
mayya-sharipova edited a comment on pull request #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1058148842
I've benchmarked the results with ann-benchmarks on glove-100-angular (M:16,
efConstruction:100)
- baseline: main branch where we unset RAMBufferSizeMB, whic
mayya-sharipova edited a comment on pull request #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1058148842
I've benchmarked the results with ann-benchmarks on glove-100-angular (M:16,
efConstruction:100)
- baseline: main branch where we unset RAMBufferSizeMB, whic
mayya-sharipova edited a comment on pull request #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1058148842
I've benchmarked the results with ann-benchmarks on glove-100-angular (M:16,
efConstruction:100)
- baseline: main branch where we unset RAMBufferSizeMB, whic
mayya-sharipova edited a comment on pull request #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1058148842
I've benchmarked the results with ann-benchmarks on glove-100-angular (M:16,
efConstruction:100)
- baseline: main branch where we unset RAMBufferSizeMB, whic
mayya-sharipova edited a comment on pull request #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1058148842
I've benchmarked the results with ann-benchmarks on glove-100-angular (M:16,
efConstruction:100)
- baseline: main branch where we unset RAMBufferSizeMB, whic
mayya-sharipova edited a comment on pull request #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1058148842
I've benchmarked the results with ann-benchmarks on glove-100-angular (M:16,
efConstruction:100)
- candidate: this PR, where RAMBufferSizeMB similarly is set
mayya-sharipova edited a comment on pull request #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1058148842
I've benchmarked the results with ann-benchmarks on glove-100-angular (M:16,
efConstruction:100)
- candidate: this PR, where RAMBufferSizeMB is set to defaul
mayya-sharipova edited a comment on pull request #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1058148842
I've benchmarked the results with ann-benchmarks on glove-100-angular (M:16,
efConstruction:100)
- baseline: main branch where we unset RAMBufferSizeMB, whic
thelabdude commented on a change in pull request #2165:
URL: https://github.com/apache/lucene-solr/pull/2165#discussion_r818795935
##
File path: solr/contrib/prometheus-exporter/conf/solr-exporter-config.xml
##
@@ -315,88 +477,22 @@
node metrics
-->
thelabdude commented on a change in pull request #2165:
URL: https://github.com/apache/lucene-solr/pull/2165#discussion_r818797045
##
File path: solr/contrib/prometheus-exporter/conf/solr-exporter-config.xml
##
@@ -315,88 +477,22 @@
node metrics
-->
[
https://issues.apache.org/jira/browse/LUCENE-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500898#comment-17500898
]
Greg Miller commented on LUCENE-10302:
--
Thanks [~dsmiley]. I'd sketched something
[
https://issues.apache.org/jira/browse/LUCENE-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500900#comment-17500900
]
Ankit Jain commented on LUCENE-10428:
-
I am fine with closing this issue. I will op
[
https://issues.apache.org/jira/browse/LUCENE-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10428.
---
Fix Version/s: 9.1
Resolution: Fixed
Thanks both!
> getMinCompetitiveScore method i
[
https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500911#comment-17500911
]
Adrien Grand commented on LUCENE-10078:
---
LUCENE-10237 introduced a very simple Me
dsmiley commented on a change in pull request #2165:
URL: https://github.com/apache/lucene-solr/pull/2165#discussion_r81389
##
File path: solr/contrib/prometheus-exporter/conf/solr-exporter-config.xml
##
@@ -315,88 +477,22 @@
node metrics
-->
[
https://issues.apache.org/jira/browse/LUCENE-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated LUCENE-10441:
-
Affects Version/s: 8.10
> ArrayIndexOutOfBoundsException during indexing
>
[
https://issues.apache.org/jira/browse/LUCENE-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500933#comment-17500933
]
Christine Poerschke commented on LUCENE-10441:
--
line 179 from the stacktra
Julie Tibshirani created LUCENE-10454:
-
Summary: UnifiedHighlighter can miss terms because of query
rewrites
Key: LUCENE-10454
URL: https://issues.apache.org/jira/browse/LUCENE-10454
Project: Luce
[
https://issues.apache.org/jira/browse/LUCENE-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-10454:
--
Attachment: LUCENE-10454.patch
> UnifiedHighlighter can miss terms because of query r
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500982#comment-17500982
]
Vigya Sharma commented on LUCENE-10448:
---
The only API which can lead to unexpecte
dweiss merged pull request #717:
URL: https://github.com/apache/lucene/pull/717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
[
https://issues.apache.org/jira/browse/LUCENE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501009#comment-17501009
]
ASF subversion and git services commented on LUCENE-10447:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-10447.
--
Fix Version/s: 9.1
Resolution: Fixed
> Charset issue in TestScripts#testLukeCanBeLaunc
[
https://issues.apache.org/jira/browse/LUCENE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501013#comment-17501013
]
ASF subversion and git services commented on LUCENE-10447:
--
Co
msokolov commented on a change in pull request #718:
URL: https://github.com/apache/lucene/pull/718#discussion_r819043542
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
##
@@ -173,17 +185,17 @@ public FacetResult getTopChildren(int
msokolov commented on pull request #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1058487021
This makes sense to me, but I'm a little confused about how you described
the test condition:
> baseline: main branch where we unset RAMBufferSizeMB, which defaults to
16M
msokolov commented on a change in pull request #728:
URL: https://github.com/apache/lucene/pull/728#discussion_r819056510
##
File path: lucene/core/src/java/org/apache/lucene/index/VectorValuesWriter.java
##
@@ -20,39 +20,53 @@
import java.io.IOException;
import java.nio.Byte
msokolov commented on pull request #718:
URL: https://github.com/apache/lucene/pull/718#issuecomment-1058501380
> It makes sense to me to add this capability. I wonder if the extra
abstraction hurts us though in these tight loops summing up values in an array?
If it does, we might want to
rmuir commented on pull request #709:
URL: https://github.com/apache/lucene/pull/709#issuecomment-1058571689
@iverase @jpountz I "undrafted" the PR and added a commit with the
`grow(long)` that just truncates-n-forwards. It seems like the best compromise
based on discussion above.
[
https://issues.apache.org/jira/browse/LUCENE-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501072#comment-17501072
]
Holger Rehn commented on LUCENE-10430:
--
Thanks for the feedback! But why do I need
jtibshirani commented on pull request #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1058674634
Great that we're exploring this! I had a couple high-level thoughts:
* If a user had 100 vector fields, then now we might have 100+ files being
written concurrently, multipl
jtibshirani edited a comment on pull request #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1058674634
Great that we're exploring this! I had a couple high-level thoughts:
* If a user had 100 vector fields, then now we might have 100+ files being
written concurrently,
[
https://issues.apache.org/jira/browse/LUCENE-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501101#comment-17501101
]
Vigya Sharma commented on LUCENE-10302:
---
[~gsmiller] Is the link you pasted worki
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500982#comment-17500982
]
Vigya Sharma edited comment on LUCENE-10448 at 3/4/22, 2:06 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501122#comment-17501122
]
Lu Xugang commented on LUCENE-10162:
Move the conversation from LUCENE-10446 about
[
https://issues.apache.org/jira/browse/LUCENE-10162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10162:
---
Attachment: LUCENE-10162-1.patch
> Add IntField, LongField, FloatField and DoubleField classes to i
[
https://issues.apache.org/jira/browse/LUCENE-10162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501124#comment-17501124
]
Lu Xugang commented on LUCENE-10162:
This is a new Query within the quick patch nam
rmuir commented on pull request #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1058815901
Sorry I see it differently.
I'm not a fan of IndexWriter handling the temporary files/encoding/decoding
data, this seems to be in the wrong place.
If IndexWriter should
rmuir commented on pull request #728:
URL: https://github.com/apache/lucene/pull/728#issuecomment-1058821263
I'm suspicious of the reported performance improvement based on looking at
your benchmark output, I don't think its realistic. Looks like nothing else was
indexed in any other way (
Lu Xugang created LUCENE-10455:
--
Summary: IndexSortSortedNumericDocValuesRangeQuery should
implement Weight#scorerSupplier(LeafReaderContext)
Key: LUCENE-10455
URL: https://issues.apache.org/jira/browse/LUCENE-10455
[
https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501193#comment-17501193
]
Anand Kotriwal commented on LUCENE-10078:
-
I like the idea of adding this featu
[
https://issues.apache.org/jira/browse/LUCENE-10078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501193#comment-17501193
]
Anand Kotriwal edited comment on LUCENE-10078 at 3/4/22, 7:19 AM:
---
LuXugang opened a new pull request #729:
URL: https://github.com/apache/lucene/pull/729
IndexOrDocValuesQuery was used as a fallbackQuery of
IndexSortSortedNumericDocValuesRangeQuery in Elasticsearch, but When
IndexSortSortedNumericDocValuesRangeQuery can't take advantage of index sort,
t
69 matches
Mail list logo
