dweiss commented on pull request #696:
URL: https://github.com/apache/lucene/pull/696#issuecomment-1048561226
Hi @mocobeta . This looks impressive that it can be done! I kind of like the
verbose version because then you can tell what's going on, whereas the custom
action is much more diffi
Adrien Grand created LUCENE-10436:
-
Summary: Combine DocValuesFieldExistsQuery, NormsFieldExistsQuery
and KnnVectorFieldExistsQuery into a single FieldExistsQuery?
Key: LUCENE-10436
URL: https://issues.apache.org/
LuXugang commented on pull request #701:
URL: https://github.com/apache/lucene/pull/701#issuecomment-1048582255
>
much more thoughtful！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
LuXugang removed a comment on pull request #701:
URL: https://github.com/apache/lucene/pull/701#issuecomment-1048582255
>
much more thoughtful！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
LuXugang commented on pull request #701:
URL: https://github.com/apache/lucene/pull/701#issuecomment-1048582999
> then we don't need to maintain the `rewritableReaders` counter?
Much more thoughtful！
--
This is an automated message from the Apache Git Service.
To respond to the mes
jpountz opened a new pull request #702:
URL: https://github.com/apache/lucene/pull/702
`KnnVectorQuery` currently uses the index reader's hashcode to make sure that
the query it builds runs on the right reader. We had added
`IndexContextReader#id` a while back for a similar purpose wit
jpountz commented on a change in pull request #700:
URL: https://github.com/apache/lucene/pull/700#discussion_r812722194
##
File path:
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
##
@@ -821,6 +822,64 @@ public void testRandom(
epugh commented on pull request #2643:
URL: https://github.com/apache/lucene-solr/pull/2643#issuecomment-1048668234
I like what this does, but I totally agree about all the
`getClass()`/`instanceof` stuff! I wonder if burying all that logic into a
method with a name like `normalizeArgsTo
Ignacio Vera created LUCENE-10437:
-
Summary: Improve error message in the Tessellator for polygon with
all points collinear
Key: LUCENE-10437
URL: https://issues.apache.org/jira/browse/LUCENE-10437
Pr
iverase opened a new pull request #703:
URL: https://github.com/apache/lucene/pull/703
Polygon tessellator throws a more informative error message when the
provided polygon does not contain enough no-collinear points.
--
This is an automated message from the Apache Git Service.
To r
romseygeek commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r812845233
##
File path:
lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foun
iverase merged pull request #703:
URL: https://github.com/apache/lucene/pull/703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
[
https://issues.apache.org/jira/browse/LUCENE-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496734#comment-17496734
]
ASF subversion and git services commented on LUCENE-10437:
--
Co
jpountz merged pull request #701:
URL: https://github.com/apache/lucene/pull/701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
[
https://issues.apache.org/jira/browse/LUCENE-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496740#comment-17496740
]
ASF subversion and git services commented on LUCENE-10437:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496739#comment-17496739
]
ASF subversion and git services commented on LUCENE-10435:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-10437.
---
Fix Version/s: 9.1
Assignee: Ignacio Vera
Resolution: Fixed
> Improve error
[
https://issues.apache.org/jira/browse/LUCENE-10432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andriy Redko updated LUCENE-10432:
--
Affects Version/s: 8.10.1
9.0
> Add optional 'name' property to org.ap
jpountz commented on pull request #687:
URL: https://github.com/apache/lucene/pull/687#issuecomment-1048791215
This looks very similar to the implementation of `Weight#count` on
`PointRangeQuery` and should only perform marginally faster?
It's uncreal to me whether this PR buys us much.
[
https://issues.apache.org/jira/browse/LUCENE-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496766#comment-17496766
]
Adrien Grand commented on LUCENE-10425:
---
I'm not sure #687 actually helps compare
Adrien Grand created LUCENE-10438:
-
Summary: Leverage Weight#count in lucene/facets
Key: LUCENE-10438
URL: https://issues.apache.org/jira/browse/LUCENE-10438
Project: Lucene - Core
Issue Type
mogui commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r812915950
##
File path:
lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundatio
jpountz commented on pull request #686:
URL: https://github.com/apache/lucene/pull/686#issuecomment-1048810781
Hard not to think of [this XKCD](https://xkcd.com/221/). :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
LuXugang opened a new pull request #704:
URL: https://github.com/apache/lucene/pull/704
Add entry for [#701](https://github.com/apache/lucene/pull/701)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mocobeta commented on pull request #696:
URL: https://github.com/apache/lucene/pull/696#issuecomment-104455
I didn't explain the implementation so it might be hard to figure out what's
happening here at the first glance; the matrix value is propagated from the
custom action to each job
mocobeta commented on pull request #696:
URL: https://github.com/apache/lucene/pull/696#issuecomment-1048944204
This is a kind of exercise to see how the Actions runner works to me, but we
wouldn't need it unless we have a lot more jobs to run.
--
This is an automated message from the Ap
jtibshirani merged pull request #699:
URL: https://github.com/apache/lucene/pull/699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubs
[
https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496888#comment-17496888
]
ASF subversion and git services commented on LUCENE-10054:
--
Co
jtibshirani commented on a change in pull request #704:
URL: https://github.com/apache/lucene/pull/704#discussion_r813077353
##
File path: lucene/CHANGES.txt
##
@@ -191,6 +191,9 @@ Improvements
* LUCENE-10371: Make IndexRearranger able to arrange segment in a determined
order
jtibshirani commented on a change in pull request #700:
URL: https://github.com/apache/lucene/pull/700#discussion_r813083832
##
File path:
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java
##
@@ -186,6 +188,7 @@ private NeighborQueue searchLevel(
jtibshirani commented on a change in pull request #700:
URL: https://github.com/apache/lucene/pull/700#discussion_r813084279
##
File path:
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
##
@@ -821,6 +822,64 @@ public void testRan
LuXugang commented on a change in pull request #704:
URL: https://github.com/apache/lucene/pull/704#discussion_r813093098
##
File path: lucene/CHANGES.txt
##
@@ -191,6 +191,9 @@ Improvements
* LUCENE-10371: Make IndexRearranger able to arrange segment in a determined
order.
jtibshirani commented on a change in pull request #700:
URL: https://github.com/apache/lucene/pull/700#discussion_r813116025
##
File path:
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
##
@@ -821,6 +822,64 @@ public void testRan
[
https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496910#comment-17496910
]
ASF subversion and git services commented on LUCENE-10054:
--
Co
jpountz commented on a change in pull request #700:
URL: https://github.com/apache/lucene/pull/700#discussion_r813130011
##
File path:
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
##
@@ -821,6 +822,64 @@ public void testRandom(
[
https://issues.apache.org/jira/browse/LUCENE-10435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496920#comment-17496920
]
ASF subversion and git services commented on LUCENE-10435:
--
Co
jtibshirani commented on a change in pull request #700:
URL: https://github.com/apache/lucene/pull/700#discussion_r813130908
##
File path:
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java
##
@@ -155,18 +159,13 @@ private NeighborQueue searchLevel(
i
jpountz commented on a change in pull request #700:
URL: https://github.com/apache/lucene/pull/700#discussion_r813134067
##
File path:
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java
##
@@ -155,18 +159,13 @@ private NeighborQueue searchLevel(
if (r
jpountz commented on a change in pull request #700:
URL: https://github.com/apache/lucene/pull/700#discussion_r813135325
##
File path:
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java
##
@@ -186,6 +188,7 @@ private NeighborQueue searchLevel(
[
https://issues.apache.org/jira/browse/LUCENE-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497020#comment-17497020
]
Greg Miller commented on LUCENE-10438:
--
Interesting thought. So off the top of my
[
https://issues.apache.org/jira/browse/LUCENE-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-10438:
-
Component/s: modules/facet
> Leverage Weight#count in lucene/facets
> -
[
https://issues.apache.org/jira/browse/LUCENE-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497023#comment-17497023
]
Adrien Grand commented on LUCENE-10438:
---
I believe that it is mostly applicable t
jtibshirani merged pull request #700:
URL: https://github.com/apache/lucene/pull/700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubs
[
https://issues.apache.org/jira/browse/LUCENE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497061#comment-17497061
]
ASF subversion and git services commented on LUCENE-10382:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497066#comment-17497066
]
ASF subversion and git services commented on LUCENE-10382:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497068#comment-17497068
]
Greg Miller commented on LUCENE-10438:
--
Thanks [~jpountz]. Yep, that's exactly was
jtibshirani merged pull request #704:
URL: https://github.com/apache/lucene/pull/704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubs
[
https://issues.apache.org/jira/browse/LUCENE-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller reassigned LUCENE-10438:
Assignee: Greg Miller
> Leverage Weight#count in lucene/facets
> ---
[
https://issues.apache.org/jira/browse/LUCENE-10435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497069#comment-17497069
]
ASF subversion and git services commented on LUCENE-10435:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497071#comment-17497071
]
ASF subversion and git services commented on LUCENE-10435:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497159#comment-17497159
]
ASF subversion and git services commented on LUCENE-10382:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497161#comment-17497161
]
ASF subversion and git services commented on LUCENE-10382:
--
Co
Lu Xugang created LUCENE-10439:
--
Summary: Support multi-valued and multiple dimensions for count
query in PointRangeQuery
Key: LUCENE-10439
URL: https://issues.apache.org/jira/browse/LUCENE-10439
Project
LuXugang opened a new pull request #705:
URL: https://github.com/apache/lucene/pull/705
Follow-up of
[LUCENE-10424](https://issues.apache.org/jira/browse/LUCENE-10424), it also
works with fields that have multiple dimensions and/or that are multi-valued.
--
This is an automated message
54 matches
Mail list logo
