[GitHub] [lucene] mocobeta opened a new pull request #694: supress Actions jobs when only text files are changed

2022-02-19 Thread GitBox
mocobeta opened a new pull request #694: URL: https://github.com/apache/lucene/pull/694 - A follow-up of #674 - It wouldn't be needed to run check jobs when only text files (CHANGES, etc.) are changed. https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-act

[GitHub] [lucene] mocobeta commented on pull request #694: supress Actions jobs when only text files are changed

2022-02-19 Thread GitBox
mocobeta commented on pull request #694: URL: https://github.com/apache/lucene/pull/694#issuecomment-1046018874 The syntax is fine - I assume there is no harm in merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [lucene] rmuir commented on pull request #692: LUCENE-10311: Different implementations of DocIdSetBuilder for points and terms

2022-02-19 Thread GitBox
rmuir commented on pull request #692: URL: https://github.com/apache/lucene/pull/692#issuecomment-1046065536 I'm still a bit confused about why we need to `grow(long)` on a bitset that can only hold `Integer.MAX_VALUE` elements. I've re-read the description of the JIRA several times this m

[GitHub] [lucene] dweiss commented on pull request #694: supress Actions jobs when only text files are changed

2022-02-19 Thread GitBox
dweiss commented on pull request #694: URL: https://github.com/apache/lucene/pull/694#issuecomment-1046084341 I wouldn't do it. You never know what those text files - they can be resources that are compiled or used at runtime, etc. Why bother? This is what the CI is for - to make sure we (

[GitHub] [lucene] dweiss edited a comment on pull request #694: supress Actions jobs when only text files are changed

2022-02-19 Thread GitBox
dweiss edited a comment on pull request #694: URL: https://github.com/apache/lucene/pull/694#issuecomment-1046084341 I wouldn't do it. You never know what those text files are - they can be resources that are compiled or used at runtime, etc. Why bother? This is what the CI is for - to mak

[GitHub] [lucene] mocobeta commented on pull request #693: LUCENE-10400: revise binary dictionaries' constructor in nori

2022-02-19 Thread GitBox
mocobeta commented on pull request #693: URL: https://github.com/apache/lucene/pull/693#issuecomment-1046177607 > We will also have a second PR to remove the deprecated APIs in main branch? Yes, I will. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene] mocobeta merged pull request #693: LUCENE-10400: revise binary dictionaries' constructor in nori

2022-02-19 Thread GitBox
mocobeta merged pull request #693: URL: https://github.com/apache/lucene/pull/693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (LUCENE-10400) Clean up the constructors' API signature of dictionary classes in kuromoji and nori

2022-02-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495094#comment-17495094 ] ASF subversion and git services commented on LUCENE-10400: -- Co

[jira] [Commented] (LUCENE-10400) Clean up the constructors' API signature of dictionary classes in kuromoji and nori

2022-02-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495095#comment-17495095 ] ASF subversion and git services commented on LUCENE-10400: -- Co

[GitHub] [lucene] mocobeta opened a new pull request #695: LUCENE-10400: Remove deprecated constructors in Nori

2022-02-19 Thread GitBox
mocobeta opened a new pull request #695: URL: https://github.com/apache/lucene/pull/695 This removes the deprecated APIs in #693. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com