iverase opened a new pull request #685:
URL: https://github.com/apache/lucene/pull/685
These query wrappers do not modify the set of matching documents so they can
delegate Weight#count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mayya-sharipova commented on a change in pull request #656:
URL: https://github.com/apache/lucene/pull/656#discussion_r807653039
##
File path: lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java
##
@@ -24,19 +24,36 @@
import java.util.Objects;
import org.apache.
rmuir opened a new pull request #686:
URL: https://github.com/apache/lucene/pull/686
All the other uses of `System.currentTimeMillis` (both java and test code)
are no good, but i'd rather tackle them in a followup issue (I will make a
JIRA). Eventually, we can ban use of wall clock time wi
[
https://issues.apache.org/jira/browse/LUCENE-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493146#comment-17493146
]
Robert Muir commented on LUCENE-10391:
--
Actually these nightly benchmarks have not
Robert Muir created LUCENE-10423:
Summary: Remove uses of wall-clock time in codebase
Key: LUCENE-10423
URL: https://issues.apache.org/jira/browse/LUCENE-10423
Project: Lucene - Core
Issue Ty
rmuir commented on pull request #681:
URL: https://github.com/apache/lucene/pull/681#issuecomment-1041345085
Yeah, those are actually API bugs? We have public methods that have
non-public classes in their signature. Looks like this will be more complex to
fix up.
In this example of
mogui commented on pull request #679:
URL: https://github.com/apache/lucene/pull/679#issuecomment-1041408992
@romseygeek I've updated with the requested changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dweiss commented on pull request #681:
URL: https://github.com/apache/lucene/pull/681#issuecomment-1041410379
> Yeah, those are actually API bugs?
They do look like API issues to me. Useful warning, by the way.
--
This is an automated message from the Apache Git Service.
To respond
mayya-sharipova commented on a change in pull request #649:
URL: https://github.com/apache/lucene/pull/649#discussion_r807992105
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsWriter.java
##
@@ -206,14 +203,22 @@ private void writeMeta(
mayya-sharipova commented on a change in pull request #649:
URL: https://github.com/apache/lucene/pull/649#discussion_r807992728
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java
##
@@ -424,38 +448,45 @@ public int docID() {
mayya-sharipova commented on a change in pull request #649:
URL: https://github.com/apache/lucene/pull/649#discussion_r807993536
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java
##
@@ -266,12 +268,12 @@ private Bits getAcceptO
mayya-sharipova commented on a change in pull request #649:
URL: https://github.com/apache/lucene/pull/649#discussion_r807998586
##
File path:
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
##
@@ -1018,4 +1020,57 @@ public void t
mayya-sharipova commented on a change in pull request #649:
URL: https://github.com/apache/lucene/pull/649#discussion_r807998586
##
File path:
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
##
@@ -1018,4 +1020,57 @@ public void t
mayya-sharipova commented on a change in pull request #649:
URL: https://github.com/apache/lucene/pull/649#discussion_r807998586
##
File path:
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
##
@@ -1018,4 +1020,57 @@ public void t
mayya-sharipova commented on a change in pull request #649:
URL: https://github.com/apache/lucene/pull/649#discussion_r807998586
##
File path:
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
##
@@ -1018,4 +1020,57 @@ public void t
janhoy commented on pull request #2641:
URL: https://github.com/apache/lucene-solr/pull/2641#issuecomment-1041761443
So the benefit of backporting to 8x is that we get a more secure PKI for the
lifetime of 8x (12+ months), and that you get an upgrade path 8.x -> 8.11.2 ->
9.x where rolling
[
https://issues.apache.org/jira/browse/LUCENE-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493305#comment-17493305
]
Michael McCandless commented on LUCENE-10391:
-
Sorry for the nightly benchm
[
https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493306#comment-17493306
]
Michael McCandless commented on LUCENE-10421:
-
+1 for a constant. 42 seems
[
https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493320#comment-17493320
]
Robert Muir commented on LUCENE-10421:
--
42 patch is here: https://github.com/apach
[
https://issues.apache.org/jira/browse/LUCENE-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493345#comment-17493345
]
Julie Tibshirani commented on LUCENE-10391:
---
Oh okay thanks, ignore my analys
gsmiller commented on a change in pull request #678:
URL: https://github.com/apache/lucene/pull/678#discussion_r808256634
##
File path: lucene/core/src/java/org/apache/lucene/document/FeatureQuery.java
##
@@ -111,12 +111,9 @@ public Explanation explain(LeafReaderContext context
gsmiller commented on pull request #678:
URL: https://github.com/apache/lucene/pull/678#issuecomment-1041899789
Thanks for the quick iteration! This looks good to me now. As I mentioned
before, I'm going to wait a couple days before merging in case anyone else
wants to chime in with feedba
gsmiller commented on a change in pull request #685:
URL: https://github.com/apache/lucene/pull/685#discussion_r808281208
##
File path: lucene/CHANGES.txt
##
@@ -615,6 +615,8 @@ Improvements
* LUCENE-10062: Switch taxonomy faceting to use numeric doc values for storing
ordi
jtibshirani commented on a change in pull request #656:
URL: https://github.com/apache/lucene/pull/656#discussion_r808308244
##
File path: build.gradle
##
@@ -183,3 +183,5 @@ apply from: file('gradle/hacks/turbocharge-jvm-opts.gradle')
apply from: file('gradle/hacks/dummy-outp
jtibshirani commented on a change in pull request #656:
URL: https://github.com/apache/lucene/pull/656#discussion_r808356718
##
File path: lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java
##
@@ -455,6 +484,61 @@ public void testRandom() throws IOException {
vigyasharma commented on pull request #677:
URL: https://github.com/apache/lucene/pull/677#issuecomment-1042264970
> This looks great. I left a tiny comment related to tests. Could you also
add an entry to `CHANGES.txt` under "Lucene 9.1.0"?
Thank you for reviewing this PR, @jtibshir
[
https://issues.apache.org/jira/browse/LUCENE-10176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493518#comment-17493518
]
Julie Tibshirani commented on LUCENE-10176:
---
Sorry to be jumping in late with
jtibshirani commented on a change in pull request #649:
URL: https://github.com/apache/lucene/pull/649#discussion_r808504111
##
File path:
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
##
@@ -1018,4 +1020,57 @@ public void testA
iverase commented on a change in pull request #685:
URL: https://github.com/apache/lucene/pull/685#discussion_r808708059
##
File path: lucene/CHANGES.txt
##
@@ -615,6 +615,8 @@ Improvements
* LUCENE-10062: Switch taxonomy faceting to use numeric doc values for storing
ordin
iverase merged pull request #685:
URL: https://github.com/apache/lucene/pull/685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
[
https://issues.apache.org/jira/browse/LUCENE-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493705#comment-17493705
]
ASF subversion and git services commented on LUCENE-10415:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493709#comment-17493709
]
ASF subversion and git services commented on LUCENE-10415:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-10415.
---
Fix Version/s: 9.1
Assignee: Ignacio Vera
Resolution: Fixed
> FunctionScore
33 matches
Mail list logo
