uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r804516322
##
File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java
##
@@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir)
t
uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r804516322
##
File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java
##
@@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir)
t
uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r804516322
##
File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java
##
@@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir)
t
uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r804523983
##
File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java
##
@@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir)
t
uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r804526911
##
File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java
##
@@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir)
t
uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r804527726
##
File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java
##
@@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir)
t
uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r804539288
##
File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java
##
@@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir)
t
uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r804539288
##
File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java
##
@@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir)
t
uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r804540458
##
File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java
##
@@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir)
t
mocobeta commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r804576732
##
File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java
##
@@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir)
thr
uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r804603025
##
File path: lucene/core/src/java/org/apache/lucene/util/IOConsumer.java
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r804604627
##
File path: lucene/core/src/java/org/apache/lucene/util/IOConsumer.java
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
uschindler commented on pull request #673:
URL: https://github.com/apache/lucene/pull/673#issuecomment-1036164896
Hi, I would make the still missing changes, because the deprecation is a bit
tricky and hard to explain.
--
This is an automated message from the Apache Git Service.
To respo
mocobeta commented on pull request #673:
URL: https://github.com/apache/lucene/pull/673#issuecomment-1036212423
@uschindler Thanks for your review, I have to leave but will be back next
week and refine this.
--
This is an automated message from the Apache Git Service.
To respond to the m
uschindler commented on pull request #673:
URL: https://github.com/apache/lucene/pull/673#issuecomment-1036218874
I will just commit some changes in thanks for starting the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
msokolov commented on a change in pull request #676:
URL: https://github.com/apache/lucene/pull/676#discussion_r804842543
##
File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java
##
@@ -38,15 +38,6 @@ protected VectorValues() {}
/** Return the dimension o
msokolov commented on a change in pull request #676:
URL: https://github.com/apache/lucene/pull/676#discussion_r804844197
##
File path:
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
##
@@ -929,6 +931,17 @@ private void add(
gautamworah96 commented on a change in pull request #658:
URL: https://github.com/apache/lucene/pull/658#discussion_r805112108
##
File path: lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
##
@@ -369,6 +378,100 @@ public Scorer scorer(LeafReaderContext contex
vigyasharma commented on pull request #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1036989788
The `addIndexes(CodecReaders[])` API is transactional in nature - either all
readers get added or all of them fail. Retaining this behavior with concurrent
background merges n
19 matches
Mail list logo
