[GitHub] [lucene] jpountz commented on a change in pull request #607: LUCENE-10288: Check BKD tree shape for lucene pre-8.6 1D indexes

2022-01-19 Thread GitBox
jpountz commented on a change in pull request #607: URL: https://github.com/apache/lucene/pull/607#discussion_r787510031 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDReader.java ## @@ -105,6 +107,52 @@ public BKDReader(IndexInput metaIn, IndexInput indexIn,

[GitHub] [lucene] mocobeta commented on pull request #550: LUCENE-8930: script testing in the distribution

2022-01-19 Thread GitBox
mocobeta commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-1016427587 Hi, I just wanted to know if there is anything that blocks this to merge or this is going to be abandoned. I should have created a forked branch and made possible refinements, bu

[GitHub] [lucene] dweiss commented on pull request #550: LUCENE-8930: script testing in the distribution

2022-01-19 Thread GitBox
dweiss commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-1016430045 Hi @mocobeta . Please feel free to commit this in. Maybe change the strings used to verify assertions? They're... well, frivolous. ;) -- This is an automated message from the Apa

[GitHub] [lucene] mocobeta commented on pull request #550: LUCENE-8930: script testing in the distribution

2022-01-19 Thread GitBox
mocobeta commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-1016511964 Thanks. > Maybe change the strings used to verify assertions? I'm fine with it as is and there would be no harm in having a little joke for internal use, or rather

[GitHub] [lucene] mocobeta edited a comment on pull request #550: LUCENE-8930: script testing in the distribution

2022-01-19 Thread GitBox
mocobeta edited a comment on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-1016511964 Thanks. > Maybe change the strings used to verify assertions? I'm fine with it as is and there would be no harm in having a little joke for internal use, or

[GitHub] [lucene] dweiss commented on pull request #550: LUCENE-8930: script testing in the distribution

2022-01-19 Thread GitBox
dweiss commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-1016548917 Fine then, commit it in! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [lucene] mocobeta merged pull request #550: LUCENE-8930: script testing in the distribution

2022-01-19 Thread GitBox
mocobeta merged pull request #550: URL: https://github.com/apache/lucene/pull/550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (LUCENE-8930) Integrate Luke app health check to nightly tests (CI)

2022-01-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478755#comment-17478755 ] ASF subversion and git services commented on LUCENE-8930: - Commi

[GitHub] [lucene] mocobeta commented on pull request #550: LUCENE-8930: script testing in the distribution

2022-01-19 Thread GitBox
mocobeta commented on pull request #550: URL: https://github.com/apache/lucene/pull/550#issuecomment-1016567591 Merged. Many thanks, @dweiss! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene] iverase commented on pull request #541: LUCENE-10315: Speed up BKD leaf block ids codec by a 512 ints ForUtil

2022-01-19 Thread GitBox
iverase commented on pull request #541: URL: https://github.com/apache/lucene/pull/541#issuecomment-1016597242 You need to try `IndexAndSearchShapes` in luceneutil. Not sure if it is up-to-date but running it is similar to `IndexAndSearchOpenStreetMaps`. -- This is an automated message f

[GitHub] [lucene] gsmiller commented on pull request #611: LUCENE-9952: Fix dim count inaccuracies in SSDV faceting when a dim is multi-valued

2022-01-19 Thread GitBox
gsmiller commented on pull request #611: URL: https://github.com/apache/lucene/pull/611#issuecomment-1016813104 @mdmarshmallow you might have some thoughts on this since you recently dug into this code and I believe ran into this long-standing bug that this PR is addressing. -- This is

[GitHub] [lucene] gsmiller commented on pull request #613: LUCENE-10381: Require users to provide FacetsConfig for SSDV faceting

2022-01-19 Thread GitBox
gsmiller commented on pull request #613: URL: https://github.com/apache/lucene/pull/613#issuecomment-1016814203 @mdmarshmallow curious what you think of this (if you have time). Since you recently added the ability for users to provide their facet config, I'm curious if you thought at all

[jira] [Created] (LUCENE-10382) Allow KnnVectorQuery to operate over a subset of liveDocs

2022-01-19 Thread Joel Bernstein (Jira)
Joel Bernstein created LUCENE-10382: --- Summary: Allow KnnVectorQuery to operate over a subset of liveDocs Key: LUCENE-10382 URL: https://issues.apache.org/jira/browse/LUCENE-10382 Project: Lucene - Co

[jira] [Updated] (LUCENE-10382) Allow KnnVectorQuery to operate over a subset of liveDocs

2022-01-19 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated LUCENE-10382: Affects Version/s: 9.0 > Allow KnnVectorQuery to operate over a subset of liveDocs >

[jira] [Commented] (LUCENE-10382) Allow KnnVectorQuery to operate over a subset of liveDocs

2022-01-19 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479014#comment-17479014 ] Michael Sokolov commented on LUCENE-10382: -- How would this look? An easy first

[jira] [Commented] (LUCENE-10382) Allow KnnVectorQuery to operate over a subset of liveDocs

2022-01-19 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479016#comment-17479016 ] Joel Bernstein commented on LUCENE-10382: - I thought about passing in Bits but

[jira] [Comment Edited] (LUCENE-10382) Allow KnnVectorQuery to operate over a subset of liveDocs

2022-01-19 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479016#comment-17479016 ] Joel Bernstein edited comment on LUCENE-10382 at 1/19/22, 10:52 PM: -

[jira] [Comment Edited] (LUCENE-10382) Allow KnnVectorQuery to operate over a subset of liveDocs

2022-01-19 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479014#comment-17479014 ] Michael Sokolov edited comment on LUCENE-10382 at 1/19/22, 10:54 PM:

[jira] [Commented] (LUCENE-10382) Allow KnnVectorQuery to operate over a subset of liveDocs

2022-01-19 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479017#comment-17479017 ] Michael Sokolov commented on LUCENE-10382: -- > I thought about passing in Bits

[GitHub] [lucene] iverase merged pull request #607: LUCENE-10288: Check BKD tree shape for lucene pre-8.6 1D indexes

2022-01-19 Thread GitBox
iverase merged pull request #607: URL: https://github.com/apache/lucene/pull/607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10288) Are 1-dimensional kd trees in pre-86 indices always unbalanced trees?

2022-01-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479122#comment-17479122 ] ASF subversion and git services commented on LUCENE-10288: -- Co

[jira] [Commented] (LUCENE-10288) Are 1-dimensional kd trees in pre-86 indices always unbalanced trees?

2022-01-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479123#comment-17479123 ] ASF subversion and git services commented on LUCENE-10288: -- Co

[jira] [Resolved] (LUCENE-10288) Are 1-dimensional kd trees in pre-86 indices always unbalanced trees?

2022-01-19 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-10288. --- Assignee: Ignacio Vera Resolution: Fixed > Are 1-dimensional kd trees in pre-86 indic

[jira] [Commented] (LUCENE-10375) Speed up HNSW merge by writing combined vector data

2022-01-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479149#comment-17479149 ] Adrien Grand commented on LUCENE-10375: --- Nightly benchmarks have picked up this c