[jira] [Commented] (LUCENE-9809) Adapt Release Wizard to only release Lucene

2021-10-25 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433599#comment-17433599 ] Jan Høydahl commented on LUCENE-9809: - I adapted releaseWizard to capture ASF pw wit

[jira] [Commented] (LUCENE-9809) Adapt Release Wizard to only release Lucene

2021-10-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433605#comment-17433605 ] Dawid Weiss commented on LUCENE-9809: - mavenToApacheReleases already checks that it'

[jira] [Created] (LUCENE-10203) Improve reuse of StringTokenStream

2021-10-25 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10203: - Summary: Improve reuse of StringTokenStream Key: LUCENE-10203 URL: https://issues.apache.org/jira/browse/LUCENE-10203 Project: Lucene - Core Issue Type: Im

[jira] [Commented] (LUCENE-9809) Adapt Release Wizard to only release Lucene

2021-10-25 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433626#comment-17433626 ] Jan Høydahl commented on LUCENE-9809: - The wizard could definitely run git rev-parse

[jira] [Commented] (LUCENE-9809) Adapt Release Wizard to only release Lucene

2021-10-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433630#comment-17433630 ] Dawid Weiss commented on LUCENE-9809: - This is a question to sonatype... I've had al

[GitHub] [lucene] dweiss merged pull request #410: LUCENE-9660: add tests.neverUpToDate=true option which, by default, makes test tasks always execute.

2021-10-25 Thread GitBox
dweiss merged pull request #410: URL: https://github.com/apache/lucene/pull/410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433733#comment-17433733 ] ASF subversion and git services commented on LUCENE-9660: - Commi

[jira] [Resolved] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9660. - Fix Version/s: main (9.0) Resolution: Fixed > gradle task cache should not cache --tests

[GitHub] [lucene] mayya-sharipova merged pull request #364: LUCENE-10154 NumericLeafComparator to define getPointValues

2021-10-25 Thread GitBox
mayya-sharipova merged pull request #364: URL: https://github.com/apache/lucene/pull/364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[jira] [Commented] (LUCENE-10154) NumericLeafComparator to define getPointValues

2021-10-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433762#comment-17433762 ] ASF subversion and git services commented on LUCENE-10154: -- Co

[GitHub] [lucene-solr] mayya-sharipova opened a new pull request #2593: LUCENE-10154 NumericLeafComparator to define getPointValues

2021-10-25 Thread GitBox
mayya-sharipova opened a new pull request #2593: URL: https://github.com/apache/lucene-solr/pull/2593 This patch adds getPointValues to NumericLeafComparatorsimilar how it has getNumericDocValues. Numeric Sort optimization with points relies on the assumption that points and doc

[jira] [Updated] (LUCENE-10154) NumericLeafComparator to define getPointValues

2021-10-25 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-10154: - Fix Version/s: 8.11 main (9.0) > NumericLeafComparator to define get

[jira] [Resolved] (LUCENE-10154) NumericLeafComparator to define getPointValues

2021-10-25 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova resolved LUCENE-10154. -- Resolution: Fixed > NumericLeafComparator to define getPointValues >

[GitHub] [lucene-solr] mayya-sharipova merged pull request #2593: LUCENE-10154 NumericLeafComparator to define getPointValues

2021-10-25 Thread GitBox
mayya-sharipova merged pull request #2593: URL: https://github.com/apache/lucene-solr/pull/2593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

[jira] [Commented] (LUCENE-10154) NumericLeafComparator to define getPointValues

2021-10-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433788#comment-17433788 ] ASF subversion and git services commented on LUCENE-10154: -- Co

[GitHub] [lucene] jtibshirani opened a new pull request #413: LUCENE-9614: Fix KnnVectorQuery failure when numDocs is 0

2021-10-25 Thread GitBox
jtibshirani opened a new pull request #413: URL: https://github.com/apache/lucene/pull/413 When the reader has no live docs, `KnnVectorQuery` can error out. This happens because `IndexReader#numDocs` is 0, and we end up passing an illegal value of `k = 0` to the search method.

[GitHub] [lucene] jtibshirani commented on pull request #413: LUCENE-9614: Fix KnnVectorQuery failure when numDocs is 0

2021-10-25 Thread GitBox
jtibshirani commented on pull request #413: URL: https://github.com/apache/lucene/pull/413#issuecomment-951238852 This is a pretty obscure bug, I only noticed it because we use a custom `FilterLeafReader` as part of our security implementation. I wasn't able to reproduce it using regular d

[GitHub] [lucene] jpountz commented on a change in pull request #413: LUCENE-9614: Fix KnnVectorQuery failure when numDocs is 0

2021-10-25 Thread GitBox
jpountz commented on a change in pull request #413: URL: https://github.com/apache/lucene/pull/413#discussion_r735928316 ## File path: lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java ## @@ -60,7 +60,8 @@ public KnnVectorQuery(String field, float[] target, int

[GitHub] [lucene] dsmiley commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-25 Thread GitBox
dsmiley commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r735937665 ## File path: lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java ## @@ -638,6 +674,39 @@ protected BreakIterator ge

[GitHub] [lucene] jtibshirani commented on a change in pull request #413: LUCENE-9614: Fix KnnVectorQuery failure when numDocs is 0

2021-10-25 Thread GitBox
jtibshirani commented on a change in pull request #413: URL: https://github.com/apache/lucene/pull/413#discussion_r735961948 ## File path: lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java ## @@ -60,7 +60,8 @@ public KnnVectorQuery(String field, float[] target,

[jira] [Commented] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434036#comment-17434036 ] David Smiley commented on LUCENE-9660: -- Thanks for reconsidering this.  Rob's argum

[jira] [Commented] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434058#comment-17434058 ] Robert Muir commented on LUCENE-9660: - Yes, thank you [~dweiss]. I understand your a

[jira] [Commented] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434059#comment-17434059 ] Robert Muir commented on LUCENE-9660: - my absolute favorite example was some flaky t

[GitHub] [lucene] apanimesh061 commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-25 Thread GitBox
apanimesh061 commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r736078469 ## File path: lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java ## @@ -638,6 +674,39 @@ protected BreakIterat

[GitHub] [lucene] apanimesh061 commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-25 Thread GitBox
apanimesh061 commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r736079027 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -143,6 +143,91 @@ private int cacheFie

[GitHub] [lucene] apanimesh061 commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-25 Thread GitBox
apanimesh061 commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r736109899 ## File path: lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java ## @@ -460,6 +462,26 @@ public void testBuddh

[GitHub] [lucene] apanimesh061 commented on a change in pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-10-25 Thread GitBox
apanimesh061 commented on a change in pull request #412: URL: https://github.com/apache/lucene/pull/412#discussion_r736110426 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java ## @@ -143,6 +143,106 @@ private int cacheFi

[GitHub] [lucene] dsmiley commented on pull request #411: LUCENE-10202: spatial: feature-variants

2021-10-25 Thread GitBox
dsmiley commented on pull request #411: URL: https://github.com/apache/lucene/pull/411#issuecomment-951533639 Bummer ok. I'll leave this here; not sure if/when I'll get back to it. Sadly the Gradle docs describe no other way to emit your dependencies as optional. -- This is an automat

[jira] [Commented] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434115#comment-17434115 ] Dawid Weiss commented on LUCENE-9660: - Ok, ok. I accept the arguments. It is configu

[jira] [Commented] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434116#comment-17434116 ] Dawid Weiss commented on LUCENE-9660: - Ok, ok. I accept the arguments. It is configu

[GitHub] [lucene] dweiss commented on pull request #411: LUCENE-10202: spatial: feature-variants

2021-10-25 Thread GitBox
dweiss commented on pull request #411: URL: https://github.com/apache/lucene/pull/411#issuecomment-951573527 I didn't want to discourage you from trying - maybe the solution is simple, somewhere. I just recall spending a few hours trying to figure out how to make the POMs sane on another p

[jira] [Commented] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434140#comment-17434140 ] Dawid Weiss commented on LUCENE-9660: - As a side note - the 'cleanX' convention does

[jira] [Comment Edited] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434140#comment-17434140 ] Dawid Weiss edited comment on LUCENE-9660 at 10/26/21, 6:45 AM: --

[jira] [Commented] (LUCENE-9660) gradle task cache should not cache --tests

2021-10-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434141#comment-17434141 ] ASF subversion and git services commented on LUCENE-9660: - Commi