[jira] [Commented] (LUCENE-10130) HnswGraph could make use of a SparseFixedBitSet.getAndSet

2021-09-30 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422556#comment-17422556 ] Adrien Grand commented on LUCENE-10130: --- Thanks Julie for the context. Maybe we c

[jira] [Created] (LUCENE-10134) TestSortedSetDocValuesFacets fails with Bits shared between threads

2021-09-30 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10134: Summary: TestSortedSetDocValuesFacets fails with Bits shared between threads Key: LUCENE-10134 URL: https://issues.apache.org/jira/browse/LUCENE-10134 Project: Lucene

[jira] [Updated] (LUCENE-10134) TestSortedSetDocValuesFacets fails with Bits shared between threads

2021-09-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10134: - Issue Type: Bug (was: Task) > TestSortedSetDocValuesFacets fails with Bits shared between thre

[jira] [Commented] (LUCENE-10134) TestSortedSetDocValuesFacets fails with Bits shared between threads

2021-09-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422564#comment-17422564 ] Dawid Weiss commented on LUCENE-10134: -- I've applied a small change that cleans up

[jira] [Commented] (LUCENE-10125) Investigate indexing throughput regression on NYC Taxis between 2021-04-12 and 2021-05-24

2021-09-30 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422567#comment-17422567 ] Adrien Grand commented on LUCENE-10125: --- One note for the record: even though it

[jira] [Commented] (LUCENE-10134) TestSortedSetDocValuesFacets fails with Bits shared between threads

2021-09-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422568#comment-17422568 ] ASF subversion and git services commented on LUCENE-10134: -- Co

[GitHub] [lucene] uschindler commented on a change in pull request #327: LUCENE-10125: Speed up DirectWriter.

2021-09-30 Thread GitBox
uschindler commented on a change in pull request #327: URL: https://github.com/apache/lucene/pull/327#discussion_r719127442 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java ## @@ -94,38 +91,54 @@ private void flush() throws IOException { }

[GitHub] [lucene] jpountz commented on a change in pull request #327: LUCENE-10125: Speed up DirectWriter.

2021-09-30 Thread GitBox
jpountz commented on a change in pull request #327: URL: https://github.com/apache/lucene/pull/327#discussion_r719130078 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java ## @@ -94,38 +91,54 @@ private void flush() throws IOException { }

[GitHub] [lucene] uschindler commented on a change in pull request #327: LUCENE-10125: Speed up DirectWriter.

2021-09-30 Thread GitBox
uschindler commented on a change in pull request #327: URL: https://github.com/apache/lucene/pull/327#discussion_r719130968 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java ## @@ -94,38 +91,54 @@ private void flush() throws IOException { }

[jira] [Commented] (LUCENE-10130) HnswGraph could make use of a SparseFixedBitSet.getAndSet

2021-09-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422574#comment-17422574 ] Robert Muir commented on LUCENE-10130: -- Given those numbers (20k out of a million)

[jira] [Updated] (LUCENE-10135) Correct passage selector behavior for long matching snippets

2021-09-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10135: - Fix Version/s: main (9.0) > Correct passage selector behavior for long matching snippets >

[jira] [Updated] (LUCENE-10135) Correct passage selector behavior for long matching snippets

2021-09-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10135: - Issue Type: Improvement (was: Task) > Correct passage selector behavior for long matching snip

[jira] [Updated] (LUCENE-10135) Correct passage selector behavior for long matching snippets

2021-09-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10135: - Affects Version/s: (was: main (9.0)) > Correct passage selector behavior for long matching

[jira] [Created] (LUCENE-10135) Correct passage selector behavior for long matching snippets

2021-09-30 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10135: Summary: Correct passage selector behavior for long matching snippets Key: LUCENE-10135 URL: https://issues.apache.org/jira/browse/LUCENE-10135 Project: Lucene - Core

[GitHub] [lucene] uschindler commented on a change in pull request #327: LUCENE-10125: Speed up DirectWriter.

2021-09-30 Thread GitBox
uschindler commented on a change in pull request #327: URL: https://github.com/apache/lucene/pull/327#discussion_r719130968 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java ## @@ -94,38 +91,54 @@ private void flush() throws IOException { }

[jira] [Commented] (LUCENE-10113) Use VarHandles to access int/long/short types in byte arrays (e.g. ByteArrayDataInput)

2021-09-30 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422577#comment-17422577 ] Adrien Grand commented on LUCENE-10113: --- I suspect this change to be the source o

[jira] [Created] (LUCENE-10136) Lift the restriction on using 'var' variables

2021-09-30 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10136: Summary: Lift the restriction on using 'var' variables Key: LUCENE-10136 URL: https://issues.apache.org/jira/browse/LUCENE-10136 Project: Lucene - Core Issue

[GitHub] [lucene] dweiss commented on a change in pull request #334: LUCENE-10135: Correct passage selector behavior for long matching snippets

2021-09-30 Thread GitBox
dweiss commented on a change in pull request #334: URL: https://github.com/apache/lucene/pull/334#discussion_r719145316 ## File path: lucene/highlighter/src/java/org/apache/lucene/search/matchhighlight/PassageSelector.java ## @@ -127,8 +127,8 @@ protected boolean lessThan(Pass

[GitHub] [lucene] uschindler commented on a change in pull request #327: LUCENE-10125: Speed up DirectWriter.

2021-09-30 Thread GitBox
uschindler commented on a change in pull request #327: URL: https://github.com/apache/lucene/pull/327#discussion_r719166524 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java ## @@ -94,38 +91,54 @@ private void flush() throws IOException { }

[GitHub] [lucene] uschindler commented on a change in pull request #327: LUCENE-10125: Speed up DirectWriter.

2021-09-30 Thread GitBox
uschindler commented on a change in pull request #327: URL: https://github.com/apache/lucene/pull/327#discussion_r719166524 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java ## @@ -94,38 +91,54 @@ private void flush() throws IOException { }

[jira] [Created] (LUCENE-10137) Refactor DirectReader and remove heavy code duplication

2021-09-30 Thread Uwe Schindler (Jira)
Uwe Schindler created LUCENE-10137: -- Summary: Refactor DirectReader and remove heavy code duplication Key: LUCENE-10137 URL: https://issues.apache.org/jira/browse/LUCENE-10137 Project: Lucene - Core

[GitHub] [lucene] uschindler opened a new pull request #335: LUCENE-10137: Refactor DirectReader and remove heavy code duplication

2021-09-30 Thread GitBox
uschindler opened a new pull request #335: URL: https://github.com/apache/lucene/pull/335 See https://issues.apache.org/jira/browse/LUCENE-10137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (LUCENE-10137) Refactor DirectReader and remove heavy code duplication

2021-09-30 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422626#comment-17422626 ] Uwe Schindler commented on LUCENE-10137: PR is here: https://github.com/apache/

[jira] [Commented] (LUCENE-10137) Refactor DirectReader and remove heavy code duplication

2021-09-30 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422625#comment-17422625 ] Uwe Schindler commented on LUCENE-10137: I also changed the RuntimeException to

[GitHub] [lucene] romseygeek merged pull request #329: LUCENE-10132: Support addition of diagnostics by custom merge policies

2021-09-30 Thread GitBox
romseygeek merged pull request #329: URL: https://github.com/apache/lucene/pull/329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Commented] (LUCENE-10137) Refactor DirectReader and remove heavy code duplication

2021-09-30 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422633#comment-17422633 ] Uwe Schindler commented on LUCENE-10137: IMHO, LongValues should be a functiona

[GitHub] [lucene] uschindler commented on a change in pull request #327: LUCENE-10125: Speed up DirectWriter.

2021-09-30 Thread GitBox
uschindler commented on a change in pull request #327: URL: https://github.com/apache/lucene/pull/327#discussion_r719199226 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java ## @@ -94,38 +91,54 @@ private void flush() throws IOException { }

[jira] [Created] (LUCENE-10138) Use maven central for gradle plugin repository

2021-09-30 Thread Alan Woodward (Jira)
Alan Woodward created LUCENE-10138: -- Summary: Use maven central for gradle plugin repository Key: LUCENE-10138 URL: https://issues.apache.org/jira/browse/LUCENE-10138 Project: Lucene - Core

[GitHub] [lucene] jpountz commented on pull request #335: LUCENE-10137: Refactor DirectReader and remove heavy code duplication

2021-09-30 Thread GitBox
jpountz commented on pull request #335: URL: https://github.com/apache/lucene/pull/335#issuecomment-931093010 I'm curious what luceneutil will report with this change, the sorting and faceting tasks should give us a good idea of whether there is a slowdown or not. -- This is an automated

[jira] [Commented] (LUCENE-10138) Use maven central for gradle plugin repository

2021-09-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422641#comment-17422641 ] Dawid Weiss commented on LUCENE-10138: -- jcenter is deprecated and should be remove

[jira] [Commented] (LUCENE-8638) Remove deprecated code in main

2021-09-30 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422642#comment-17422642 ] Alan Woodward commented on LUCENE-8638: --- > After that what remains marked as Depre

[jira] [Commented] (LUCENE-10138) Use maven central for gradle plugin repository

2021-09-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422643#comment-17422643 ] Dawid Weiss commented on LUCENE-10138: -- Can you create a PR, Alan, so that I can s

[jira] [Commented] (LUCENE-10138) Use maven central for gradle plugin repository

2021-09-30 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422644#comment-17422644 ] Alan Woodward commented on LUCENE-10138: > jcenter is deprecated and should be

[GitHub] [lucene] uschindler commented on pull request #335: LUCENE-10137: Refactor DirectReader and remove heavy code duplication

2021-09-30 Thread GitBox
uschindler commented on pull request #335: URL: https://github.com/apache/lucene/pull/335#issuecomment-931098148 Actually I will do a perf test in a minute, but the code and call behaviour here is more or less identical to before. Instead of creating the classes in source code we let the J

[jira] [Commented] (LUCENE-10138) Use maven central for gradle plugin repository

2021-09-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422647#comment-17422647 ] Dawid Weiss commented on LUCENE-10138: -- Yup. I think you guys at es have better gr

[GitHub] [lucene] romseygeek opened a new pull request #336: LUCENE-10138: Use maven central to resolve third-party gradle plugins

2021-09-30 Thread GitBox
romseygeek opened a new pull request #336: URL: https://github.com/apache/lucene/pull/336 The gradle plugin portal uses jcenter to resolve third-party plugins, which can be flaky. This commit instructs gradle to look first in maven central, and only use the plugin portal for gradle's

[jira] [Commented] (LUCENE-10138) Use maven central for gradle plugin repository

2021-09-30 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422652#comment-17422652 ] Alan Woodward commented on LUCENE-10138: I opened [https://github.com/apache/lu

[jira] [Updated] (LUCENE-10138) Use maven central for gradle plugin repository

2021-09-30 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-10138: --- Description: By default, the gradle plugin repository downloads its plugins from jcenter. 

[GitHub] [lucene] uschindler commented on pull request #335: LUCENE-10137: Refactor DirectReader and remove heavy code duplication

2021-09-30 Thread GitBox
uschindler commented on pull request #335: URL: https://github.com/apache/lucene/pull/335#issuecomment-931145999 Looks like there's a slowdown with facets. Digging (waiting for CPU profiles)... -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene] ChrisHegarty opened a new pull request #337: LUCENE-10118: Expand the log message when CMS.MergeThread completes its merge operation

2021-09-30 Thread GitBox
ChrisHegarty opened a new pull request #337: URL: https://github.com/apache/lucene/pull/337 # Description Improve merge thread activity logging. # Solution Expand the log message when CMS.MergeThread completes its merge operation, to include addition useful diagnostic i

[GitHub] [lucene] rmuir commented on pull request #335: LUCENE-10137: Refactor DirectReader and remove heavy code duplication

2021-09-30 Thread GitBox
rmuir commented on pull request #335: URL: https://github.com/apache/lucene/pull/335#issuecomment-931194035 where is the "heavy code duplication" ? You still have method to decode for each bit size. But now we made things more complicated for hotspot. -- This is an automated mess

[GitHub] [lucene] romseygeek merged pull request #336: LUCENE-10138: Use maven central to resolve third-party gradle plugins

2021-09-30 Thread GitBox
romseygeek merged pull request #336: URL: https://github.com/apache/lucene/pull/336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Resolved] (LUCENE-10138) Use maven central for gradle plugin repository

2021-09-30 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-10138. Fix Version/s: main (9.0) Assignee: Alan Woodward Resolution: Fixed > Use

[jira] [Commented] (LUCENE-10138) Use maven central for gradle plugin repository

2021-09-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422691#comment-17422691 ] ASF subversion and git services commented on LUCENE-10138: -- Co

[jira] [Commented] (LUCENE-10118) Expand the log message when CMS.MergeThread completes its merge operation

2021-09-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422693#comment-17422693 ] ASF subversion and git services commented on LUCENE-10118: -- Co

[GitHub] [lucene] romseygeek merged pull request #337: LUCENE-10118: Expand the log message when CMS.MergeThread completes its merge operation

2021-09-30 Thread GitBox
romseygeek merged pull request #337: URL: https://github.com/apache/lucene/pull/337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Resolved] (LUCENE-10132) Support addition of diagnostics by custom merge policies

2021-09-30 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-10132. Fix Version/s: main (9.0) Assignee: Alan Woodward Resolution: Fixed > Sup

[GitHub] [lucene] uschindler commented on pull request #335: LUCENE-10137: Refactor DirectReader and remove heavy code duplication

2021-09-30 Thread GitBox
uschindler commented on pull request #335: URL: https://github.com/apache/lucene/pull/335#issuecomment-931255937 Hi, I will close this PR because with JDK 11 it is problematic. I improved the whole thing a bit by changing LongValues to be an interface instead of an abstract class,

[GitHub] [lucene] uschindler closed pull request #335: LUCENE-10137: Refactor DirectReader and remove heavy code duplication

2021-09-30 Thread GitBox
uschindler closed pull request #335: URL: https://github.com/apache/lucene/pull/335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Resolved] (LUCENE-10137) Refactor DirectReader and remove heavy code duplication

2021-09-30 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-10137. Resolution: Won't Fix This seems to be still problematic with Java 11. > Refactor Direct

[GitHub] [lucene] uschindler commented on pull request #335: LUCENE-10137: Refactor DirectReader and remove heavy code duplication

2021-09-30 Thread GitBox
uschindler commented on pull request #335: URL: https://github.com/apache/lucene/pull/335#issuecomment-931258217 FYI, with JDK 18 the other branch works fast, it is just Java 11 that cannot handle this. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [lucene] uschindler edited a comment on pull request #335: LUCENE-10137: Refactor DirectReader and remove heavy code duplication

2021-09-30 Thread GitBox
uschindler edited a comment on pull request #335: URL: https://github.com/apache/lucene/pull/335#issuecomment-931255937 Hi, I will close this PR because with JDK 11 it is problematic. I improved the whole thing a bit by changing LongValues to be an interface instead of an abstract

[GitHub] [lucene] dnhatn commented on a change in pull request #331: LUCENE-10126: Re-introduce chunk scoring logic in tests

2021-09-30 Thread GitBox
dnhatn commented on a change in pull request #331: URL: https://github.com/apache/lucene/pull/331#discussion_r719372028 ## File path: lucene/test-framework/src/java/org/apache/lucene/search/AssertingScorable.java ## @@ -45,13 +45,41 @@ public static Scorable wrap(Scorable in)

[GitHub] [lucene] romseygeek opened a new pull request #338: LUCENE-9325: Make Sort final

2021-09-30 Thread GitBox
romseygeek opened a new pull request #338: URL: https://github.com/apache/lucene/pull/338 Sort is used in all sorts of settings where we assume that it is immutable (for example, in IndexWriterConfig). This commit makes it so, plus it also updates the severely outdated javadoc. --

[jira] [Updated] (LUCENE-8638) Remove deprecated code in main

2021-09-30 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Sokolov updated LUCENE-8638: Priority: Major (was: Blocker) > Remove deprecated code in main > ---

[jira] [Commented] (LUCENE-8638) Remove deprecated code in main

2021-09-30 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422761#comment-17422761 ] Michael Sokolov commented on LUCENE-8638: - > Shall we remove the 'blocker' tag f

[jira] [Commented] (LUCENE-9325) Sort and SortField are not immutable

2021-09-30 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422763#comment-17422763 ] Alan Woodward commented on LUCENE-9325: --- Picking this one up again: I've opened [

[jira] [Resolved] (LUCENE-10135) Correct passage selector behavior for long matching snippets

2021-09-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10135. -- Resolution: Fixed > Correct passage selector behavior for long matching snippets > --

[GitHub] [lucene] dweiss merged pull request #334: LUCENE-10135: Correct passage selector behavior for long matching snippets

2021-09-30 Thread GitBox
dweiss merged pull request #334: URL: https://github.com/apache/lucene/pull/334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (LUCENE-10135) Correct passage selector behavior for long matching snippets

2021-09-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422767#comment-17422767 ] ASF subversion and git services commented on LUCENE-10135: -- Co

[GitHub] [lucene] dweiss merged pull request #339: LUCENE-9713: apply source validation to txt files outside of src/*

2021-09-30 Thread GitBox
dweiss merged pull request #339: URL: https://github.com/apache/lucene/pull/339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Resolved] (LUCENE-9713) Did we lose the UTF-8 BOM detection in lucene/CHANGES.txt in gradle migration?

2021-09-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9713. - Fix Version/s: main (9.0) Resolution: Fixed > Did we lose the UTF-8 BOM detection in luce

[jira] [Commented] (LUCENE-9713) Did we lose the UTF-8 BOM detection in lucene/CHANGES.txt in gradle migration?

2021-09-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422779#comment-17422779 ] ASF subversion and git services commented on LUCENE-9713: - Commi

[jira] [Commented] (LUCENE-9713) Did we lose the UTF-8 BOM detection in lucene/CHANGES.txt in gradle migration?

2021-09-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422782#comment-17422782 ] ASF subversion and git services commented on LUCENE-9713: - Commi

[GitHub] [lucene] uschindler commented on a change in pull request #327: LUCENE-10125: Speed up DirectWriter.

2021-09-30 Thread GitBox
uschindler commented on a change in pull request #327: URL: https://github.com/apache/lucene/pull/327#discussion_r719401059 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java ## @@ -94,38 +91,54 @@ private void flush() throws IOException { }

[GitHub] [lucene] uschindler commented on a change in pull request #327: LUCENE-10125: Speed up DirectWriter.

2021-09-30 Thread GitBox
uschindler commented on a change in pull request #327: URL: https://github.com/apache/lucene/pull/327#discussion_r719401321 ## File path: lucene/core/src/java/org/apache/lucene/util/packed/DirectWriter.java ## @@ -94,38 +91,54 @@ private void flush() throws IOException { }

[jira] [Commented] (LUCENE-9713) Did we lose the UTF-8 BOM detection in lucene/CHANGES.txt in gradle migration?

2021-09-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422785#comment-17422785 ] ASF subversion and git services commented on LUCENE-9713: - Commi

[jira] [Created] (LUCENE-10139) ExternalRefSorter should return a covariant with a subtype of BytesRefIterator that is Closeable

2021-09-30 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10139: Summary: ExternalRefSorter should return a covariant with a subtype of BytesRefIterator that is Closeable Key: LUCENE-10139 URL: https://issues.apache.org/jira/browse/LUCENE-1013

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #331: LUCENE-10126: Re-introduce chunk scoring logic in tests

2021-09-30 Thread GitBox
mayya-sharipova commented on a change in pull request #331: URL: https://github.com/apache/lucene/pull/331#discussion_r719451602 ## File path: lucene/test-framework/src/java/org/apache/lucene/search/AssertingScorable.java ## @@ -45,13 +45,41 @@ public static Scorable wrap(Scor

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

2021-09-30 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422815#comment-17422815 ] Michael McCandless commented on LUCENE-8739: Wow, these are compelling resul

[jira] [Assigned] (LUCENE-9809) Adapt Release Wizard to only release Lucene

2021-09-30 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned LUCENE-9809: --- Assignee: Jan Høydahl > Adapt Release Wizard to only release Lucene > -

[jira] [Created] (LUCENE-10140) Minimizing intervals can give inaccurate positions for duplicate terms

2021-09-30 Thread Nikolay Khitrin (Jira)
Nikolay Khitrin created LUCENE-10140: Summary: Minimizing intervals can give inaccurate positions for duplicate terms Key: LUCENE-10140 URL: https://issues.apache.org/jira/browse/LUCENE-10140 Proj

[GitHub] [lucene] dnhatn commented on a change in pull request #331: LUCENE-10126: Re-introduce chunk scoring logic in tests

2021-09-30 Thread GitBox
dnhatn commented on a change in pull request #331: URL: https://github.com/apache/lucene/pull/331#discussion_r719480931 ## File path: lucene/test-framework/src/java/org/apache/lucene/search/AssertingScorable.java ## @@ -45,13 +45,41 @@ public static Scorable wrap(Scorable in)

[jira] [Commented] (LUCENE-10140) Minimizing intervals can give inaccurate positions for duplicate terms

2021-09-30 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422822#comment-17422822 ] Alan Woodward commented on LUCENE-10140: I wonder if we can be cleverer about r

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #331: LUCENE-10126: Re-introduce chunk scoring logic in tests

2021-09-30 Thread GitBox
mayya-sharipova commented on a change in pull request #331: URL: https://github.com/apache/lucene/pull/331#discussion_r719487400 ## File path: lucene/test-framework/src/java/org/apache/lucene/search/AssertingBulkScorer.java ## @@ -80,8 +80,23 @@ public int score(LeafCollector

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #331: LUCENE-10126: Re-introduce chunk scoring logic in tests

2021-09-30 Thread GitBox
mayya-sharipova commented on a change in pull request #331: URL: https://github.com/apache/lucene/pull/331#discussion_r719487400 ## File path: lucene/test-framework/src/java/org/apache/lucene/search/AssertingBulkScorer.java ## @@ -80,8 +80,23 @@ public int score(LeafCollector

[GitHub] [lucene] khitrin opened a new pull request #341: LUCENE-10140: Non-heuristic intervals sub-matches caching

2021-09-30 Thread GitBox
khitrin opened a new pull request #341: URL: https://github.com/apache/lucene/pull/341 # Description Minimizing intervals (maybe just ORDERED and AT_LEAST, but not sure) can move sub iterators to non-sub-match position inside match window, but CachingMatchesIterator logic re

[GitHub] [lucene] khitrin commented on pull request #270: LUCENE-10075: Hotfix for overlapping wildcard-based intervals

2021-09-30 Thread GitBox
khitrin commented on pull request #270: URL: https://github.com/apache/lucene/pull/270#issuecomment-931400123 Superseded by #341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [lucene] khitrin closed pull request #270: LUCENE-10075: Hotfix for overlapping wildcard-based intervals

2021-09-30 Thread GitBox
khitrin closed pull request #270: URL: https://github.com/apache/lucene/pull/270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene] khitrin commented on pull request #341: LUCENE-10140: Non-heuristic intervals sub-matches caching

2021-09-30 Thread GitBox
khitrin commented on pull request #341: URL: https://github.com/apache/lucene/pull/341#issuecomment-931411794 @romseygeek , could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Commented] (LUCENE-10140) Minimizing intervals can give inaccurate positions for duplicate terms

2021-09-30 Thread Nikolay Khitrin (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422853#comment-17422853 ] Nikolay Khitrin commented on LUCENE-10140: -- I'm afraid, it will not cover comp

[GitHub] [lucene] thelabdude opened a new pull request #342: Add next minor version 8.10

2021-09-30 Thread GitBox
thelabdude opened a new pull request #342: URL: https://github.com/apache/lucene/pull/342 Missed task when doing 8.10 release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [lucene] danmuzi commented on a change in pull request #338: LUCENE-9325: Make Sort final

2021-09-30 Thread GitBox
danmuzi commented on a change in pull request #338: URL: https://github.com/apache/lucene/pull/338#discussion_r719541562 ## File path: lucene/core/src/java/org/apache/lucene/search/Sort.java ## @@ -108,20 +55,6 @@ public Sort() { /** Sorts by the criteria in the given Sort

[GitHub] [lucene] dnhatn commented on a change in pull request #331: LUCENE-10126: Re-introduce chunk scoring logic in tests

2021-09-30 Thread GitBox
dnhatn commented on a change in pull request #331: URL: https://github.com/apache/lucene/pull/331#discussion_r719548306 ## File path: lucene/test-framework/src/java/org/apache/lucene/search/AssertingBulkScorer.java ## @@ -80,8 +80,23 @@ public int score(LeafCollector collector

[GitHub] [lucene] thelabdude commented on pull request #342: Add next minor version 8.10

2021-09-30 Thread GitBox
thelabdude commented on pull request #342: URL: https://github.com/apache/lucene/pull/342#issuecomment-931453670 trying to fix 10131 too, so closing this and will re-open from a proper branch -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [lucene] thelabdude closed pull request #342: Add next minor version 8.10

2021-09-30 Thread GitBox
thelabdude closed pull request #342: URL: https://github.com/apache/lucene/pull/342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #331: LUCENE-10126: Re-introduce chunk scoring logic in tests

2021-09-30 Thread GitBox
mayya-sharipova commented on a change in pull request #331: URL: https://github.com/apache/lucene/pull/331#discussion_r719549902 ## File path: lucene/test-framework/src/java/org/apache/lucene/search/AssertingBulkScorer.java ## @@ -80,8 +80,23 @@ public int score(LeafCollector

[GitHub] [lucene] thelabdude opened a new pull request #343: LUCENE-10131: Add backcompat indices for 8.10 and add LUCENE_8_10_0 to Version

2021-09-30 Thread GitBox
thelabdude opened a new pull request #343: URL: https://github.com/apache/lucene/pull/343 Manually fixing up some steps missed during the 8.10 release process. I don't think this is correct because 8.10 is not listed in the `oldNames` array in `TestBackwardsCompatibility`. Somebody w

[jira] [Commented] (LUCENE-9983) Stop sorting determinize powersets unnecessarily

2021-09-30 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422937#comment-17422937 ] Haoyu Zhai commented on LUCENE-9983: [~mikemccand] yes we can close it. But it seems

[GitHub] [lucene] madrob commented on a change in pull request #343: LUCENE-10131: Add backcompat indices for 8.10 and add LUCENE_8_10_0 to Version

2021-09-30 Thread GitBox
madrob commented on a change in pull request #343: URL: https://github.com/apache/lucene/pull/343#discussion_r719652888 ## File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java ## @@ -685,7 +686,7 @@ public void testAllVers

[GitHub] [lucene] janhoy opened a new pull request #344: LUCENE-9809 Adapt Release Wizard to only release Lucene

2021-09-30 Thread GitBox
janhoy opened a new pull request #344: URL: https://github.com/apache/lucene/pull/344 https://issues.apache.org/jira/browse/LUCENE-9809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [lucene] thelabdude commented on a change in pull request #343: LUCENE-10131: Add backcompat indices for 8.10 and add LUCENE_8_10_0 to Version

2021-09-30 Thread GitBox
thelabdude commented on a change in pull request #343: URL: https://github.com/apache/lucene/pull/343#discussion_r719661346 ## File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java ## @@ -383,6 +383,7 @@ public void testCre

[jira] [Commented] (LUCENE-9809) Adapt Release Wizard to only release Lucene

2021-09-30 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422969#comment-17422969 ] Jan Høydahl commented on LUCENE-9809: - I prepared [https://github.com/apache/lucene/

[GitHub] [lucene] janhoy commented on pull request #344: LUCENE-9809 Adapt Release Wizard to only release Lucene

2021-09-30 Thread GitBox
janhoy commented on pull request #344: URL: https://github.com/apache/lucene/pull/344#issuecomment-931566819 Feel free to add commits to this PR if/when you spot more things that needs fixing (including the entire scripts folder) -- This is an automated message from the Apache Git Servic

[jira] [Commented] (LUCENE-10080) Use a bit set to count long-tail of singleton FacetLabels?

2021-09-30 Thread Marc D'Mello (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422976#comment-17422976 ] Marc D'Mello commented on LUCENE-10080: --- Hi [~gsmiller], I looked into it some mo

[jira] [Updated] (LUCENE-10134) TestSortedSetDocValuesFacets fails with Bits shared between threads

2021-09-30 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller updated LUCENE-10134: - Component/s: modules/facet > TestSortedSetDocValuesFacets fails with Bits shared between thread

[jira] [Commented] (LUCENE-9488) Update release process to work with Gradle.

2021-09-30 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422982#comment-17422982 ] Jan Høydahl commented on LUCENE-9488: - Mike, I'm currently updating releaseWizard in

[jira] [Commented] (LUCENE-9488) Update release process to work with Gradle.

2021-09-30 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422990#comment-17422990 ] Mike Drob commented on LUCENE-9488: --- I think [~hossman] did some work in the gpg signi

[GitHub] [lucene] dnhatn commented on a change in pull request #331: LUCENE-10126: Re-introduce chunk scoring logic in tests

2021-09-30 Thread GitBox
dnhatn commented on a change in pull request #331: URL: https://github.com/apache/lucene/pull/331#discussion_r719709277 ## File path: lucene/test-framework/src/java/org/apache/lucene/search/AssertingBulkScorer.java ## @@ -80,8 +80,23 @@ public int score(LeafCollector collector

[GitHub] [lucene] madrob commented on a change in pull request #343: LUCENE-10131: Add backcompat indices for 8.10 and add LUCENE_8_10_0 to Version

2021-09-30 Thread GitBox
madrob commented on a change in pull request #343: URL: https://github.com/apache/lucene/pull/343#discussion_r719728206 ## File path: lucene/core/src/java/org/apache/lucene/util/Version.java ## @@ -168,6 +168,13 @@ */ @Deprecated public static final Version LUCENE_8_9_0

  1   2   >