[GitHub] [lucene-solr] dweiss commented on a change in pull request #2575: LUCENE-10107

2021-09-17 Thread GitBox
dweiss commented on a change in pull request #2575: URL: https://github.com/apache/lucene-solr/pull/2575#discussion_r710821986 ## File path: dev-tools/scripts/smokeTestRelease.py ## @@ -1223,7 +1223,7 @@ def run_java(cmd, logfile): return jc(run_java8, java8_home, run_java9,

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2575: LUCENE-10107

2021-09-17 Thread GitBox
dweiss commented on a change in pull request #2575: URL: https://github.com/apache/lucene-solr/pull/2575#discussion_r710825164 ## File path: lucene/common-build.xml ## @@ -764,7 +764,7 @@ - + Review comment: I think it could als

[GitHub] [lucene] mocobeta commented on a change in pull request #297: LUCENE-10102: Add JapaneseCompletionFilter for Input Method-aware auto-completion

2021-09-17 Thread GitBox
mocobeta commented on a change in pull request #297: URL: https://github.com/apache/lucene/pull/297#discussion_r710900222 ## File path: lucene/analysis/kuromoji/src/resources/org/apache/lucene/analysis/ja/completion/romaji_map.txt ## @@ -0,0 +1,344 @@ +# mapping rules of katak

[GitHub] [lucene] mocobeta commented on a change in pull request #297: LUCENE-10102: Add JapaneseCompletionFilter for Input Method-aware auto-completion

2021-09-17 Thread GitBox
mocobeta commented on a change in pull request #297: URL: https://github.com/apache/lucene/pull/297#discussion_r710900222 ## File path: lucene/analysis/kuromoji/src/resources/org/apache/lucene/analysis/ja/completion/romaji_map.txt ## @@ -0,0 +1,344 @@ +# mapping rules of katak

[GitHub] [lucene] msokolov commented on pull request #299: LUCENE-8638: Expressions haversin() method should continue to return its value in km

2021-09-17 Thread GitBox
msokolov commented on pull request #299: URL: https://github.com/apache/lucene/pull/299#issuecomment-921755143 Thanks for fixing! This is indeed better than changing the behavior of an existing function. I was away and missed the excitement here. -- This is an automated message from the

[GitHub] [lucene] mocobeta merged pull request #297: LUCENE-10102: Add JapaneseCompletionFilter for Input Method-aware auto-completion

2021-09-17 Thread GitBox
mocobeta merged pull request #297: URL: https://github.com/apache/lucene/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (LUCENE-10102) Add JapaneseCompletionFilter for Input Method-aware auto-completion

2021-09-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416694#comment-17416694 ] ASF subversion and git services commented on LUCENE-10102: -- Co

[jira] [Resolved] (LUCENE-10102) Add JapaneseCompletionFilter for Input Method-aware auto-completion

2021-09-17 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-10102. Fix Version/s: main (9.0) Resolution: Fixed > Add JapaneseCompletionFilter for Inp

[GitHub] [lucene] cpoerschke opened a new pull request #305: LUCENE-9809: replace 'master' with 'main' in release wizard

2021-09-17 Thread GitBox
cpoerschke opened a new pull request #305: URL: https://github.com/apache/lucene/pull/305 https://issues.apache.org/jira/browse/LUCENE-9809 add-link-here is for `solr/main` branch equivalent, i tried having one `lucene-solr/branch_8x` commit and cherry-picking back to `lucene/main` a

[GitHub] [lucene] gsmiller merged pull request #293: Lucene-10070: Skip deleted documents during facet counting for all do…

2021-09-17 Thread GitBox
gsmiller merged pull request #293: URL: https://github.com/apache/lucene/pull/293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [lucene] gsmiller commented on pull request #293: Lucene-10070: Skip deleted documents during facet counting for all do…

2021-09-17 Thread GitBox
gsmiller commented on pull request #293: URL: https://github.com/apache/lucene/pull/293#issuecomment-921966795 Merged. Thanks @goankur ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Commented] (LUCENE-10070) "count all" faceting functionality counts deleted docs for multiple implementations

2021-09-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416829#comment-17416829 ] ASF subversion and git services commented on LUCENE-10070: -- Co

[GitHub] [lucene] gsmiller commented on pull request #282: Lucene-10070

2021-09-17 Thread GitBox
gsmiller commented on pull request #282: URL: https://github.com/apache/lucene/pull/282#issuecomment-921968655 @goankur this can be closed out now right since you opened a separate PR for this change? There's nothing else remaining on this one is there? Thanks again! -- This is an automa

[GitHub] [lucene] gsmiller closed pull request #263: [nocommit] LUCENE-10070: Add tests to show the 'count all' faceting bugs

2021-09-17 Thread GitBox
gsmiller closed pull request #263: URL: https://github.com/apache/lucene/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [lucene-solr] madrob commented on pull request #2575: LUCENE-10107

2021-09-17 Thread GitBox
madrob commented on pull request #2575: URL: https://github.com/apache/lucene-solr/pull/2575#issuecomment-922053220 This worked for me on macOS but I'd like somebody else to try this with Windows or Linux before we merge? -- This is an automated message from the Apache Git Service. To re

[jira] [Resolved] (LUCENE-9647) Add back ant precommit on PR for branch 8

2021-09-17 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved LUCENE-9647. --- Resolution: Duplicate This was fixed somewhere along the way. > Add back ant precommit on PR for br

[GitHub] [lucene-solr] gsmiller opened a new pull request #2577: LUCENE-10070: Skip deleted documents during facet counting for all documents

2021-09-17 Thread GitBox
gsmiller opened a new pull request #2577: URL: https://github.com/apache/lucene-solr/pull/2577 Backport from `main` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [lucene-solr] gsmiller commented on pull request #2577: LUCENE-10070: Skip deleted documents during facet counting for all documents

2021-09-17 Thread GitBox
gsmiller commented on pull request #2577: URL: https://github.com/apache/lucene-solr/pull/2577#issuecomment-922085560 @goankur could you please take a quick look and make sure this backport looks good to you? Everything was very trivial except for `LongValueFacetCounts`. Even that was pret

[GitHub] [lucene-solr] gsmiller commented on pull request #2577: LUCENE-10070: Skip deleted documents during facet counting for all documents

2021-09-17 Thread GitBox
gsmiller commented on pull request #2577: URL: https://github.com/apache/lucene-solr/pull/2577#issuecomment-922123533 FYI, will hold on this backport until 8.10 releases and an 8.11 section is added to CHANGES as part of that process (this will go in 8.11) -- This is an automated message

[jira] [Commented] (LUCENE-10099) Add -Ptests.asyncprofile option.

2021-09-17 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416975#comment-17416975 ] Mark Robert Miller commented on LUCENE-10099: - Okay, this actually seems to

[jira] [Updated] (LUCENE-10099) Add -Ptests.asyncprofile option.

2021-09-17 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Robert Miller updated LUCENE-10099: Description: Allow async profiler in addition to the JFR profiler. async profile

[jira] [Updated] (LUCENE-10099) Add -Ptests.asyncprofile option.

2021-09-17 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Robert Miller updated LUCENE-10099: Description: Allow async profiler in addition to the JFR profiler. async profile

[jira] [Updated] (LUCENE-10099) Add -Ptests.asyncprofile option.

2021-09-17 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Robert Miller updated LUCENE-10099: Description: Allow async-profiler in addition to the JFR profiler. async profile

[jira] [Updated] (LUCENE-10099) Add -Ptests.asyncprofile option.

2021-09-17 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Robert Miller updated LUCENE-10099: Description: Allow async-profiler in addition to the JFR profiler. async profile

[jira] [Commented] (LUCENE-10102) Add JapaneseCompletionFilter for Input Method-aware auto-completion

2021-09-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417025#comment-17417025 ] ASF subversion and git services commented on LUCENE-10102: -- Co

[jira] [Created] (LUCENE-10111) Missing calculating the BytesUsed of DocsWithFieldSet in NormValuesWriter

2021-09-17 Thread Lu Xugang (Jira)
Lu Xugang created LUCENE-10111: -- Summary: Missing calculating the BytesUsed of DocsWithFieldSet in NormValuesWriter Key: LUCENE-10111 URL: https://issues.apache.org/jira/browse/LUCENE-10111 Project: Luce

[jira] [Updated] (LUCENE-10111) Missing calculating the bytes used of DocsWithFieldSet in NormValuesWriter

2021-09-17 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lu Xugang updated LUCENE-10111: --- Summary: Missing calculating the bytes used of DocsWithFieldSet in NormValuesWriter (was: Missing

[GitHub] [lucene] LuXugang opened a new pull request #306: LUCENE-10111: Missing calculating the bytes used of DocsWithFieldSet in NormValuesWriter

2021-09-17 Thread GitBox
LuXugang opened a new pull request #306: URL: https://github.com/apache/lucene/pull/306 Basing on the implement of updateBytesUsed() in SortedDocValuesWriter and the other DocValuesWriters, it seems to lack of calculating the BytesUsed of DocsWithFieldSet in NormValuesWriter? -- Thi