[GitHub] [lucene] dweiss commented on pull request #269: LUCENE-9654: Expressions module gramar antlr code regeneration

2021-08-27 Thread GitBox
dweiss commented on pull request #269: URL: https://github.com/apache/lucene/pull/269#issuecomment-906977581 This implements antlr regeneration and checksumming. I left unused imports in (since it's generated code anyway) and applied spotless formatting (for the same reason) - these are th

[jira] [Updated] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-08-27 Thread weizijun (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weizijun updated LUCENE-10033: -- Attachment: benchmark-10m > Encode doc values in smaller blocks of values, like postings > --

[jira] [Commented] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-08-27 Thread weizijun (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405670#comment-17405670 ] weizijun commented on LUCENE-10033: --- hi, [~gsmiller] . Here is the wikimedium10m resu

[GitHub] [lucene] dweiss merged pull request #269: LUCENE-9654: Expressions module gramar antlr code regeneration

2021-08-27 Thread GitBox
dweiss merged pull request #269: URL: https://github.com/apache/lucene/pull/269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (LUCENE-9654) Expressions module gramar antlr code regeneration missing

2021-08-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405740#comment-17405740 ] ASF subversion and git services commented on LUCENE-9654: - Commi

[jira] [Resolved] (LUCENE-9654) Expressions module gramar antlr code regeneration missing

2021-08-27 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9654. - Fix Version/s: main (9.0) Resolution: Fixed > Expressions module gramar antlr code regene

[jira] [Created] (LUCENE-10075) NPE on wildcard-based overlapping intervals highlighting

2021-08-27 Thread Nikolay Khitrin (Jira)
Nikolay Khitrin created LUCENE-10075: Summary: NPE on wildcard-based overlapping intervals highlighting Key: LUCENE-10075 URL: https://issues.apache.org/jira/browse/LUCENE-10075 Project: Lucene - C

[jira] [Commented] (LUCENE-10073) Allow very small merges to merge more than segmentsPerTier segments?

2021-08-27 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405780#comment-17405780 ] Michael McCandless commented on LUCENE-10073: - +1, I think that makes sense

[jira] [Commented] (LUCENE-10074) Remove unneeded default value assignment

2021-08-27 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405787#comment-17405787 ] Michael McCandless commented on LUCENE-10074: - This is maybe controversial,

[jira] [Commented] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-08-27 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405826#comment-17405826 ] Greg Miller commented on LUCENE-10033: -- [~jpountz] I realized yesterday that the b

[GitHub] [lucene] mikemccand commented on a change in pull request #266: LUCENE-10073: Reduce merging overhead of NRT by using a greater mergeFactor on tiny segments.

2021-08-27 Thread GitBox
mikemccand commented on a change in pull request #266: URL: https://github.com/apache/lucene/pull/266#discussion_r697495033 ## File path: lucene/core/src/java/org/apache/lucene/index/TieredMergePolicy.java ## @@ -495,36 +495,36 @@ private MergeSpecification doFindMerges(

[GitHub] [lucene] mikemccand commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-27 Thread GitBox
mikemccand commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r697508778 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,140 @@ public FacetLabel g

[GitHub] [lucene] mikemccand commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-27 Thread GitBox
mikemccand commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r697510650 ## File path: lucene/CHANGES.txt ## @@ -137,6 +137,9 @@ API Changes Improvements +* LUCENE-9476: Add new getBulkPath API to DirectoryTaxonomyReader t

[GitHub] [lucene] mikemccand commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-27 Thread GitBox
mikemccand commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r697513953 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyReader.java ## @@ -212,6 +212,19 @@ public int getOrdinal(String dim, String

[GitHub] [lucene] khitrin opened a new pull request #270: LUCENE-10075: Hotfix for overlapping wildcard-based intervals

2021-08-27 Thread GitBox
khitrin opened a new pull request #270: URL: https://github.com/apache/lucene/pull/270 # Description Intervals matching iterator with wildcards and gaps for now throws NPE when highlighting overlapping wildcard-based intervals. Minimal reproducible example is highlighting "Compare Com

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-27 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r697584332 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestDirectoryTaxonomyReader.java ## @@ -567,4 +567,78 @@ public void te

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-27 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r697599711 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,140 @@ public FacetLabe

[jira] [Commented] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-08-27 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405944#comment-17405944 ] Greg Miller commented on LUCENE-10033: -- [~weizijun] thanks for providing the updat

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-27 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r697620977 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -351,12 +348,140 @@ public FacetLabe

[GitHub] [lucene] gautamworah96 commented on a change in pull request #179: LUCENE-9476: Add getBulkPath API to DirectoryTaxonomyReader

2021-08-27 Thread GitBox
gautamworah96 commented on a change in pull request #179: URL: https://github.com/apache/lucene/pull/179#discussion_r697622283 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestDirectoryTaxonomyReader.java ## @@ -567,4 +567,78 @@ public void te

[jira] [Commented] (LUCENE-10074) Remove unneeded default value assignment

2021-08-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405971#comment-17405971 ] Robert Muir commented on LUCENE-10074: -- I looked thru the checks, don't think such

[jira] [Commented] (LUCENE-10074) Remove unneeded default value assignment

2021-08-27 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405980#comment-17405980 ] Dawid Weiss commented on LUCENE-10074: -- I actually had to check whether it's not o

[GitHub] [lucene] gsmiller commented on a change in pull request #240: LUCENE-10002: Deprecate IndexSearch#search(Query, Collector) in favor of IndexSearcher#search(Query, CollectorManager)

2021-08-27 Thread GitBox
gsmiller commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r697667815 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollectorManager.java ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software F

[jira] [Commented] (LUCENE-10074) Remove unneeded default value assignment

2021-08-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406038#comment-17406038 ] Robert Muir commented on LUCENE-10074: -- Well that's just what javac does. if it is

[jira] [Commented] (LUCENE-10074) Remove unneeded default value assignment

2021-08-27 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406043#comment-17406043 ] Uwe Schindler commented on LUCENE-10074: I agree with Robert. In general, I pre

[GitHub] [lucene] gautamworah96 commented on a change in pull request #242: LUCENE-9620 Add Weight#count(LeafReaderContext)

2021-08-27 Thread GitBox
gautamworah96 commented on a change in pull request #242: URL: https://github.com/apache/lucene/pull/242#discussion_r697759445 ## File path: lucene/core/src/java/org/apache/lucene/search/TermQuery.java ## @@ -179,6 +179,15 @@ public Explanation explain(LeafReaderContext context

[GitHub] [lucene] JavaCoderCff opened a new pull request #271: LUCENE-9969:TaxoArrays, a member variable of the DirectoryTaxonomyReader class, i…

2021-08-27 Thread GitBox
JavaCoderCff opened a new pull request #271: URL: https://github.com/apache/lucene/pull/271 https://issues.apache.org/jira/browse/LUCENE-9969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (LUCENE-10074) Remove unneeded default value assignment

2021-08-27 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406125#comment-17406125 ] Dawid Weiss commented on LUCENE-10074: -- Oh, I don't think it matters that much at

[GitHub] [lucene] dweiss commented on pull request #271: LUCENE-9969:TaxoArrays, a member variable of the DirectoryTaxonomyReader class, i…

2021-08-27 Thread GitBox
dweiss commented on pull request #271: URL: https://github.com/apache/lucene/pull/271#issuecomment-907578312 Just a note from the side (I'm not familiar with this code): somehow I don't believe switching to a soft reference here is solving anything - it just shoves the problem under the ru