[GitHub] [lucene] jpountz opened a new pull request #223: LUCENE-10015: Make VectorSimilarityFunction a codec parameter.

2021-07-22 Thread GitBox
jpountz opened a new pull request #223: URL: https://github.com/apache/lucene/pull/223 VectorSimilarityFunction moves to the `org.apache.lucene.util.hnsw` package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Commented] (LUCENE-10015) Remove VectorValues.SimilarityFunction, remove NONE

2021-07-22 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385377#comment-17385377 ] Adrien Grand commented on LUCENE-10015: --- Thanks Tomoko. I opened a PR to see how

[jira] [Commented] (LUCENE-10015) Remove VectorValues.SimilarityFunction, remove NONE

2021-07-22 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385408#comment-17385408 ] Julie Tibshirani commented on LUCENE-10015: --- I think it makes sense to keep t

[GitHub] [lucene] jpountz commented on a change in pull request #222: LUCENE-10032: Remove leafDocMaps from MergeState

2021-07-22 Thread GitBox
jpountz commented on a change in pull request #222: URL: https://github.com/apache/lucene/pull/222#discussion_r674713006 ## File path: lucene/core/src/java/org/apache/lucene/index/MergeState.java ## @@ -227,19 +222,7 @@ public int get(int docID) { } private List maybeSo

[jira] [Commented] (LUCENE-10015) Remove VectorValues.SimilarityFunction, remove NONE

2021-07-22 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385463#comment-17385463 ] Adrien Grand commented on LUCENE-10015: --- If there's agreement we should keep the

[GitHub] [lucene] dnhatn commented on a change in pull request #222: LUCENE-10032: Remove leafDocMaps from MergeState

2021-07-22 Thread GitBox
dnhatn commented on a change in pull request #222: URL: https://github.com/apache/lucene/pull/222#discussion_r674773365 ## File path: lucene/core/src/java/org/apache/lucene/index/MergeState.java ## @@ -227,19 +222,7 @@ public int get(int docID) { } private List maybeSor

[jira] [Commented] (LUCENE-10015) Remove VectorValues.SimilarityFunction, remove NONE

2021-07-22 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385488#comment-17385488 ] Tomoko Uchida commented on LUCENE-10015: I am fine with the current field API,

[jira] [Comment Edited] (LUCENE-10015) Remove VectorValues.SimilarityFunction, remove NONE

2021-07-22 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385488#comment-17385488 ] Tomoko Uchida edited comment on LUCENE-10015 at 7/22/21, 1:15 PM: ---

[jira] [Commented] (LUCENE-10015) Remove VectorValues.SimilarityFunction, remove NONE

2021-07-22 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385546#comment-17385546 ] Michael Sokolov commented on LUCENE-10015: -- Yes, let's keep the similarity fun

[GitHub] [lucene] msokolov commented on a change in pull request #218: LUCENE-9855: Rename knn search vector format

2021-07-22 Thread GitBox
msokolov commented on a change in pull request #218: URL: https://github.com/apache/lucene/pull/218#discussion_r674861123 ## File path: lucene/CHANGES.txt ## @@ -7,7 +7,7 @@ http://s.apache.org/luceneversions New Features -* LUCENE-9322: Vector-valued fields, Lucene90 Code

[jira] [Resolved] (LUCENE-10015) Remove VectorValues.SimilarityFunction, remove NONE

2021-07-22 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10015. --- Resolution: Fixed > Remove VectorValues.SimilarityFunction, remove NONE > -

[jira] [Updated] (LUCENE-10015) Remove VectorValues.SimilarityFunction.NONE

2021-07-22 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-10015: -- Summary: Remove VectorValues.SimilarityFunction.NONE (was: Remove VectorValues.SimilarityFun

[GitHub] [lucene] jpountz closed pull request #223: LUCENE-10015: Make VectorSimilarityFunction a codec parameter.

2021-07-22 Thread GitBox
jpountz closed pull request #223: URL: https://github.com/apache/lucene/pull/223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene] mocobeta commented on a change in pull request #218: LUCENE-9855: Rename knn search vector format

2021-07-22 Thread GitBox
mocobeta commented on a change in pull request #218: URL: https://github.com/apache/lucene/pull/218#discussion_r674908384 ## File path: lucene/CHANGES.txt ## @@ -7,7 +7,7 @@ http://s.apache.org/luceneversions New Features -* LUCENE-9322: Vector-valued fields, Lucene90 Code

[GitHub] [lucene] mocobeta commented on a change in pull request #218: LUCENE-9855: Rename knn search vector format

2021-07-22 Thread GitBox
mocobeta commented on a change in pull request #218: URL: https://github.com/apache/lucene/pull/218#discussion_r674908384 ## File path: lucene/CHANGES.txt ## @@ -7,7 +7,7 @@ http://s.apache.org/luceneversions New Features -* LUCENE-9322: Vector-valued fields, Lucene90 Code

[GitHub] [lucene] dnhatn commented on a change in pull request #221: LUCENE-10031: Speed up SortedDocIdMerger on low-cardinality sort fields.

2021-07-22 Thread GitBox
dnhatn commented on a change in pull request #221: URL: https://github.com/apache/lucene/pull/221#discussion_r674914345 ## File path: lucene/core/src/java/org/apache/lucene/index/DocIDMerger.java ## @@ -144,59 +159,45 @@ protected boolean lessThan(Sub a, Sub b) { public vo

[GitHub] [lucene] dnhatn commented on a change in pull request #221: LUCENE-10031: Speed up SortedDocIdMerger on low-cardinality sort fields.

2021-07-22 Thread GitBox
dnhatn commented on a change in pull request #221: URL: https://github.com/apache/lucene/pull/221#discussion_r674914345 ## File path: lucene/core/src/java/org/apache/lucene/index/DocIDMerger.java ## @@ -144,59 +159,45 @@ protected boolean lessThan(Sub a, Sub b) { public vo

[jira] [Commented] (LUCENE-9450) Taxonomy index should use DocValues not StoredFields

2021-07-22 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385612#comment-17385612 ] Michael McCandless commented on LUCENE-9450: OK, +1 for Scenario 2 (use inde

[GitHub] [lucene-solr] cpoerschke merged pull request #2514: Fix some psuedo->pseudo typos in Solr Ref Guide.

2021-07-22 Thread GitBox
cpoerschke merged pull request #2514: URL: https://github.com/apache/lucene-solr/pull/2514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [lucene] jpountz commented on a change in pull request #221: LUCENE-10031: Speed up SortedDocIdMerger on low-cardinality sort fields.

2021-07-22 Thread GitBox
jpountz commented on a change in pull request #221: URL: https://github.com/apache/lucene/pull/221#discussion_r674980048 ## File path: lucene/core/src/java/org/apache/lucene/index/DocIDMerger.java ## @@ -144,59 +159,45 @@ protected boolean lessThan(Sub a, Sub b) { public v

[GitHub] [lucene] dnhatn commented on a change in pull request #221: LUCENE-10031: Speed up SortedDocIdMerger on low-cardinality sort fields.

2021-07-22 Thread GitBox
dnhatn commented on a change in pull request #221: URL: https://github.com/apache/lucene/pull/221#discussion_r674984362 ## File path: lucene/core/src/java/org/apache/lucene/index/DocIDMerger.java ## @@ -144,59 +159,45 @@ protected boolean lessThan(Sub a, Sub b) { public vo

[jira] [Created] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-07-22 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10033: - Summary: Encode doc values in smaller blocks of values, like postings Key: LUCENE-10033 URL: https://issues.apache.org/jira/browse/LUCENE-10033 Project: Lucene - Co

[GitHub] [lucene] gsmiller commented on a change in pull request #217: LUCENE-10030: [DrillSidewaysScorer.doQueryFirstScoring] disable scoring for near-miss hits

2021-07-22 Thread GitBox
gsmiller commented on a change in pull request #217: URL: https://github.com/apache/lucene/pull/217#discussion_r675059243 ## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java ## @@ -195,11 +195,8 @@ private void doQueryFirstScoring(Bits acceptDo

[GitHub] [lucene] msokolov commented on a change in pull request #218: LUCENE-9855: Rename knn search vector format

2021-07-22 Thread GitBox
msokolov commented on a change in pull request #218: URL: https://github.com/apache/lucene/pull/218#discussion_r675162465 ## File path: lucene/CHANGES.txt ## @@ -7,7 +7,7 @@ http://s.apache.org/luceneversions New Features -* LUCENE-9322: Vector-valued fields, Lucene90 Code

[GitHub] [lucene] mocobeta commented on pull request #218: LUCENE-9855: Rename knn search vector format

2021-07-22 Thread GitBox
mocobeta commented on pull request #218: URL: https://github.com/apache/lucene/pull/218#issuecomment-885343046 Thanks, @msokolov for your comment. I'll wait for feedback from others (if there are further suggestions) for a while before merging. -- This is an automated message from the

[GitHub] [lucene] gsmiller merged pull request #196: LUCENE-10000: Make MultiCollectorManager consistent with MultiCollector

2021-07-22 Thread GitBox
gsmiller merged pull request #196: URL: https://github.com/apache/lucene/pull/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (LUCENE-10000) MultiCollectorManager should have parity with MultiCollector behavior

2021-07-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385845#comment-17385845 ] ASF subversion and git services commented on LUCENE-1: -- Co

[GitHub] [lucene] gsmiller commented on pull request #196: LUCENE-10000: Make MultiCollectorManager consistent with MultiCollector

2021-07-22 Thread GitBox
gsmiller commented on pull request #196: URL: https://github.com/apache/lucene/pull/196#issuecomment-885353122 > Thanks for fixing this! Sure. Thanks for the feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Updated] (LUCENE-10000) MultiCollectorManager should have parity with MultiCollector behavior

2021-07-22 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller updated LUCENE-1: - Fix Version/s: main (9.0) > MultiCollectorManager should have parity with MultiCollector behavi

[jira] [Resolved] (LUCENE-10000) MultiCollectorManager should have parity with MultiCollector behavior

2021-07-22 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-1. -- Resolution: Fixed > MultiCollectorManager should have parity with MultiCollector behavior > -