[GitHub] [lucene] mocobeta commented on a change in pull request #207: LUCENE-9855: Rename nn search vector format

mocobeta commented on a change in pull request #207: URL: https://github.com/apache/lucene/pull/207#discussion_r667338802 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -2284,28 +2284,28 @@ static void checkImpacts(Impacts impacts, int lastTar

[GitHub] [lucene] mocobeta commented on a change in pull request #207: LUCENE-9855: Rename nn search vector format

mocobeta commented on a change in pull request #207: URL: https://github.com/apache/lucene/pull/207#discussion_r667338807 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -2284,28 +2284,28 @@ static void checkImpacts(Impacts impacts, int lastTar

[GitHub] [lucene] mocobeta commented on a change in pull request #207: LUCENE-9855: Rename nn search vector format

mocobeta commented on a change in pull request #207: URL: https://github.com/apache/lucene/pull/207#discussion_r667339213 ## File path: lucene/CHANGES.txt ## @@ -7,7 +7,7 @@ http://s.apache.org/luceneversions New Features -* LUCENE-9322: Vector-valued fields, Lucene90 Code

[GitHub] [lucene] mocobeta commented on pull request #207: LUCENE-9855: Rename nn search vector format

mocobeta commented on pull request #207: URL: https://github.com/apache/lucene/pull/207#issuecomment-877639170 Thanks @msokolov for reviewing. I'll wait for a few more days to let others give comments on this then merge it to the upstream if there is no another feedback. -- This is an a

[GitHub] [lucene] msokolov opened a new pull request #210: LUCENE-10016: remove fanout parameter from nearest neighbor vector search

msokolov opened a new pull request #210: URL: https://github.com/apache/lucene/pull/210 I think we can remove this parameter to simplify the nn search api and make it more generic. For the HNSW algorithm, searching for top K=M and fanout=N is basically the same as searching with top K=M+N

[jira] [Commented] (LUCENE-10016) VectorReader.search needs rethought, o.a.l.search integration?

[ https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378489#comment-17378489 ] Michael Sokolov commented on LUCENE-10016: -- I posted a PR removing fanout. For

[jira] [Commented] (LUCENE-9614) Implement KNN Query

[ https://issues.apache.org/jira/browse/LUCENE-9614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378497#comment-17378497 ] Michael Sokolov commented on LUCENE-9614: - Doing nn vector search during rewrite

[jira] [Comment Edited] (LUCENE-9614) Implement KNN Query

[ https://issues.apache.org/jira/browse/LUCENE-9614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378497#comment-17378497 ] Michael Sokolov edited comment on LUCENE-9614 at 7/10/21, 5:03 PM: ---

[GitHub] [lucene] zacharymorn commented on pull request #180: LUCENE-9959: Add non thread local based API for term vector reader usage

zacharymorn commented on pull request #180: URL: https://github.com/apache/lucene/pull/180#issuecomment-877676142 > Yes; javadocs will need to warn people. This is _already_ a trap, not a new one. The method `org.apache.lucene.index.IndexReader#getTermVector` is tempting but can be bad for

[GitHub] [lucene] cpoerschke commented on pull request #201: LUCENE-8638: remove deprecated FixBrokenOffsetsFilter[Factory] classes

cpoerschke commented on pull request #201: URL: https://github.com/apache/lucene/pull/201#issuecomment-877708925 Thanks @msokolov for copying across the comments from the JIRA! I'll convert the pull request to "draft" to indicate the status of the deprecation process. -- This is an autom

[GitHub] [lucene] cpoerschke commented on pull request #202: LUCENE-8682: remove deprecated WordDelimiterFilter[Factory] classes

cpoerschke commented on pull request #202: URL: https://github.com/apache/lucene/pull/202#issuecomment-877709067 Thanks @msokolov for copying across the comments from the JIRA! I'll convert the pull request to "draft" to indicate the status of the deprecation process. -- This is an autom

[GitHub] [lucene-solr] madrob merged pull request #2531: SOLR-15526 Use new cluster for each LeaderTragicEvent test

madrob merged pull request #2531: URL: https://github.com/apache/lucene-solr/pull/2531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu