[GitHub] [lucene] jpountz commented on a change in pull request #140: LUCENE-9935: Enable bulk-merge for term vectors with index sort

2021-06-10 Thread GitBox
jpountz commented on a change in pull request #140: URL: https://github.com/apache/lucene/pull/140#discussion_r648908154 ## File path: lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java ## @@ -667,43 +673,94 @@ public void testRandom() th

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2512: LUCENE-9976: Fix WANDScorer assertion error

2021-06-10 Thread GitBox
zacharymorn commented on a change in pull request #2512: URL: https://github.com/apache/lucene-solr/pull/2512#discussion_r648919401 ## File path: lucene/CHANGES.txt ## @@ -54,7 +54,7 @@ Bug Fixes Other - -(No changes) +* LUCENE-9976: Fix WANDScorer asser

[GitHub] [lucene-solr] zacharymorn merged pull request #2512: LUCENE-9976: Fix WANDScorer assertion error

2021-06-10 Thread GitBox
zacharymorn merged pull request #2512: URL: https://github.com/apache/lucene-solr/pull/2512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [lucene-solr] zacharymorn merged pull request #2511: LUCENE-9976: Fix WANDScorer assertion error

2021-06-10 Thread GitBox
zacharymorn merged pull request #2511: URL: https://github.com/apache/lucene-solr/pull/2511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[jira] [Commented] (LUCENE-9976) WANDScorer assertion error in ensureConsistent

2021-06-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360620#comment-17360620 ] ASF subversion and git services commented on LUCENE-9976: - Commi

[jira] [Commented] (LUCENE-9976) WANDScorer assertion error in ensureConsistent

2021-06-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360619#comment-17360619 ] ASF subversion and git services commented on LUCENE-9976: - Commi

[jira] [Commented] (LUCENE-9204) Move span queries to the queries module

2021-06-10 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360638#comment-17360638 ] Alan Woodward commented on LUCENE-9204: --- +1 to adding some benchmarks - in particu

[jira] [Resolved] (LUCENE-3321) Move spans out of core

2021-06-10 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-3321. --- Resolution: Fixed Resolved by LUCENE-9204 > Move spans out of core > --

[GitHub] [lucene] dweiss opened a new pull request #178: LUCENE-9977: rat task corrections (proper up-to-date checks, cleanup and rewrite of the task itself).

2021-06-10 Thread GitBox
dweiss opened a new pull request #178: URL: https://github.com/apache/lucene/pull/178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [lucene] dweiss commented on a change in pull request #178: LUCENE-9977: rat task corrections (proper up-to-date checks, cleanup and rewrite of the task itself).

2021-06-10 Thread GitBox
dweiss commented on a change in pull request #178: URL: https://github.com/apache/lucene/pull/178#discussion_r648973848 ## File path: gradle/validation/rat-sources.gradle ## @@ -27,139 +28,122 @@ configure(rootProject) { } } +// Configure the rat validation task and all

[jira] [Commented] (LUCENE-9995) JDK17 generates wbr tags which make javadocs checker angry

2021-06-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360659#comment-17360659 ] ASF subversion and git services commented on LUCENE-9995: - Commi

[jira] [Commented] (LUCENE-9995) JDK17 generates wbr tags which make javadocs checker angry

2021-06-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360660#comment-17360660 ] Dawid Weiss commented on LUCENE-9995: - Applied the same fix to 8x and Solr. > JDK17

[GitHub] [lucene] rmuir commented on a change in pull request #178: LUCENE-9977: rat task corrections (proper up-to-date checks, cleanup and rewrite of the task itself).

2021-06-10 Thread GitBox
rmuir commented on a change in pull request #178: URL: https://github.com/apache/lucene/pull/178#discussion_r649072881 ## File path: .github/PULL_REQUEST_TEMPLATE.md ## @@ -1,3 +1,20 @@ + + Review comment: do we want this license going into every PR description by defau

[GitHub] [lucene] dweiss commented on a change in pull request #178: LUCENE-9977: rat task corrections (proper up-to-date checks, cleanup and rewrite of the task itself).

2021-06-10 Thread GitBox
dweiss commented on a change in pull request #178: URL: https://github.com/apache/lucene/pull/178#discussion_r649092605 ## File path: .github/PULL_REQUEST_TEMPLATE.md ## @@ -1,3 +1,20 @@ + + Review comment: Sorry, I was too dumb at updating the offenders. I think we can

[GitHub] [lucene] uschindler commented on a change in pull request #178: LUCENE-9977: rat task corrections (proper up-to-date checks, cleanup and rewrite of the task itself).

2021-06-10 Thread GitBox
uschindler commented on a change in pull request #178: URL: https://github.com/apache/lucene/pull/178#discussion_r649140811 ## File path: gradle/validation/rat-sources.gradle ## @@ -27,139 +28,125 @@ configure(rootProject) { } } +// Configure the rat validation task and

[GitHub] [lucene] uschindler commented on a change in pull request #178: LUCENE-9977: rat task corrections (proper up-to-date checks, cleanup and rewrite of the task itself).

2021-06-10 Thread GitBox
uschindler commented on a change in pull request #178: URL: https://github.com/apache/lucene/pull/178#discussion_r649145401 ## File path: gradle/validation/rat-sources.gradle ## @@ -74,6 +74,9 @@ allprojects { exclude ".idea" exclude ".

[GitHub] [lucene] dweiss commented on a change in pull request #178: LUCENE-9977: rat task corrections (proper up-to-date checks, cleanup and rewrite of the task itself).

2021-06-10 Thread GitBox
dweiss commented on a change in pull request #178: URL: https://github.com/apache/lucene/pull/178#discussion_r649162120 ## File path: gradle/validation/rat-sources.gradle ## @@ -27,139 +28,125 @@ configure(rootProject) { } } +// Configure the rat validation task and all

[GitHub] [lucene] dweiss commented on a change in pull request #178: LUCENE-9977: rat task corrections (proper up-to-date checks, cleanup and rewrite of the task itself).

2021-06-10 Thread GitBox
dweiss commented on a change in pull request #178: URL: https://github.com/apache/lucene/pull/178#discussion_r649163037 ## File path: gradle/validation/rat-sources.gradle ## @@ -74,6 +74,9 @@ allprojects { exclude ".idea" exclude ".muse

[GitHub] [lucene] dnhatn commented on a change in pull request #140: LUCENE-9935: Enable bulk-merge for term vectors with index sort

2021-06-10 Thread GitBox
dnhatn commented on a change in pull request #140: URL: https://github.com/apache/lucene/pull/140#discussion_r649215227 ## File path: lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java ## @@ -667,43 +673,94 @@ public void testRandom() thr

[GitHub] [lucene] jpountz commented on a change in pull request #140: LUCENE-9935: Enable bulk-merge for term vectors with index sort

2021-06-10 Thread GitBox
jpountz commented on a change in pull request #140: URL: https://github.com/apache/lucene/pull/140#discussion_r649248079 ## File path: lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java ## @@ -667,43 +673,94 @@ public void testRandom() th

[GitHub] [lucene] dnhatn merged pull request #140: LUCENE-9935: Enable bulk-merge for term vectors with index sort

2021-06-10 Thread GitBox
dnhatn merged pull request #140: URL: https://github.com/apache/lucene/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[jira] [Commented] (LUCENE-9935) Bulk merges for stored fields when index sorting is enabled

2021-06-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360996#comment-17360996 ] ASF subversion and git services commented on LUCENE-9935: - Commi

[GitHub] [lucene] dnhatn commented on pull request #140: LUCENE-9935: Enable bulk-merge for term vectors with index sort

2021-06-10 Thread GitBox
dnhatn commented on pull request #140: URL: https://github.com/apache/lucene/pull/140#issuecomment-858701554 @jpountz Thank you :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Commented] (LUCENE-9935) Bulk merges for stored fields when index sorting is enabled

2021-06-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17361043#comment-17361043 ] ASF subversion and git services commented on LUCENE-9935: - Commi

[GitHub] [lucene] dnhatn commented on a change in pull request #140: LUCENE-9935: Enable bulk-merge for term vectors with index sort

2021-06-10 Thread GitBox
dnhatn commented on a change in pull request #140: URL: https://github.com/apache/lucene/pull/140#discussion_r649215227 ## File path: lucene/test-framework/src/java/org/apache/lucene/index/BaseTermVectorsFormatTestCase.java ## @@ -667,43 +673,94 @@ public void testRandom() thr

[GitHub] [lucene] MarcusSorealheis commented on pull request #173: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) Panama APIs (>= JDK-16-ea-b32)

2021-06-10 Thread GitBox
MarcusSorealheis commented on pull request #173: URL: https://github.com/apache/lucene/pull/173#issuecomment-859080425 I know this is early days but want to clarify: Is the plan to work on this and #177 in parallel until we know which is the more sustainable option, or abandon this

[jira] [Created] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-06-10 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9997: --- Summary: Revisit smoketester for 9.0 build Key: LUCENE-9997 URL: https://issues.apache.org/jira/browse/LUCENE-9997 Project: Lucene - Core Issue Type: Task