[GitHub] [lucene] gsmiller commented on pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-24 Thread GitBox
gsmiller commented on pull request #127: URL: https://github.com/apache/lucene/pull/127#issuecomment-847051886 @rmuir just a friendly reminder this is still open whenever you have some time. Still no rush, just making sure it didn't slip through the cracks. Thanks again! -- This is an a

[jira] [Commented] (LUCENE-9204) Move span queries to the queries module

2021-05-24 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350443#comment-17350443 ] Michael McCandless commented on LUCENE-9204: +1 to move span queries to quer

[GitHub] [lucene] mikemccand commented on pull request #148: Make ConjunctionDISI package-private and add ConjunctionUtils factory class

2021-05-24 Thread GitBox
mikemccand commented on pull request #148: URL: https://github.com/apache/lucene/pull/148#issuecomment-847071325 +1 to this change -- looks great! But: > refactors Spans to use their own copy of ConjunctionDISI it looks like you didn't have to do this (fork / make a full copy

[jira] [Commented] (LUCENE-9968) Change forceMergeMBPerSec to 10 but iostat show bigger than 10MB/s

2021-05-24 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350447#comment-17350447 ] Michael McCandless commented on LUCENE-9968: OK, hmm, a couple ideas: If I

[jira] [Commented] (LUCENE-9967) ReplicaNode.start NPE on exception with no message

2021-05-24 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350456#comment-17350456 ] Michael McCandless commented on LUCENE-9967: Whoa, thank you for the fix [~s

[GitHub] [lucene] romseygeek commented on pull request #148: Make ConjunctionDISI package-private and add ConjunctionUtils factory class

2021-05-24 Thread GitBox
romseygeek commented on pull request #148: URL: https://github.com/apache/lucene/pull/148#issuecomment-847079159 > It looks like spans just also use the new (public) ConjunctionUtils, which provide (safe) public access to the package-private ConjunctionDISI? Unfortunately no, if we d

[jira] [Resolved] (LUCENE-9968) Change forceMergeMBPerSec to 10 but iostat show bigger than 10MB/s

2021-05-24 Thread jiarun.yang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jiarun.yang resolved LUCENE-9968. - Resolution: Fixed > Change forceMergeMBPerSec to 10 but iostat show bigger than 10MB/s > ---

[jira] [Commented] (LUCENE-9966) SynonymGraphFilter cannot consume a graph token stream

2021-05-24 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350466#comment-17350466 ] Michael McCandless commented on LUCENE-9966: Thanks [~Geoffrey Lawson]!  Big

[jira] [Commented] (LUCENE-9967) ReplicaNode.start NPE on exception with no message

2021-05-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350473#comment-17350473 ] ASF subversion and git services commented on LUCENE-9967: - Commi

[GitHub] [lucene] romseygeek commented on pull request #148: Make ConjunctionDISI package-private and add ConjunctionUtils factory class

2021-05-24 Thread GitBox
romseygeek commented on pull request #148: URL: https://github.com/apache/lucene/pull/148#issuecomment-847103146 We need to add three more methods to `ConjunctionUtils` but it does mean that we can remove the specialised Spans class, so I think it's a win. It should also be possible to re

[GitHub] [lucene] romseygeek commented on pull request #148: Make ConjunctionDISI package-private and add ConjunctionUtils factory class

2021-05-24 Thread GitBox
romseygeek commented on pull request #148: URL: https://github.com/apache/lucene/pull/148#issuecomment-847116630 I've pushed the intervals change as well, turns out it's very simple and allows us to remove more duplication. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (LUCENE-9967) ReplicaNode.start NPE on exception with no message

2021-05-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350495#comment-17350495 ] ASF subversion and git services commented on LUCENE-9967: - Commi

[jira] [Updated] (LUCENE-9967) ReplicaNode.start NPE on exception with no message

2021-05-24 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-9967: --- Fix Version/s: 8.9 Resolution: Fixed Status: Resolved (was: Patch

[jira] [Commented] (LUCENE-9967) ReplicaNode.start NPE on exception with no message

2021-05-24 Thread Steven Schlansker (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350515#comment-17350515 ] Steven Schlansker commented on LUCENE-9967: --- Awesome!  Happy to help.  Thanks

[jira] [Commented] (LUCENE-9967) ReplicaNode.start NPE on exception with no message

2021-05-24 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350535#comment-17350535 ] Michael McCandless commented on LUCENE-9967: {quote} I agree the code isn't

[GitHub] [lucene] mikemccand commented on pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-24 Thread GitBox
mikemccand commented on pull request #127: URL: https://github.com/apache/lucene/pull/127#issuecomment-847216192 This change looks awesome! First class support for tricky multi-valued long/double range facet counting! I understand the need for per-hit rollup in the multi-valued case

[GitHub] [lucene] mikemccand commented on pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-24 Thread GitBox
mikemccand commented on pull request #127: URL: https://github.com/apache/lucene/pull/127#issuecomment-847236610 > but are we also doing that per-hit rollup for the single valued case (for code simplicity)? Aha! It looks like we still only rollup "in the end" (of each segment) for

[GitHub] [lucene] mikemccand commented on a change in pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-24 Thread GitBox
mikemccand commented on a change in pull request #127: URL: https://github.com/apache/lucene/pull/127#discussion_r638127417 ## File path: lucene/facet/src/java/org/apache/lucene/facet/range/OverlappingLongRangeCounter.java ## @@ -0,0 +1,364 @@ +/* + * Licensed to the Apache So

[jira] [Commented] (LUCENE-9969) DirectoryTaxonomyReader.taxoArray占用内存较大导致系统OOM宕机

2021-05-24 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350589#comment-17350589 ] Gautam Worah commented on LUCENE-9969: -- If I understand things correctly from Googl

[GitHub] [lucene] gsmiller commented on a change in pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-24 Thread GitBox
gsmiller commented on a change in pull request #127: URL: https://github.com/apache/lucene/pull/127#discussion_r638244889 ## File path: lucene/facet/src/java/org/apache/lucene/facet/range/OverlappingLongRangeCounter.java ## @@ -0,0 +1,364 @@ +/* + * Licensed to the Apache Soft

[GitHub] [lucene] gsmiller commented on a change in pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-24 Thread GitBox
gsmiller commented on a change in pull request #127: URL: https://github.com/apache/lucene/pull/127#discussion_r638246848 ## File path: lucene/facet/src/java/org/apache/lucene/facet/range/LongRangeCounter.java ## @@ -148,170 +90,139 @@ public void add(long v) { // are gua

[GitHub] [lucene] gsmiller commented on a change in pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-24 Thread GitBox
gsmiller commented on a change in pull request #127: URL: https://github.com/apache/lucene/pull/127#discussion_r638247788 ## File path: lucene/facet/src/java/org/apache/lucene/facet/range/LongRangeCounter.java ## @@ -16,122 +16,64 @@ */ package org.apache.lucene.facet.range

[GitHub] [lucene] gsmiller commented on a change in pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-24 Thread GitBox
gsmiller commented on a change in pull request #127: URL: https://github.com/apache/lucene/pull/127#discussion_r638250252 ## File path: lucene/facet/src/java/org/apache/lucene/facet/range/OverlappingLongRangeCounter.java ## @@ -0,0 +1,364 @@ +/* + * Licensed to the Apache Soft

[GitHub] [lucene] gsmiller commented on a change in pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-24 Thread GitBox
gsmiller commented on a change in pull request #127: URL: https://github.com/apache/lucene/pull/127#discussion_r638250840 ## File path: lucene/facet/src/java/org/apache/lucene/facet/range/SimpleLongRangeCounter.java ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] gsmiller commented on a change in pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-24 Thread GitBox
gsmiller commented on a change in pull request #127: URL: https://github.com/apache/lucene/pull/127#discussion_r638251032 ## File path: lucene/facet/src/java/org/apache/lucene/facet/range/SimpleLongRangeCounter.java ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] gsmiller commented on a change in pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-24 Thread GitBox
gsmiller commented on a change in pull request #127: URL: https://github.com/apache/lucene/pull/127#discussion_r638251217 ## File path: lucene/facet/src/java/org/apache/lucene/facet/range/SimpleLongRangeCounter.java ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] gsmiller commented on a change in pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-24 Thread GitBox
gsmiller commented on a change in pull request #127: URL: https://github.com/apache/lucene/pull/127#discussion_r638252232 ## File path: lucene/facet/src/java/org/apache/lucene/facet/range/SimpleLongRangeCounter.java ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] gsmiller commented on a change in pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-24 Thread GitBox
gsmiller commented on a change in pull request #127: URL: https://github.com/apache/lucene/pull/127#discussion_r638254763 ## File path: lucene/facet/src/java/org/apache/lucene/facet/range/OverlappingLongRangeCounter.java ## @@ -0,0 +1,364 @@ +/* + * Licensed to the Apache Soft

[GitHub] [lucene] gsmiller commented on pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-24 Thread GitBox
gsmiller commented on pull request #127: URL: https://github.com/apache/lucene/pull/127#issuecomment-847398425 Thanks for the feedback @mikemccand! Posted a new revision to address feedback, primarily around naming consistency (using "elementary interval" instead of "leaf" or "elementary s

[jira] [Created] (LUCENE-9970) provide apps details about why TooManyClauses was thrown

2021-05-24 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created LUCENE-9970: -- Summary: provide apps details about why TooManyClauses was thrown Key: LUCENE-9970 URL: https://issues.apache.org/jira/browse/LUCENE-9970 Project: Lucene -

[jira] [Commented] (LUCENE-9970) provide apps details about why TooManyClauses was thrown

2021-05-24 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350698#comment-17350698 ] Chris M. Hostetter commented on LUCENE-9970: The simplest approach would pr

[jira] [Created] (LUCENE-9971) SortedSetDocValuesFacetCounts throws exception in case of unseen dimension (unlike other Facet implementations)

2021-05-24 Thread Alexander L (Jira)
Alexander L created LUCENE-9971: --- Summary: SortedSetDocValuesFacetCounts throws exception in case of unseen dimension (unlike other Facet implementations) Key: LUCENE-9971 URL: https://issues.apache.org/jira/browse/

[jira] [Updated] (LUCENE-9971) SortedSetDocValuesFacetCounts throws exception in case of unseen dimension (unlike other Facet implementations)

2021-05-24 Thread Alexander L (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander L updated LUCENE-9971: Description: Unlike other org.apache.lucene.facet.Facet interface implementations,  SortedSetDocVa

[GitHub] [lucene] sqshq opened a new pull request #149: LUCENE-9971: SortedSetDocValuesFacetCounts throws exception in case of unseen dimension (unlike other Facet implementations)

2021-05-24 Thread GitBox
sqshq opened a new pull request #149: URL: https://github.com/apache/lucene/pull/149 # Description Unlike other `org.apache.lucene.facet.Facet` interface implementations, `SortedSetDocValuesFacetCounts` and `ConcurrentSortedSetDocValuesFacetCounts` throw an exception in

[jira] [Updated] (LUCENE-9971) SortedSetDocValuesFacetCounts throws exception in case of unseen dimension (unlike other Facet implementations)

2021-05-24 Thread Alexander L (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander L updated LUCENE-9971: Status: Patch Available (was: Open) > SortedSetDocValuesFacetCounts throws exception in case of u

[jira] [Created] (LUCENE-9972) Performance regression in NRTCachingDirectory

2021-05-24 Thread Markus Gietzen (Jira)
Markus Gietzen created LUCENE-9972: -- Summary: Performance regression in NRTCachingDirectory Key: LUCENE-9972 URL: https://issues.apache.org/jira/browse/LUCENE-9972 Project: Lucene - Core Iss

[jira] [Updated] (LUCENE-9972) Performance regression in NRTCachingDirectory

2021-05-24 Thread Markus Gietzen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Markus Gietzen updated LUCENE-9972: --- Description: This issue has been discussed here: [http://mail-archives.apache.org/mod_mbox/