[GitHub] [lucene] glawson0 commented on a change in pull request #146: LUCENE-9963 Add tests for alternate path failures in FlattenGraphFilter

2021-05-20 Thread GitBox
glawson0 commented on a change in pull request #146: URL: https://github.com/apache/lucene/pull/146#discussion_r635828761 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestFlattenGraphFilter.java ## @@ -314,5 +314,116 @@ public void testTwoLongP

[GitHub] [lucene] dnhatn commented on pull request #147: LUCENE-9827: Update backward codec in Lucene 9.0

2021-05-20 Thread GitBox
dnhatn commented on pull request #147: URL: https://github.com/apache/lucene/pull/147#issuecomment-845083840 @jpountz Thanks for reviewing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [lucene] dnhatn merged pull request #147: LUCENE-9827: Update backward codec in Lucene 9.0

2021-05-20 Thread GitBox
dnhatn merged pull request #147: URL: https://github.com/apache/lucene/pull/147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-05-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348500#comment-17348500 ] ASF subversion and git services commented on LUCENE-9827: - Commi

[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-05-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348499#comment-17348499 ] ASF subversion and git services commented on LUCENE-9827: - Commi

[jira] [Commented] (LUCENE-9935) Bulk merges for stored fields when index sorting is enabled

2021-05-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348501#comment-17348501 ] ASF subversion and git services commented on LUCENE-9935: - Commi

[GitHub] [lucene] jdconrad commented on pull request #144: LUCENE-9965: Add tooling to introspect query execution time

2021-05-20 Thread GitBox
jdconrad commented on pull request #144: URL: https://github.com/apache/lucene/pull/144#issuecomment-845152558 @jpountz @jtibshirani Thank you for the feedback! I will address these soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene] jdconrad commented on a change in pull request #144: LUCENE-9965: Add tooling to introspect query execution time

2021-05-20 Thread GitBox
jdconrad commented on a change in pull request #144: URL: https://github.com/apache/lucene/pull/144#discussion_r636262712 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/queries/profile/ProfileResult.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Softw

[GitHub] [lucene] jdconrad commented on a change in pull request #144: LUCENE-9965: Add tooling to introspect query execution time

2021-05-20 Thread GitBox
jdconrad commented on a change in pull request #144: URL: https://github.com/apache/lucene/pull/144#discussion_r636263687 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/queries/profile/AbstractProfileBreakdown.java ## @@ -0,0 +1,76 @@ +/* + * Licensed to the A

[GitHub] [lucene] jdconrad commented on a change in pull request #144: LUCENE-9965: Add tooling to introspect query execution time

2021-05-20 Thread GitBox
jdconrad commented on a change in pull request #144: URL: https://github.com/apache/lucene/pull/144#discussion_r636264078 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/queries/profile/AbstractProfileBreakdown.java ## @@ -0,0 +1,76 @@ +/* + * Licensed to the A

[GitHub] [lucene] jdconrad commented on a change in pull request #144: LUCENE-9965: Add tooling to introspect query execution time

2021-05-20 Thread GitBox
jdconrad commented on a change in pull request #144: URL: https://github.com/apache/lucene/pull/144#discussion_r636391311 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/queries/profile/AbstractInternalProfileTree.java ## @@ -0,0 +1,185 @@ +/* + * Licensed to t

[GitHub] [lucene] jdconrad commented on a change in pull request #144: LUCENE-9965: Add tooling to introspect query execution time

2021-05-20 Thread GitBox
jdconrad commented on a change in pull request #144: URL: https://github.com/apache/lucene/pull/144#discussion_r636392294 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/queries/profile/AbstractInternalProfileTree.java ## @@ -0,0 +1,185 @@ +/* + * Licensed to t

[GitHub] [lucene] jdconrad commented on a change in pull request #144: LUCENE-9965: Add tooling to introspect query execution time

2021-05-20 Thread GitBox
jdconrad commented on a change in pull request #144: URL: https://github.com/apache/lucene/pull/144#discussion_r636392637 ## File path: lucene/sandbox/src/test/org/apache/lucene/sandbox/queries/profile/TestProfileQuery.java ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache S

[GitHub] [lucene-solr] thelabdude opened a new pull request #2498: SOLR-15399: IndexFetcher should not issue a local commit for PULL replicas when leader's version is zero

2021-05-20 Thread GitBox
thelabdude opened a new pull request #2498: URL: https://github.com/apache/lucene-solr/pull/2498 Backport from main, see: https://github.com/apache/solr/commit/c731873aef43e81224caafdf02a1ba2f3b3a99e7 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene-solr] thelabdude merged pull request #2498: SOLR-15399: IndexFetcher should not issue a local commit for PULL replicas when leader's version is zero

2021-05-20 Thread GitBox
thelabdude merged pull request #2498: URL: https://github.com/apache/lucene-solr/pull/2498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [lucene] jdconrad commented on a change in pull request #144: LUCENE-9965: Add tooling to introspect query execution time

2021-05-20 Thread GitBox
jdconrad commented on a change in pull request #144: URL: https://github.com/apache/lucene/pull/144#discussion_r636442384 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/queries/profile/ProfileIndexSearcher.java ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apach

[GitHub] [lucene] jdconrad commented on pull request #144: LUCENE-9965: Add tooling to introspect query execution time

2021-05-20 Thread GitBox
jdconrad commented on pull request #144: URL: https://github.com/apache/lucene/pull/144#issuecomment-845452957 Just a note that these comments are still valid and not really outdated. I changed packages and renamed some of the files so it's no longer referencing the correct path. -- Thi