dweiss commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r625549585
##
File path: gradle/validation/jar-checks.gradle
##
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums, validateJar
tflobbe opened a new pull request #2488:
URL: https://github.com/apache/lucene-solr/pull/2488
Just a draft for now, no tests or performance numbers.
For 8.x only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Christoph Kaser created LUCENE-9951:
---
Summary: Add an InfoStream to ReplicationService to facilitate
debugging
Key: LUCENE-9951
URL: https://issues.apache.org/jira/browse/LUCENE-9951
Project: Lucene
ChristophKaser opened a new pull request #124:
URL: https://github.com/apache/lucene/pull/124
An InfoStream is added to the ReplicationService (similar to the
ReplicationClient) to allow debugging replication issues
# Description
Adds InfoStream to ReplicationServi
[
https://issues.apache.org/jira/browse/LUCENE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338845#comment-17338845
]
Ignacio Vera commented on LUCENE-9334:
--
I had a look and I see the problem with the
muse-dev[bot] commented on a change in pull request #124:
URL: https://github.com/apache/lucene/pull/124#discussion_r625612737
##
File path:
lucene/replicator/src/java/org/apache/lucene/replicator/http/ReplicationService.java
##
@@ -183,6 +203,17 @@ public void perform(HttpSer
[
https://issues.apache.org/jira/browse/LUCENE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338864#comment-17338864
]
Ignacio Vera commented on LUCENE-9334:
--
The test assumes there will be no merges in
muse-dev[bot] commented on a change in pull request #124:
URL: https://github.com/apache/lucene/pull/124#discussion_r625635306
##
File path:
lucene/replicator/src/java/org/apache/lucene/replicator/http/ReplicationService.java
##
@@ -183,6 +203,17 @@ public void perform(HttpSer
ChristophKaser commented on a change in pull request #124:
URL: https://github.com/apache/lucene/pull/124#discussion_r625635261
##
File path:
lucene/replicator/src/java/org/apache/lucene/replicator/http/ReplicationService.java
##
@@ -183,6 +203,17 @@ public void perform(HttpSe
[
https://issues.apache.org/jira/browse/LUCENE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338891#comment-17338891
]
Dawid Weiss commented on LUCENE-9334:
-
I think that's a good first step - I don't kn
mayya-sharipova opened a new pull request #125:
URL: https://github.com/apache/lucene/pull/125
This test assumes that there is no merging,
and was failing when there were merges.
This fixes the test but setting NoMergePolicy for
IndexWriter.
Relates to #11
--
This is an au
[
https://issues.apache.org/jira/browse/LUCENE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338908#comment-17338908
]
Mayya Sharipova commented on LUCENE-9334:
-
[~dweiss] Thanks for raising the fail
[
https://issues.apache.org/jira/browse/LUCENE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338908#comment-17338908
]
Mayya Sharipova edited comment on LUCENE-9334 at 5/4/21, 10:50 AM:
---
msokolov commented on pull request #114:
URL: https://github.com/apache/lucene/pull/114#issuecomment-831919682
no comments here it seems; Anyway, we're really just moving the deck chairs
around to be more future-extensible; I'll take the silence as consensus and
merge later today.
--
Th
mayya-sharipova merged pull request #125:
URL: https://github.com/apache/lucene/pull/125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
[
https://issues.apache.org/jira/browse/LUCENE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339005#comment-17339005
]
ASF subversion and git services commented on LUCENE-9334:
-
Commi
rmuir commented on a change in pull request #114:
URL: https://github.com/apache/lucene/pull/114#discussion_r625823163
##
File path:
lucene/core/src/resources/META-INF/services/org.apache.lucene.codecs.VectorFormat
##
@@ -0,0 +1,33 @@
+#
+# Licensed to the Apache Software Foun
rmuir commented on pull request #114:
URL: https://github.com/apache/lucene/pull/114#issuecomment-831983465
is the plan to do a separate followup to break out euclidean and dot product
into codec parameter and remove from FieldInfo? as these are hnsw-specific
parameters, they really belong
jpountz commented on a change in pull request #114:
URL: https://github.com/apache/lucene/pull/114#discussion_r625821205
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorFormat.java
##
@@ -77,7 +77,9 @@
static final int VERSION_CURRENT
[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339052#comment-17339052
]
Adrien Grand commented on LUCENE-9843:
--
The patch looks good. This makes me wonder
[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339084#comment-17339084
]
Robert Muir commented on LUCENE-9843:
-
+1 let's simplify and have better test covera
[
https://issues.apache.org/jira/browse/LUCENE-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339165#comment-17339165
]
ASF subversion and git services commented on LUCENE-9936:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter resolved LUCENE-9936.
Fix Version/s: main (9.0)
Resolution: Fixed
> update gradle build to suppor
jpountz commented on a change in pull request #101:
URL: https://github.com/apache/lucene/pull/101#discussion_r625979068
##
File path:
lucene/core/src/java/org/apache/lucene/search/BlockMaxMaxscoreScorer.java
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundat
[
https://issues.apache.org/jira/browse/LUCENE-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339187#comment-17339187
]
Greg Miller commented on LUCENE-9946:
-
Just as a small update on this, I've hit a li
[
https://issues.apache.org/jira/browse/LUCENE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339188#comment-17339188
]
Adrien Grand commented on LUCENE-9335:
--
Thanks for writing two scorers to test this
[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jack Conradson updated LUCENE-9843:
---
Attachment: LUCENE-9843.patch
> Remove compression option on doc values
> --
[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jack Conradson updated LUCENE-9843:
---
Attachment: LUCENE-9843.patch
> Remove compression option on doc values
> --
[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339245#comment-17339245
]
Jack Conradson commented on LUCENE-9843:
I have attached a new patch ([^LUCENE-9
[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339245#comment-17339245
]
Jack Conradson edited comment on LUCENE-9843 at 5/4/21, 7:18 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339245#comment-17339245
]
Jack Conradson edited comment on LUCENE-9843 at 5/4/21, 7:19 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jack Conradson updated LUCENE-9843:
---
Attachment: (was: LUCENE-9843.patch)
> Remove compression option on doc values
> ---
rmuir commented on pull request #15:
URL: https://github.com/apache/lucene/pull/15#issuecomment-832353332
I got the precommit "working" by just disabling a bunch of build checks with
corresponding `TODO` in the source code, reducing visibility of some stuff that
didn't need to be public, e
rmuir commented on pull request #15:
URL: https://github.com/apache/lucene/pull/15#issuecomment-832354853
ugh, and i guess that `spotlessApply` really made some of the code ugly,
especially comments. maybe we can manually wrap them in a way that the spotless
checker still accepts. sorry, w
magibney commented on pull request #15:
URL: https://github.com/apache/lucene/pull/15#issuecomment-832355590
Yeah; the heavy hand of spotlessApply was the main reason I didn't fuss with
getting the precommit checks to pass. I understand if you want to wait for the
build checks to pass befo
rmuir commented on pull request #15:
URL: https://github.com/apache/lucene/pull/15#issuecomment-832362947
yes, it is much easier for me to help out if the build and tests are
working, I can't really review otherwise because I rarely write java these
days. So to suggest something I usually
magibney commented on pull request #15:
URL: https://github.com/apache/lucene/pull/15#issuecomment-832365501
That makes sense; apologies for the rough state wrt precommit (though fwiw
the _tests_ have been my focus, and those should be solid). I'll get precommit
passing with any necessary
rmuir commented on pull request #15:
URL: https://github.com/apache/lucene/pull/15#issuecomment-832367527
the tests are failing for me locally too. Mostly it seemed to be previous
implementations test? It does `assertEquals(AnalysisResult a, AnalysisResult
b)` but AnalysisResult has no equ
[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-9843:
Attachment: LUCENE-9843.patch
mods.patch
Status: Open (was: Open)
[~jdcon
magibney commented on pull request #15:
URL: https://github.com/apache/lucene/pull/15#issuecomment-832369359
Ah, sorry! yeah, now that you mention it I'm afraid I'm not surprised. I'm
going to just remove the previous impl (as you suggested would make things
clearer). I think that's the ri
[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339374#comment-17339374
]
Robert Muir commented on LUCENE-9843:
-
looks like we can do the same trick for binar
41 matches
Mail list logo
