[GitHub] [lucene] dweiss commented on pull request #108: LUCENE-9897 Change dependency checking mechanism to use gradle checksum verification

2021-04-27 Thread GitBox
dweiss commented on pull request #108: URL: https://github.com/apache/lucene/pull/108#issuecomment-827381909 Thanks, this looks suspiciously simple!... :) I'll be glad to experiment with it a bit. I'm not a big fan of the monolithic checksum file - the expanded version (per-jar che

[GitHub] [lucene] dweiss commented on a change in pull request #108: LUCENE-9897 Change dependency checking mechanism to use gradle checksum verification

2021-04-27 Thread GitBox
dweiss commented on a change in pull request #108: URL: https://github.com/apache/lucene/pull/108#discussion_r620938812 ## File path: gradle/validation/jar-checks.gradle ## @@ -140,41 +139,6 @@ subprojects { } } - // Verifies that each JAR has a corresponding checksu

[GitHub] [lucene] jpountz commented on a change in pull request #107: LUCENE-9047: Move the Directory APIs to be little endian (take 2)

2021-04-27 Thread GitBox
jpountz commented on a change in pull request #107: URL: https://github.com/apache/lucene/pull/107#discussion_r620941684 ## File path: lucene/core/src/java/org/apache/lucene/codecs/CodecUtil.java ## @@ -640,6 +640,33 @@ static void writeCRC(IndexOutput output) throws IOExcepti

[GitHub] [lucene] jpountz commented on a change in pull request #107: LUCENE-9047: Move the Directory APIs to be little endian (take 2)

2021-04-27 Thread GitBox
jpountz commented on a change in pull request #107: URL: https://github.com/apache/lucene/pull/107#discussion_r620951695 ## File path: lucene/core/src/java/org/apache/lucene/store/ByteBufferIndexInput.java ## @@ -177,7 +177,7 @@ public void readLELongs(long[] dst, int offset,

[GitHub] [lucene] dweiss commented on a change in pull request #107: LUCENE-9047: Move the Directory APIs to be little endian (take 2)

2021-04-27 Thread GitBox
dweiss commented on a change in pull request #107: URL: https://github.com/apache/lucene/pull/107#discussion_r620962715 ## File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/packed/LegacyDirectReader.java ## @@ -0,0 +1,368 @@ +/* + * Licensed to the A

[jira] [Commented] (LUCENE-8069) Allow index sorting by field length

2021-04-27 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333040#comment-17333040 ] Adrien Grand commented on LUCENE-8069: -- Since I was playing with the MSMarco passag

[jira] [Commented] (LUCENE-8069) Allow index sorting by field length

2021-04-27 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333044#comment-17333044 ] Adrien Grand commented on LUCENE-8069: -- bq. I guess people wanting these benefits t

[jira] [Updated] (LUCENE-9939) Proper ASCII folding of Danish/Norwegian characters Ø, Å

2021-04-27 Thread Jacob Lauritzen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob Lauritzen updated LUCENE-9939: Status: Patch Available (was: Open) > Proper ASCII folding of Danish/Norwegian characters

[jira] [Created] (LUCENE-9939) Proper ASCII folding of Danish/Norwegian characters Ø, Å

2021-04-27 Thread Jacob Lauritzen (Jira)
Jacob Lauritzen created LUCENE-9939: --- Summary: Proper ASCII folding of Danish/Norwegian characters Ø, Å Key: LUCENE-9939 URL: https://issues.apache.org/jira/browse/LUCENE-9939 Project: Lucene - Core

[jira] [Updated] (LUCENE-9939) Proper ASCII folding of Danish/Norwegian characters Ø, Å

2021-04-27 Thread Jacob Lauritzen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob Lauritzen updated LUCENE-9939: Attachment: LUCENE-9939.patch Labels: easyfix patch patch-available (was: easyfix)

[jira] [Commented] (LUCENE-9939) Proper ASCII folding of Danish/Norwegian characters Ø, Å

2021-04-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333128#comment-17333128 ] Robert Muir commented on LUCENE-9939: - This isn't the way to go: these aren't the on

[GitHub] [lucene-solr] noblepaul merged pull request #2481: SOLR-15337 Avoid XPath in solrconfig.xml parsing

2021-04-27 Thread GitBox
noblepaul merged pull request #2481: URL: https://github.com/apache/lucene-solr/pull/2481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (LUCENE-8069) Allow index sorting by field length

2021-04-27 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333213#comment-17333213 ] Michael McCandless commented on LUCENE-8069: {quote}This seems to confirm th

[jira] [Created] (LUCENE-9940) The order of disjuncts in DisjunctionMaxQuery affects equals() impl

2021-04-27 Thread Alan Woodward (Jira)
Alan Woodward created LUCENE-9940: - Summary: The order of disjuncts in DisjunctionMaxQuery affects equals() impl Key: LUCENE-9940 URL: https://issues.apache.org/jira/browse/LUCENE-9940 Project: Lucene

[jira] [Commented] (LUCENE-9940) The order of disjuncts in DisjunctionMaxQuery affects equals() impl

2021-04-27 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333278#comment-17333278 ] Adrien Grand commented on LUCENE-9940: -- +1, it might need to be a MultiSet in order

[jira] [Commented] (LUCENE-9204) Move span queries to the queries module

2021-04-27 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1725#comment-1725 ] Alan Woodward commented on LUCENE-9204: --- I'd like to try and get this change in fo

[GitHub] [lucene] neoremind commented on pull request #91: LUCENE-9932: Performance improvement for BKD index building

2021-04-27 Thread GitBox
neoremind commented on pull request #91: URL: https://github.com/apache/lucene/pull/91#issuecomment-827678981 I spent some time trying to use the real case benchmark. The speedup of `IndexWriter` is what we expected, faster than main branch, total time elapsed (include adding doc, building

[GitHub] [lucene] mayya-sharipova commented on pull request #103: Fix regression to account payloads while merging

2021-04-27 Thread GitBox
mayya-sharipova commented on pull request #103: URL: https://github.com/apache/lucene/pull/103#issuecomment-827737112 @jpountz Thank you for the review. I've added the test to `TestTermVectors` in dc660968003cbaf6bb80c59c78b34af67fdedc03 -- This is an automated message from the Apache Gi

[GitHub] [lucene] gautamworah96 commented on a change in pull request #108: LUCENE-9897 Change dependency checking mechanism to use gradle checksum verification

2021-04-27 Thread GitBox
gautamworah96 commented on a change in pull request #108: URL: https://github.com/apache/lucene/pull/108#discussion_r621414185 ## File path: gradle/verification-metadata.xml ## @@ -0,0 +1,2198 @@ + +https://schema.gradle.org/dependency-verification"; xmlns:xsi="http://www.w3.o

[GitHub] [lucene] dweiss commented on a change in pull request #108: LUCENE-9897 Change dependency checking mechanism to use gradle checksum verification

2021-04-27 Thread GitBox
dweiss commented on a change in pull request #108: URL: https://github.com/apache/lucene/pull/108#discussion_r621486745 ## File path: gradle/verification-metadata.xml ## @@ -0,0 +1,2198 @@ + +https://schema.gradle.org/dependency-verification"; xmlns:xsi="http://www.w3.org/2001

[GitHub] [lucene] gautamworah96 commented on a change in pull request #108: LUCENE-9897 Change dependency checking mechanism to use gradle checksum verification

2021-04-27 Thread GitBox
gautamworah96 commented on a change in pull request #108: URL: https://github.com/apache/lucene/pull/108#discussion_r621512372 ## File path: gradle/verification-metadata.xml ## @@ -0,0 +1,2198 @@ + +https://schema.gradle.org/dependency-verification"; xmlns:xsi="http://www.w3.o

[GitHub] [lucene] gautamworah96 commented on pull request #108: LUCENE-9897 Change dependency checking mechanism to use gradle checksum verification

2021-04-27 Thread GitBox
gautamworah96 commented on pull request #108: URL: https://github.com/apache/lucene/pull/108#issuecomment-827847811 > Thanks, this looks suspiciously simple!... :) I'll be glad to experiment with it a bit. 💯 > > I'm not a big fan of the monolithic checksum file - the expa

[GitHub] [lucene] dweiss commented on pull request #108: LUCENE-9897 Change dependency checking mechanism to use gradle checksum verification

2021-04-27 Thread GitBox
dweiss commented on pull request #108: URL: https://github.com/apache/lucene/pull/108#issuecomment-827851298 It's fine. I kind of prefer filesystem (file name)-based correspondence of checksums to files but I can live with a monolithic file too. -- This is an automated message from the

[jira] [Created] (LUCENE-9941) ann-benchmarks results for HNSW indexing

2021-04-27 Thread Julie Tibshirani (Jira)
Julie Tibshirani created LUCENE-9941: Summary: ann-benchmarks results for HNSW indexing Key: LUCENE-9941 URL: https://issues.apache.org/jira/browse/LUCENE-9941 Project: Lucene - Core Issu

[jira] [Updated] (LUCENE-9941) ann-benchmarks results for HNSW indexing

2021-04-27 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-9941: - Description: This is a continuation of LUCENE-9937, but for HNSW index performance. App

[jira] [Commented] (LUCENE-9905) Revise approach to specifying NN algorithm

2021-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334374#comment-17334374 ] ASF subversion and git services commented on LUCENE-9905: - Commi

[GitHub] [lucene] msokolov commented on a change in pull request #106: LUCENE-9905: rename VectorValues.SearchStrategy to VectorValues.SimilarityFunction

2021-04-27 Thread GitBox
msokolov commented on a change in pull request #106: URL: https://github.com/apache/lucene/pull/106#discussion_r621665922 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -2336,6 +2338,29 @@ static void checkImpacts(Impacts impacts, int lastTarg

[jira] [Commented] (LUCENE-9905) Revise approach to specifying NN algorithm

2021-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334375#comment-17334375 ] ASF subversion and git services commented on LUCENE-9905: - Commi

[GitHub] [lucene-solr] gus-asf opened a new pull request #2483: LUCENE-9574 - Add a token filter to drop tokens based on flags.

2021-04-27 Thread GitBox
gus-asf opened a new pull request #2483: URL: https://github.com/apache/lucene-solr/pull/2483 Backport -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about th

[GitHub] [lucene-solr] gus-asf merged pull request #2483: LUCENE-9574 - Add a token filter to drop tokens based on flags.

2021-04-27 Thread GitBox
gus-asf merged pull request #2483: URL: https://github.com/apache/lucene-solr/pull/2483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[jira] [Commented] (LUCENE-9574) Add a token filter to drop tokens based on flags.

2021-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334403#comment-17334403 ] ASF subversion and git services commented on LUCENE-9574: - Commi

[jira] [Resolved] (LUCENE-9574) Add a token filter to drop tokens based on flags.

2021-04-27 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck resolved LUCENE-9574. -- Resolution: Implemented > Add a token filter to drop tokens based on flags. >

[GitHub] [lucene-solr] gus-asf opened a new pull request #2484: LUCENE-9574 CHANGES.txt entry

2021-04-27 Thread GitBox
gus-asf opened a new pull request #2484: URL: https://github.com/apache/lucene-solr/pull/2484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servi

[GitHub] [lucene-solr] gus-asf merged pull request #2484: LUCENE-9574 CHANGES.txt entry

2021-04-27 Thread GitBox
gus-asf merged pull request #2484: URL: https://github.com/apache/lucene-solr/pull/2484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[jira] [Commented] (LUCENE-9574) Add a token filter to drop tokens based on flags.

2021-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334425#comment-17334425 ] ASF subversion and git services commented on LUCENE-9574: - Commi

[jira] [Commented] (LUCENE-9574) Add a token filter to drop tokens based on flags.

2021-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334429#comment-17334429 ] ASF subversion and git services commented on LUCENE-9574: - Commi

[jira] [Updated] (LUCENE-9574) Add a token filter to drop tokens based on flags.

2021-04-27 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated LUCENE-9574: - Fix Version/s: 8.9 > Add a token filter to drop tokens based on flags. > ---