[GitHub] [lucene-solr] janhoy commented on a change in pull request #2230: SOLR-15011: /admin/logging handler is configured logs to all nodes

2021-01-31 Thread GitBox
janhoy commented on a change in pull request #2230: URL: https://github.com/apache/lucene-solr/pull/2230#discussion_r567431423 ## File path: solr/webapp/web/js/angular/services.js ## @@ -58,7 +58,7 @@ solrAdminServices.factory('System', }]) .factory('Logging', ['$resourc

[jira] [Resolved] (SOLR-15084) Multiple Fields in Polygon Intersection query

2021-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15084. - Resolution: Not A Problem I'm going to close this as "Not a Problem" both because this feels more

[jira] [Comment Edited] (SOLR-15084) Multiple Fields in Polygon Intersection query

2021-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275919#comment-17275919 ] David Smiley edited comment on SOLR-15084 at 1/31/21, 3:41 PM:

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2230: SOLR-15011: /admin/logging handler is configured logs to all nodes

2021-01-31 Thread GitBox
dsmiley commented on a change in pull request #2230: URL: https://github.com/apache/lucene-solr/pull/2230#discussion_r567447802 ## File path: solr/webapp/web/js/angular/services.js ## @@ -58,7 +58,7 @@ solrAdminServices.factory('System', }]) .factory('Logging', ['$resour

[jira] [Commented] (SOLR-11099) Provide a mechanism to add non-core level handlers

2021-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275925#comment-17275925 ] David Smiley commented on SOLR-11099: - Don't we have this feature now vis-a-vis the p

[jira] [Created] (SOLR-15124) Remove node/container level admin handlers from ImplicitPlugins.json (core level).

2021-01-31 Thread David Smiley (Jira)
David Smiley created SOLR-15124: --- Summary: Remove node/container level admin handlers from ImplicitPlugins.json (core level). Key: SOLR-15124 URL: https://issues.apache.org/jira/browse/SOLR-15124 Projec

[jira] [Commented] (SOLR-4943) Add a new info admin handler.

2021-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275932#comment-17275932 ] David Smiley commented on SOLR-4943: We never did remove these old handers from the co

[jira] [Updated] (SOLR-15124) Remove node/container level admin handlers from ImplicitPlugins.json (core level).

2021-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-15124: Fix Version/s: master (9.0) Priority: Blocker (was: Major) > Remove node/container level

[GitHub] [lucene-solr] kwatters commented on pull request #2185: LUCENE-9659 inequality support in payload check query

2021-01-31 Thread GitBox
kwatters commented on pull request #2185: URL: https://github.com/apache/lucene-solr/pull/2185#issuecomment-770416890 I simplified the equals operator, and as a result pulled out the MatchOperation into an enum. I think this is probably cleaner. Additional test cases were added to the te

[GitHub] [lucene-solr] kwatters commented on pull request #2185: LUCENE-9659 inequality support in payload check query

2021-01-31 Thread GitBox
kwatters commented on pull request #2185: URL: https://github.com/apache/lucene-solr/pull/2185#issuecomment-770430584 With a little more investigation into a lambda approach for the compare method, (which on it's surface seems like a nice fit.) it got a bit messy because each subclass wo

[jira] [Created] (LUCENE-9715) EOF error in VectorValues in Lucene nightly benchmarks

2021-01-31 Thread Jira
Anton Hägerstrand created LUCENE-9715: - Summary: EOF error in VectorValues in Lucene nightly benchmarks Key: LUCENE-9715 URL: https://issues.apache.org/jira/browse/LUCENE-9715 Project: Lucene - Cor

[jira] [Commented] (LUCENE-9711) "gradle precommit" no longer catches accidental package-private APIs?

2021-01-31 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275967#comment-17275967 ] Michael McCandless commented on LUCENE-9711: {quote}So we can't rely on java

[jira] [Commented] (LUCENE-9715) EOF error in VectorValues in Lucene nightly benchmarks

2021-01-31 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275974#comment-17275974 ] Michael McCandless commented on LUCENE-9715: Egads, this is exciting. Just

[jira] [Commented] (SOLR-11099) Provide a mechanism to add non-core level handlers

2021-01-31 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275975#comment-17275975 ] Noble Paul commented on SOLR-11099: --- Yes. We already have container level plugins. This

[jira] [Commented] (LUCENE-9711) "gradle precommit" no longer catches accidental package-private APIs?

2021-01-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275978#comment-17275978 ] Dawid Weiss commented on LUCENE-9711: - Thanks for locating the problem, Robert. I t

[jira] [Resolved] (SOLR-11099) Provide a mechanism to add non-core level handlers

2021-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-11099. - Fix Version/s: 8.6.0 Resolution: Duplicate > Provide a mechanism to add non-core level han

[jira] [Closed] (SOLR-11099) Provide a mechanism to add non-core level handlers

2021-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley closed SOLR-11099. --- > Provide a mechanism to add non-core level handlers > --

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2185: LUCENE-9659 inequality support in payload check query

2021-01-31 Thread GitBox
dsmiley commented on a change in pull request #2185: URL: https://github.com/apache/lucene-solr/pull/2185#discussion_r567486167 ## File path: lucene/queries/src/java/org/apache/lucene/queries/payloads/PayloadMatcherFactory.java ## @@ -0,0 +1,249 @@ +/* + * Licensed to the Apac

[jira] [Updated] (LUCENE-9715) EOF error in VectorValues in Lucene nightly benchmarks

2021-01-31 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Hägerstrand updated LUCENE-9715: -- Attachment: benchrun.py > EOF error in VectorValues in Lucene nightly benchmarks > ---

[jira] [Commented] (LUCENE-9715) EOF error in VectorValues in Lucene nightly benchmarks

2021-01-31 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275996#comment-17275996 ] Anton Hägerstrand commented on LUCENE-9715: --- I am/was unfortunately not on the

[jira] [Comment Edited] (LUCENE-9715) EOF error in VectorValues in Lucene nightly benchmarks

2021-01-31 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275996#comment-17275996 ] Anton Hägerstrand edited comment on LUCENE-9715 at 1/31/21, 9:58 PM: -

[GitHub] [lucene-solr] kwatters commented on a change in pull request #2185: LUCENE-9659 inequality support in payload check query

2021-01-31 Thread GitBox
kwatters commented on a change in pull request #2185: URL: https://github.com/apache/lucene-solr/pull/2185#discussion_r567530588 ## File path: lucene/queries/src/java/org/apache/lucene/queries/payloads/PayloadMatcherFactory.java ## @@ -0,0 +1,249 @@ +/* + * Licensed to the Apa

[jira] [Assigned] (LUCENE-9659) Support inequality operations in payload check queries

2021-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned LUCENE-9659: Assignee: David Smiley (was: Gus Heck) > Support inequality operations in payload check