[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2260: LUCENE-9704: Hunspell: support capitalization for German ß

2021-01-29 Thread GitBox
donnerpeter commented on a change in pull request #2260: URL: https://github.com/apache/lucene-solr/pull/2260#discussion_r566639675 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java ## @@ -158,14 +173,52 @@ WordCase caseOf(char[] wo

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

2021-01-29 Thread GitBox
donnerpeter commented on a change in pull request #2253: URL: https://github.com/apache/lucene-solr/pull/2253#discussion_r566643599 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -370,7 +370,7 @@ private void readAffixFi

[GitHub] [lucene-solr] donnerpeter commented on pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

2021-01-29 Thread GitBox
donnerpeter commented on pull request #2253: URL: https://github.com/apache/lucene-solr/pull/2253#issuecomment-769650662 Force-pushed to resolve a conflict in `SpellCheckerTest.java`, other files haven't changed This is an a

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

2021-01-29 Thread GitBox
dweiss commented on a change in pull request #2253: URL: https://github.com/apache/lucene-solr/pull/2253#discussion_r566653084 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -370,7 +370,7 @@ private void readAffixFile(In

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2260: LUCENE-9704: Hunspell: support capitalization for German ß

2021-01-29 Thread GitBox
dweiss commented on a change in pull request #2260: URL: https://github.com/apache/lucene-solr/pull/2260#discussion_r566654706 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java ## @@ -158,14 +173,52 @@ WordCase caseOf(char[] word, i

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2260: LUCENE-9704: Hunspell: support capitalization for German ß

2021-01-29 Thread GitBox
donnerpeter commented on a change in pull request #2260: URL: https://github.com/apache/lucene-solr/pull/2260#discussion_r566657944 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java ## @@ -158,14 +173,52 @@ WordCase caseOf(char[] wo

[GitHub] [lucene-solr] donnerpeter commented on pull request #2260: LUCENE-9704: Hunspell: support capitalization for German ß

2021-01-29 Thread GitBox
donnerpeter commented on pull request #2260: URL: https://github.com/apache/lucene-solr/pull/2260#issuecomment-769661902 Resolved merge conflicts with master This is an automated message from the Apache Git Service. To respon

[jira] [Commented] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-01-29 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274241#comment-17274241 ] Ignacio Vera commented on LUCENE-9705: -- Just to keep track here are the formats tha

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2260: LUCENE-9704: Hunspell: support capitalization for German ß

2021-01-29 Thread GitBox
dweiss commented on a change in pull request #2260: URL: https://github.com/apache/lucene-solr/pull/2260#discussion_r52360 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java ## @@ -158,14 +173,52 @@ WordCase caseOf(char[] word, i

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

2021-01-29 Thread GitBox
donnerpeter commented on a change in pull request #2253: URL: https://github.com/apache/lucene-solr/pull/2253#discussion_r52702 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -370,7 +370,7 @@ private void readAffixFi

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

2021-01-29 Thread GitBox
dweiss commented on a change in pull request #2253: URL: https://github.com/apache/lucene-solr/pull/2253#discussion_r54122 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -370,7 +370,7 @@ private void readAffixFile(In

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2260: LUCENE-9704: Hunspell: support capitalization for German ß

2021-01-29 Thread GitBox
donnerpeter commented on a change in pull request #2260: URL: https://github.com/apache/lucene-solr/pull/2260#discussion_r55927 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java ## @@ -158,14 +173,52 @@ WordCase caseOf(char[] wo

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2260: LUCENE-9704: Hunspell: support capitalization for German ß

2021-01-29 Thread GitBox
donnerpeter commented on a change in pull request #2260: URL: https://github.com/apache/lucene-solr/pull/2260#discussion_r55927 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java ## @@ -158,14 +173,52 @@ WordCase caseOf(char[] wo

[GitHub] [lucene-solr] bruno-roustant commented on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-01-29 Thread GitBox
bruno-roustant commented on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-769672391 +1 to customize via PerFieldDocValuesFormat. This approach is the preferred design, as discussed earlier in LUCENE-9378 https://github.com/apache/lucene-solr/pull/206

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2260: LUCENE-9704: Hunspell: support capitalization for German ß

2021-01-29 Thread GitBox
dweiss commented on a change in pull request #2260: URL: https://github.com/apache/lucene-solr/pull/2260#discussion_r566672934 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java ## @@ -158,14 +173,52 @@ WordCase caseOf(char[] word, i

[GitHub] [lucene-solr] dweiss merged pull request #2260: LUCENE-9704: Hunspell: support capitalization for German ß

2021-01-29 Thread GitBox
dweiss merged pull request #2260: URL: https://github.com/apache/lucene-solr/pull/2260 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9704) Hunspell: support capitalization for German ß

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274256#comment-17274256 ] ASF subversion and git services commented on LUCENE-9704: - Commi

[jira] [Resolved] (LUCENE-9704) Hunspell: support capitalization for German ß

2021-01-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9704. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: support capitalization for Germ

[jira] [Created] (LUCENE-9707) Hunspell: check Lucene's implementation against Hunspell's test data

2021-01-29 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9707: Summary: Hunspell: check Lucene's implementation against Hunspell's test data Key: LUCENE-9707 URL: https://issues.apache.org/jira/browse/LUCENE-9707 Project: Lucene

[jira] [Commented] (SOLR-15119) Make LINK splitMethod the default for SplitShardCmd

2021-01-29 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274269#comment-17274269 ] Gézapeti commented on SOLR-15119: - I don't think LINK works for the HDFSDirectoryFactory.

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-01-29 Thread GitBox
donnerpeter opened a new pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267 and unify test naming in SpellCheckerTest # Description We want to have more or less parity in Java and C++ Hunspell implementations # Solution See below

[GitHub] [lucene-solr] iverase opened a new pull request #2268: LUCENE-9705: Move Lucene50CompoundFormat to Lucene90CompoundFormat

2021-01-29 Thread GitBox
iverase opened a new pull request #2268: URL: https://github.com/apache/lucene-solr/pull/2268 see https://issues.apache.org/jira/browse/LUCENE-9705 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [lucene-solr] iverase commented on a change in pull request #2268: LUCENE-9705: Move Lucene50CompoundFormat to Lucene90CompoundFormat

2021-01-29 Thread GitBox
iverase commented on a change in pull request #2268: URL: https://github.com/apache/lucene-solr/pull/2268#discussion_r566697337 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90CompoundFormat.java ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] iverase commented on a change in pull request #2268: LUCENE-9705: Move Lucene50CompoundFormat to Lucene90CompoundFormat

2021-01-29 Thread GitBox
iverase commented on a change in pull request #2268: URL: https://github.com/apache/lucene-solr/pull/2268#discussion_r566697969 ## File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene50/TestLucene50CompoundFormat.java ## @@ -0,0 +1,30 @@ +/* + *

[jira] [Comment Edited] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-01-29 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274241#comment-17274241 ] Ignacio Vera edited comment on LUCENE-9705 at 1/29/21, 9:46 AM: --

[GitHub] [lucene-solr] iverase opened a new pull request #2269: LUCENE-9322: Add TestLucene90FieldInfosFormat

2021-01-29 Thread GitBox
iverase opened a new pull request #2269: URL: https://github.com/apache/lucene-solr/pull/2269 When introducing the new Vector format, we introduced as well a new FieldInfos format. This PR add the test for this format, similar to what it was done for the previous one. @msokolov I th

[jira] [Created] (LUCENE-9708) Hunspell: support FLAG UTF-8 in absence of SET UTF-8

2021-01-29 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9708: Summary: Hunspell: support FLAG UTF-8 in absence of SET UTF-8 Key: LUCENE-9708 URL: https://issues.apache.org/jira/browse/LUCENE-9708 Project: Lucene - Core

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2270: LUCENE-9708: Hunspell: support FLAG UTF-8 in absence of SET UTF-8

2021-01-29 Thread GitBox
donnerpeter opened a new pull request #2270: URL: https://github.com/apache/lucene-solr/pull/2270 # Description This is a valid situation to be supported :( # Solution Explititly encode/decode UTF-8 from default charset bytes # Tests Extended `T

[GitHub] [lucene-solr] dweiss merged pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

2021-01-29 Thread GitBox
dweiss merged pull request #2253: URL: https://github.com/apache/lucene-solr/pull/2253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9702) Hunspell: support alternate casing for short language codes

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274313#comment-17274313 ] ASF subversion and git services commented on LUCENE-9702: - Commi

[jira] [Resolved] (LUCENE-9702) Hunspell: support alternate casing for short language codes

2021-01-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9702. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: support alternate casing for sh

[jira] [Created] (LUCENE-9709) Hunspell: no special dotted i treatment outside tr/az languages

2021-01-29 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9709: Summary: Hunspell: no special dotted i treatment outside tr/az languages Key: LUCENE-9709 URL: https://issues.apache.org/jira/browse/LUCENE-9709 Project: Lucene - Cor

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2271: LUCENE-9709: Hunspell: no special dotted i treatment outside tr/az languages

2021-01-29 Thread GitBox
donnerpeter opened a new pull request #2271: URL: https://github.com/apache/lucene-solr/pull/2271 # Description İmply shouldn't be correct in English # Solution Check for language alternate casing when encountering dotted i # Tests `base_utf` fr

[jira] [Created] (LUCENE-9710) Hunspell: support minor compounding-related flags

2021-01-29 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9710: Summary: Hunspell: support minor compounding-related flags Key: LUCENE-9710 URL: https://issues.apache.org/jira/browse/LUCENE-9710 Project: Lucene - Core Iss

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2272: LUCENE-9710: Hunspell: support minor compounding-related flags

2021-01-29 Thread GitBox
donnerpeter opened a new pull request #2272: URL: https://github.com/apache/lucene-solr/pull/2272 # Description Should be supported: COMPOUNDFLAG, COMPOUNDFORBIDFLAG, CHECKCOMPOUNDDUP, CHECKCOMPOUNDTRIPLE, SIMPLIFIEDTRIPLE, FORCEUCASE # Solution Support them

[GitHub] [lucene-solr] donnerpeter commented on pull request #2272: LUCENE-9710: Hunspell: support minor compounding-related flags

2021-01-29 Thread GitBox
donnerpeter commented on pull request #2272: URL: https://github.com/apache/lucene-solr/pull/2272#issuecomment-769768706 Merging commits separately might make sense. The changes are really small and often in related areas of the code, so reviewing them all together could also be easy enoug

[GitHub] [lucene-solr] madrob commented on pull request #2252: SOLR-15111: Use JDK8 Base64 instead of own implementation

2021-01-29 Thread GitBox
madrob commented on pull request #2252: URL: https://github.com/apache/lucene-solr/pull/2252#issuecomment-769807090 Unfortunately, we can’t use the solution provided from stack overflow -http://apache.org/legal/resolved.html#stackoverflow Can you contact the original author and ask f

[jira] [Commented] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-01-29 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274460#comment-17274460 ] Mike Drob commented on LUCENE-9705: --- I’m confused about the compatibility implications

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2246: LUCENE-9694: New tool for creating a deterministic index

2021-01-29 Thread GitBox
mikemccand commented on a change in pull request #2246: URL: https://github.com/apache/lucene-solr/pull/2246#discussion_r566885578 ## File path: lucene/CHANGES.txt ## @@ -252,7 +252,8 @@ Other New Features - -* LUCENE-9694: New tool for creating a determ

[jira] [Commented] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-01-29 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274514#comment-17274514 ] Ignacio Vera commented on LUCENE-9705: -- There should be no implication for the user

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #2186: LUCENE-9334 Consistency of field data structures

2021-01-29 Thread GitBox
mayya-sharipova commented on pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#issuecomment-769887907 > Could we make this work across segments? @jpountz Thanks for taking a look. I just wanted to confirm that we are ok with this change, which means for exampl

[GitHub] [lucene-solr] madrob merged pull request #2266: SOLR-15120 Reduce duplicated core creation work

2021-01-29 Thread GitBox
madrob merged pull request #2266: URL: https://github.com/apache/lucene-solr/pull/2266 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-15120) Reduce duplicative core creation work

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274548#comment-17274548 ] ASF subversion and git services commented on SOLR-15120: Commit 0

[jira] [Commented] (SOLR-8319) NPE when creating pivot

2021-01-29 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274551#comment-17274551 ] Isabelle Giguere commented on SOLR-8319: The PR (937) in the linked issue SOLR-132

[jira] [Commented] (SOLR-15120) Reduce duplicative core creation work

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274552#comment-17274552 ] ASF subversion and git services commented on SOLR-15120: Commit 5

[jira] [Resolved] (SOLR-15120) Reduce duplicative core creation work

2021-01-29 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-15120. -- Fix Version/s: 8.9 master (9.0) Assignee: Mike Drob Resolution: Fixed

[jira] [Comment Edited] (SOLR-8319) NPE when creating pivot

2021-01-29 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274551#comment-17274551 ] Isabelle Giguere edited comment on SOLR-8319 at 1/29/21, 5:00 PM: --

[GitHub] [lucene-solr] madrob commented on pull request #2216: SOLR-15085 Prevent EmbeddedSolrServer calling shutdown on a CoreConta…

2021-01-29 Thread GitBox
madrob commented on pull request #2216: URL: https://github.com/apache/lucene-solr/pull/2216#issuecomment-769935182 Added upgrade notes, pushed to branch_8x and master! Thanks! This is an automated message from the Apache Git

[GitHub] [lucene-solr] madrob closed pull request #2216: SOLR-15085 Prevent EmbeddedSolrServer calling shutdown on a CoreConta…

2021-01-29 Thread GitBox
madrob closed pull request #2216: URL: https://github.com/apache/lucene-solr/pull/2216 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-15085) EmbeddedSolrServer calls shutdown on a provided CoreContainer

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274588#comment-17274588 ] ASF subversion and git services commented on SOLR-15085: Commit 7

[jira] [Commented] (SOLR-15085) EmbeddedSolrServer calls shutdown on a provided CoreContainer

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274589#comment-17274589 ] ASF subversion and git services commented on SOLR-15085: Commit 2

[jira] [Resolved] (SOLR-15085) EmbeddedSolrServer calls shutdown on a provided CoreContainer

2021-01-29 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-15085. -- Fix Version/s: 8.9 master (9.0) Assignee: Mike Drob Resolution: Fixed

[GitHub] [lucene-solr] megancarey commented on a change in pull request #2234: SOLR-15094: Replace all code references of coreNodeName to replicaName

2021-01-29 Thread GitBox
megancarey commented on a change in pull request #2234: URL: https://github.com/apache/lucene-solr/pull/2234#discussion_r566948054 ## File path: solr/core/src/java/org/apache/solr/cloud/CloudDescriptor.java ## @@ -64,7 +66,7 @@ public CloudDescriptor(CoreDescriptor cd, String c

[jira] [Commented] (SOLR-13209) NullPointerException from call in org.apache.solr.search.SolrIndexSearcher.getDocSet

2021-01-29 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274593#comment-17274593 ] Isabelle Giguere commented on SOLR-13209: - Throwing an exception for a null query

[GitHub] [lucene-solr] madrob merged pull request #2193: SOLR-15025: MiniSolrCloudCluster.waitForAllNodes ignores passed timeout value

2021-01-29 Thread GitBox
madrob merged pull request #2193: URL: https://github.com/apache/lucene-solr/pull/2193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-15025) MiniSolrCloudCluster.waitForAllNodes ignores passed timeout value

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274698#comment-17274698 ] ASF subversion and git services commented on SOLR-15025: Commit a

[jira] [Commented] (SOLR-15025) MiniSolrCloudCluster.waitForAllNodes ignores passed timeout value

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274772#comment-17274772 ] ASF subversion and git services commented on SOLR-15025: Commit 5

[GitHub] [lucene-solr] gautamworah96 commented on a change in pull request #2247: LUCENE-9476 Add getBulkPath API for the Taxonomy index

2021-01-29 Thread GitBox
gautamworah96 commented on a change in pull request #2247: URL: https://github.com/apache/lucene-solr/pull/2247#discussion_r566976157 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestDirectoryTaxonomyReader.java ## @@ -569,4 +569,31 @@ public

[jira] [Resolved] (SOLR-15025) MiniSolrCloudCluster.waitForAllNodes ignores passed timeout value

2021-01-29 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-15025. -- Fix Version/s: 8.9 master (9.0) Assignee: Mike Drob Resolution: Fixed

[GitHub] [lucene-solr] gautamworah96 commented on a change in pull request #2247: LUCENE-9476 Add getBulkPath API for the Taxonomy index

2021-01-29 Thread GitBox
gautamworah96 commented on a change in pull request #2247: URL: https://github.com/apache/lucene-solr/pull/2247#discussion_r566976943 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -353,12 +349,65 @@ public Fac

[GitHub] [lucene-solr] gautamworah96 commented on a change in pull request #2247: LUCENE-9476 Add getBulkPath API for the Taxonomy index

2021-01-29 Thread GitBox
gautamworah96 commented on a change in pull request #2247: URL: https://github.com/apache/lucene-solr/pull/2247#discussion_r566977877 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -353,12 +349,65 @@ public Fac

[GitHub] [lucene-solr] epugh merged pull request #2257: SOLR-14067: v4 Create /contrib/scripting module with ScriptingUpdateProcessor

2021-01-29 Thread GitBox
epugh merged pull request #2257: URL: https://github.com/apache/lucene-solr/pull/2257 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [lucene-solr] gautamworah96 commented on a change in pull request #2247: LUCENE-9476 Add getBulkPath API for the Taxonomy index

2021-01-29 Thread GitBox
gautamworah96 commented on a change in pull request #2247: URL: https://github.com/apache/lucene-solr/pull/2247#discussion_r566978754 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -314,7 +316,6 @@ public int g

[jira] [Commented] (SOLR-14067) Move StatelessScriptUpdateProcessor to a contrib

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275213#comment-17275213 ] ASF subversion and git services commented on SOLR-14067: Commit 6

[GitHub] [lucene-solr] gautamworah96 commented on a change in pull request #2247: LUCENE-9476 Add getBulkPath API for the Taxonomy index

2021-01-29 Thread GitBox
gautamworah96 commented on a change in pull request #2247: URL: https://github.com/apache/lucene-solr/pull/2247#discussion_r566980263 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -353,12 +349,65 @@ public Fac

[GitHub] [lucene-solr] gautamworah96 commented on a change in pull request #2247: LUCENE-9476 Add getBulkPath API for the Taxonomy index

2021-01-29 Thread GitBox
gautamworah96 commented on a change in pull request #2247: URL: https://github.com/apache/lucene-solr/pull/2247#discussion_r566981233 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -353,12 +349,65 @@ public Fac

[jira] [Created] (SOLR-15121) Move XSLT (tr param) to scripting contrib

2021-01-29 Thread David Smiley (Jira)
David Smiley created SOLR-15121: --- Summary: Move XSLT (tr param) to scripting contrib Key: SOLR-15121 URL: https://issues.apache.org/jira/browse/SOLR-15121 Project: Solr Issue Type: Improvement

[jira] [Updated] (SOLR-15121) Move XSLT (tr param) to scripting contrib

2021-01-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-15121: Fix Version/s: master (9.0) > Move XSLT (tr param) to scripting contrib > -

[GitHub] [lucene-solr] gautamworah96 commented on a change in pull request #2247: LUCENE-9476 Add getBulkPath API for the Taxonomy index

2021-01-29 Thread GitBox
gautamworah96 commented on a change in pull request #2247: URL: https://github.com/apache/lucene-solr/pull/2247#discussion_r566988968 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -353,12 +349,65 @@ public Fac

[jira] [Commented] (SOLR-15121) Move XSLT (tr param) to scripting contrib

2021-01-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275220#comment-17275220 ] David Smiley commented on SOLR-15121: - Additionally, the functionality should be guar

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2256: LUCENE-9507 Custom order for leaves in IndexReader and IndexWriter

2021-01-29 Thread GitBox
mikemccand commented on a change in pull request #2256: URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r566993804 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -941,6 +969,11 @@ public IndexWriter(Directory d, IndexWriterConf

[jira] [Assigned] (SOLR-15121) Move XSLT (tr param) to scripting contrib

2021-01-29 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh reassigned SOLR-15121: -- Assignee: David Eric Pugh > Move XSLT (tr param) to scripting contrib > --

[GitHub] [lucene-solr] mikemccand merged pull request #2246: LUCENE-9694: New tool for creating a deterministic index

2021-01-29 Thread GitBox
mikemccand merged pull request #2246: URL: https://github.com/apache/lucene-solr/pull/2246 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-9694) New tool for creating a deterministic index

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275246#comment-17275246 ] ASF subversion and git services commented on LUCENE-9694: - Commi

[GitHub] [lucene-solr] mikemccand commented on pull request #2246: LUCENE-9694: New tool for creating a deterministic index

2021-01-29 Thread GitBox
mikemccand commented on pull request #2246: URL: https://github.com/apache/lucene-solr/pull/2246#issuecomment-769974955 Thank you @zhaih! This will be a very useful tool for realistic benchmarking! This is an automated mess

[jira] [Commented] (SOLR-8319) NPE when creating pivot

2021-01-29 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275256#comment-17275256 ] Houston Putman commented on SOLR-8319: -- I have done just a bit of digging, but the re

[GitHub] [lucene-solr] HoustonPutman opened a new pull request #2273: SOLR-8319: Add method for tokenized field search in FieldType

2021-01-29 Thread GitBox
HoustonPutman opened a new pull request #2273: URL: https://github.com/apache/lucene-solr/pull/2273 Addresses NPE found in https://issues.apache.org/jira/browse/SOLR-8319 Will do some performance comparisons before merging as well. ---

[jira] [Commented] (SOLR-8319) NPE when creating pivot

2021-01-29 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275262#comment-17275262 ] Houston Putman commented on SOLR-8319: -- The reason for the NPE on different values of

[GitHub] [lucene-solr-operator] HoustonPutman merged pull request #203: Fix copy/paste typo addressed -> updated

2021-01-29 Thread GitBox
HoustonPutman merged pull request #203: URL: https://github.com/apache/lucene-solr-operator/pull/203 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [lucene-solr-operator] HoustonPutman opened a new pull request #206: Remove the SolrCollection and SolrCollectionAlias CRDs

2021-01-29 Thread GitBox
HoustonPutman opened a new pull request #206: URL: https://github.com/apache/lucene-solr-operator/pull/206 Resolves: #204 Still need to update the local tutorial to not use the Collection CRD. This is an automated mes

[GitHub] [lucene-solr] mikemccand commented on pull request #2097: LUCENE-9537

2021-01-29 Thread GitBox
mikemccand commented on pull request #2097: URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-770011220 Thanks @cammiemw, that test now passes again! I ran top-level tests multiple times and each time, a solr test failed for what looked like (not certain) unrelated to

[jira] [Updated] (SOLR-7642) Should launching Solr in cloud mode using a ZooKeeper chroot create the chroot znode if it doesn't exist?

2021-01-29 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-7642: --- Attachment: SOLR-7642.patch > Should launching Solr in cloud mode using a ZooKeeper chroot cre

[jira] [Comment Edited] (SOLR-7642) Should launching Solr in cloud mode using a ZooKeeper chroot create the chroot znode if it doesn't exist?

2021-01-29 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275287#comment-17275287 ] Isabelle Giguere edited comment on SOLR-7642 at 1/29/21, 7:45 PM: --

[jira] [Commented] (SOLR-7642) Should launching Solr in cloud mode using a ZooKeeper chroot create the chroot znode if it doesn't exist?

2021-01-29 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275287#comment-17275287 ] Isabelle Giguere commented on SOLR-7642: New patch, adressing Jan's comments. The

[GitHub] [lucene-solr] mikemccand merged pull request #2097: LUCENE-9537

2021-01-29 Thread GitBox
mikemccand merged pull request #2097: URL: https://github.com/apache/lucene-solr/pull/2097 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (SOLR-8319) NPE when creating pivot

2021-01-29 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-8319: --- Attachment: SOLR-7642.patch > NPE when creating pivot > --- > >

[jira] [Updated] (SOLR-8319) NPE when creating pivot

2021-01-29 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-8319: --- Attachment: (was: SOLR-7642.patch) > NPE when creating pivot > --- > >

[jira] [Commented] (LUCENE-9537) Add Indri Search Engine Functionality to Lucene

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275289#comment-17275289 ] ASF subversion and git services commented on LUCENE-9537: - Commi

[GitHub] [lucene-solr-operator] sepulworld opened a new pull request #207: docs: removing step in local tutorial for collection creation

2021-01-29 Thread GitBox
sepulworld opened a new pull request #207: URL: https://github.com/apache/lucene-solr-operator/pull/207 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene-solr-operator] sepulworld commented on pull request #206: Remove the SolrCollection and SolrCollectionAlias CRDs

2021-01-29 Thread GitBox
sepulworld commented on pull request #206: URL: https://github.com/apache/lucene-solr-operator/pull/206#issuecomment-770020782 Updated local_tutorial.md here: https://github.com/apache/lucene-solr-operator/pull/207 if you wanted to review and merge separately ---

[jira] [Resolved] (SOLR-12663) Highlighting is not working with docValues only String field

2021-01-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-12663. - Fix Version/s: 8.5 Resolution: Fixed Implemented via SOLR-14194 in 8.5 for the original hi

[jira] [Updated] (SOLR-10321) Unified highlighter returns empty fields when using glob

2021-01-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-10321: Issue Type: Improvement (was: Bug) Priority: Major (was: Minor) > Unified highlighter retur

[jira] [Commented] (LUCENE-9694) New tool for creating a deterministic index

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275311#comment-17275311 ] ASF subversion and git services commented on LUCENE-9694: - Commi

[jira] [Commented] (LUCENE-9694) New tool for creating a deterministic index

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275310#comment-17275310 ] ASF subversion and git services commented on LUCENE-9694: - Commi

[jira] [Resolved] (LUCENE-9694) New tool for creating a deterministic index

2021-01-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-9694. Fix Version/s: 8.9 master (9.0) Resolution: Fixed Thank

[jira] [Commented] (LUCENE-9694) New tool for creating a deterministic index

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275312#comment-17275312 ] ASF subversion and git services commented on LUCENE-9694: - Commi

[jira] [Created] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-01-29 Thread Mike Drob (Jira)
Mike Drob created SOLR-15122: Summary: ClusterEventProducerTest.testEvents is unstable Key: SOLR-15122 URL: https://issues.apache.org/jira/browse/SOLR-15122 Project: Solr Issue Type: Bug Se

[jira] [Created] (LUCENE-9711) "gradle precommit" no longer catches accidental package-private APIs?

2021-01-29 Thread Michael McCandless (Jira)
Michael McCandless created LUCENE-9711: -- Summary: "gradle precommit" no longer catches accidental package-private APIs? Key: LUCENE-9711 URL: https://issues.apache.org/jira/browse/LUCENE-9711 Pro

[jira] [Commented] (SOLR-14949) Ability to customize docker image name/base image

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275329#comment-17275329 ] ASF subversion and git services commented on SOLR-14949: Commit a

[jira] [Commented] (SOLR-14957) Add Prometheus Exporter bin to PATH in docker image

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275326#comment-17275326 ] ASF subversion and git services commented on SOLR-14957: Commit 2

  1   2   >