[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

2020-12-24 Thread GitBox
murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r548488944 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/CollectionMetricsBuilder.java ## @@ -61,18 +80,19 @@ public ShardMetrics bui

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

2020-12-24 Thread GitBox
murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r548489854 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/NodeMetricImpl.java ## @@ -67,7 +67,7 @@ public NodeMetricImpl(String key) {

[jira] [Created] (SOLR-15061) Fix NPE in SearchHandler when shards.info

2020-12-24 Thread Bruno Roustant (Jira)
Bruno Roustant created SOLR-15061: - Summary: Fix NPE in SearchHandler when shards.info Key: SOLR-15061 URL: https://issues.apache.org/jira/browse/SOLR-15061 Project: Solr Issue Type: Bug

[GitHub] [lucene-solr] bruno-roustant opened a new pull request #2168: SOLR-15061: Fix NPE in SearchHandler when shards.info

2020-12-24 Thread GitBox
bruno-roustant opened a new pull request #2168: URL: https://github.com/apache/lucene-solr/pull/2168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2020-12-24 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254502#comment-17254502 ] Dawid Weiss commented on LUCENE-9570: - Thanks Erick! Please feel free to push to tha

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2020-12-24 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254523#comment-17254523 ] Erick Erickson commented on LUCENE-9570: {quote} I assume by the "weird" javadoc

[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2020-12-24 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-9570: --- Description: Review and correct all the javadocs before they're messed up by automatic form

[jira] [Comment Edited] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2020-12-24 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254523#comment-17254523 ] Erick Erickson edited comment on LUCENE-9570 at 12/24/20, 12:26 PM: --

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2020-12-24 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254528#comment-17254528 ] Dawid Weiss commented on LUCENE-9570: - bq. check was successful last night. Besides