[GitHub] [lucene-solr] uschindler commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

uschindler commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-748580504 > On Windows, alignment is done differently from Linux, and thus the aligned slice size could be smaller than the intended buffer size. This may also hidden on oth

[GitHub] [lucene-solr] uschindler edited a comment on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

uschindler edited a comment on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-748580504 > On Windows, alignment is done differently from Linux, and thus the aligned slice size could be smaller than the intended buffer size. This may also happen

[GitHub] [lucene-solr] uschindler commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

uschindler commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-748580960 > is this interface added after initial Unix Directory yes a lot later! This was added when we added checksums around Lucene 5.7. From the code you can also s

[jira] [Commented] (LUCENE-9645) Delete useless variable negativeDeltas in BKDReader$IndexTree

[ https://issues.apache.org/jira/browse/LUCENE-9645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252395#comment-17252395 ] kkewwei commented on LUCENE-9645: - yes， It's my please to do it. > Delete useless varia

[jira] [Comment Edited] (LUCENE-9645) Delete useless variable negativeDeltas in BKDReader$IndexTree

[ https://issues.apache.org/jira/browse/LUCENE-9645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252395#comment-17252395 ] kkewwei edited comment on LUCENE-9645 at 12/20/20, 10:46 AM: -

[GitHub] [lucene-solr] kkewwei commented on pull request #993: LUCENE-9303: maybe can simpler

kkewwei commented on pull request #993: URL: https://github.com/apache/lucene-solr/pull/993#issuecomment-748593159 sorry, the patch has been merged by https://github.com/apache/lucene-solr/pull/2076 This is an automated mess

[GitHub] [lucene-solr] kkewwei edited a comment on pull request #993: LUCENE-9303: maybe can simpler

kkewwei edited a comment on pull request #993: URL: https://github.com/apache/lucene-solr/pull/993#issuecomment-748593159 sorry, the patch has been merged by https://github.com/apache/lucene-solr/pull/2076 recently This is a

[GitHub] [lucene-solr] kkewwei opened a new pull request #2158: LUCENE-9645: Delete useless variable negativeDeltas in BKDReader

kkewwei opened a new pull request #2158: URL: https://github.com/apache/lucene-solr/pull/2158 # Description variable negative `Deltas` can be replaced by `isLeft` which is function parameter. we don't use `variable` in other place. # Checklist - [ ] I have reviewed the guidelin

[GitHub] [lucene-solr] rmuir commented on pull request #2155: LUCENE-9641: Support for spatial relationships in LatLonPoint

rmuir commented on pull request #2155: URL: https://github.com/apache/lucene-solr/pull/2155#issuecomment-748622584 I think the JIRA doesn't give a good explanation for adding thousand lines of code. What is the use-case? To me these relationships don't make sense for points... since they a

[GitHub] [lucene-solr] rmuir commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

rmuir commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r546392979 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -0,0 +1,392 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [lucene-solr] rmuir commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

rmuir commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r546393037 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -0,0 +1,392 @@ +/* + * Licensed to the Apache Software Fou

[jira] [Updated] (LUCENE-9643) Create .git-blame-ignore-revs file with revisions that only apply reformatting

[ https://issues.apache.org/jira/browse/LUCENE-9643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9643: Description: Interim squashed merges from LUCENE-9570 to master are recorded in .git-blame-ignore

[jira] [Comment Edited] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252496#comment-17252496 ] Thomas Wöckinger edited comment on SOLR-14923 at 12/20/20, 7:25 PM: ---

[jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252496#comment-17252496 ] Thomas Wöckinger commented on SOLR-14923: - [~dsmiley] Any progress on this issue?

[jira] [Commented] (LUCENE-9640) Add TrackingQuery to track matching documents

[ https://issues.apache.org/jira/browse/LUCENE-9640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252538#comment-17252538 ] Michael McCandless commented on LUCENE-9640: Disclaimer: [~elbek@gmail.c

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

uschindler commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r546454647 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -0,0 +1,392 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [lucene-solr] uschindler commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

uschindler commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r546454653 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -0,0 +1,392 @@ +/* + * Licensed to the Apache Softwar

[jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252647#comment-17252647 ] David Smiley commented on SOLR-14923: - I found/fixed at least two bugs, probably a th

[GitHub] [lucene-solr] zacharymorn commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-748804203 > This may also happen on other operating systems. It depends on if the buffer is already aligned when you call alignSlice(). If it is not aligned (seems to happen 100%