[jira] [Commented] (LUCENE-9563) Add .editorConfig

2020-10-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209148#comment-17209148 ] David Smiley commented on LUCENE-9563: -- In the first sentence of the description, I

[jira] [Issue Comment Deleted] (LUCENE-9563) Add .editorConfig

2020-10-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-9563: - Comment: was deleted (was: In the first sentence of the description, I said precisely where to p

[jira] [Commented] (LUCENE-9563) Add .editorConfig

2020-10-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209150#comment-17209150 ] David Smiley commented on LUCENE-9563: -- Quoting the description: bq. I propose addi

[GitHub] [lucene-solr] kwatters opened a new pull request #1954: SOLR-14787 - Adding support to use inequalities to the payload check query parser.

2020-10-06 Thread GitBox
kwatters opened a new pull request #1954: URL: https://github.com/apache/lucene-solr/pull/1954 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the approach

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1952: LUCENE-9565 Fix competitive iteration

2020-10-06 Thread GitBox
mayya-sharipova commented on a change in pull request #1952: URL: https://github.com/apache/lucene-solr/pull/1952#discussion_r500604093 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -266,4 +274,45 @@ static void scoreAll(LeafCollector collector,

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1952: LUCENE-9565 Fix competitive iteration

2020-10-06 Thread GitBox
mayya-sharipova commented on a change in pull request #1952: URL: https://github.com/apache/lucene-solr/pull/1952#discussion_r500604093 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -266,4 +274,45 @@ static void scoreAll(LeafCollector collector,

[GitHub] [lucene-solr] mayya-sharipova opened a new pull request #1955: LUCENE-9566 Move collectorIterator to the same doc as scorerIterator

2020-10-06 Thread GitBox
mayya-sharipova opened a new pull request #1955: URL: https://github.com/apache/lucene-solr/pull/1955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1952: LUCENE-9565 Fix competitive iteration

2020-10-06 Thread GitBox
mayya-sharipova commented on a change in pull request #1952: URL: https://github.com/apache/lucene-solr/pull/1952#discussion_r500616570 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -266,4 +274,45 @@ static void scoreAll(LeafCollector collector,

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209193#comment-17209193 ] Robert Muir commented on LUCENE-9564: - +1 from my side too. The current situation

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1955: LUCENE-9566 Move collectorIterator to the same doc as scorerIterator

2020-10-06 Thread GitBox
jpountz commented on a change in pull request #1955: URL: https://github.com/apache/lucene-solr/pull/1955#discussion_r500624839 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -204,21 +204,21 @@ public int score(LeafCollector collector, Bits accep

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209223#comment-17209223 ] Erick Erickson commented on LUCENE-9564: [~jpountz] I don't think you'll miss 2

[jira] [Commented] (SOLR-11508) Make coreRootDirectory configurable via an environment variable (SOLR_CORE_HOME)

2020-10-06 Thread Yevhen Tienkaiev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209228#comment-17209228 ] Yevhen Tienkaiev commented on SOLR-11508: - What the status of this? It's 2020 her

[jira] [Comment Edited] (SOLR-11508) Make coreRootDirectory configurable via an environment variable (SOLR_CORE_HOME)

2020-10-06 Thread Yevhen Tienkaiev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209228#comment-17209228 ] Yevhen Tienkaiev edited comment on SOLR-11508 at 10/6/20, 11:59 PM: ---

[jira] [Comment Edited] (SOLR-11508) Make coreRootDirectory configurable via an environment variable (SOLR_CORE_HOME)

2020-10-06 Thread Yevhen Tienkaiev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209228#comment-17209228 ] Yevhen Tienkaiev edited comment on SOLR-11508 at 10/7/20, 12:05 AM: ---

[jira] [Created] (LUCENE-9567) JapanesePartOfSpeechStopFilterFactory should load built-in stop tags by default

2020-10-06 Thread Michael Froh (Jira)
Michael Froh created LUCENE-9567: Summary: JapanesePartOfSpeechStopFilterFactory should load built-in stop tags by default Key: LUCENE-9567 URL: https://issues.apache.org/jira/browse/LUCENE-9567 Proje

[GitHub] [lucene-solr] arafalov merged pull request #1921: SOLR-14829: Improve documentation for Request Handlers in RefGuide and solrconfig.xml

2020-10-06 Thread GitBox
arafalov merged pull request #1921: URL: https://github.com/apache/lucene-solr/pull/1921 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (SOLR-14829) Update default components information in Reference Guide and solrconfig.xml files

2020-10-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209243#comment-17209243 ] ASF subversion and git services commented on SOLR-14829: Commit 2

[jira] [Commented] (SOLR-14829) Update default components information in Reference Guide and solrconfig.xml files

2020-10-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209242#comment-17209242 ] ASF subversion and git services commented on SOLR-14829: Commit 2

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1955: LUCENE-9566 Move collectorIterator to the same doc as scorerIterator

2020-10-06 Thread GitBox
mayya-sharipova commented on a change in pull request #1955: URL: https://github.com/apache/lucene-solr/pull/1955#discussion_r500673813 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -204,21 +204,21 @@ public int score(LeafCollector collector, Bit

[jira] [Resolved] (SOLR-14829) Update default components information in Reference Guide and solrconfig.xml files

2020-10-06 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch resolved SOLR-14829. -- Fix Version/s: master (9.0) Resolution: Fixed > Update default component

[jira] [Comment Edited] (SOLR-11508) Make coreRootDirectory configurable via an environment variable (SOLR_CORE_HOME)

2020-10-06 Thread Yevhen Tienkaiev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209228#comment-17209228 ] Yevhen Tienkaiev edited comment on SOLR-11508 at 10/7/20, 12:50 AM: ---

[GitHub] [lucene-solr] arafalov commented on pull request #1923: SOLR-14900: Reference Guide build cleanup/module upgrade

2020-10-06 Thread GitBox
arafalov commented on pull request #1923: URL: https://github.com/apache/lucene-solr/pull/1923#issuecomment-704656780 Ok, I reverted back to using direct styles. It only affects code-blocks, so the size changes are minimal and not needing to maintain the CSS file is a bonus. I agree.

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1952: LUCENE-9565 Fix competitive iteration

2020-10-06 Thread GitBox
mayya-sharipova commented on a change in pull request #1952: URL: https://github.com/apache/lucene-solr/pull/1952#discussion_r500703861 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -266,4 +274,45 @@ static void scoreAll(LeafCollector collector,

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1955: LUCENE-9566 Move collectorIterator to the same doc as scorerIterator

2020-10-06 Thread GitBox
mayya-sharipova commented on a change in pull request #1955: URL: https://github.com/apache/lucene-solr/pull/1955#discussion_r500708276 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -204,21 +204,21 @@ public int score(LeafCollector collector, Bit

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1955: LUCENE-9566 Move collectorIterator to the same doc as scorerIterator

2020-10-06 Thread GitBox
mayya-sharipova commented on a change in pull request #1955: URL: https://github.com/apache/lucene-solr/pull/1955#discussion_r500708276 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -204,21 +204,21 @@ public int score(LeafCollector collector, Bit

[jira] [Commented] (SOLR-14870) gradle build does not validate ref-guide -> javadoc links

2020-10-06 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209268#comment-17209268 ] Chris M. Hostetter commented on SOLR-14870: --- {quote}I took a peek. Is there any

[jira] [Resolved] (SOLR-12987) Log deprecation warnings to separate log file

2020-10-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-12987. - Resolution: Fixed > Log deprecation warnings to separate log file > -

[jira] [Updated] (SOLR-12987) Utility to log deprecation warnings

2020-10-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-12987: Description: Added {{org.apache.solr.logging.DeprecationLog}}. Up to the user to configure loggin

[jira] [Resolved] (SOLR-14663) ConfigSets CREATE does not set trusted flag

2020-10-06 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe resolved SOLR-14663. -- Fix Version/s: 8.6.3 8.7 m

[GitHub] [lucene-solr] noblepaul commented on pull request #1951: SOLR-14691: Reduce object creation by using MapWriter / IteratorWriter.

2020-10-06 Thread GitBox
noblepaul commented on pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951#issuecomment-704676764 >Again, we're limited by back-compat in 8x. We could add another set of methods in MetricUtils that use Predicate and deprecate PropertyFilter ... but that would double th

[GitHub] [lucene-solr] noblepaul commented on pull request #1951: SOLR-14691: Reduce object creation by using MapWriter / IteratorWriter.

2020-10-06 Thread GitBox
noblepaul commented on pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951#issuecomment-704677008 >Not in branch_8x - it's a part of the public API. We can have both and mark the old as deprecated. The guages are creating too many Map objects --

[GitHub] [lucene-solr] dsmiley opened a new pull request #1956: LUCENE-9563: Add .editorconfig

2020-10-06 Thread GitBox
dsmiley opened a new pull request #1956: URL: https://github.com/apache/lucene-solr/pull/1956 https://issues.apache.org/jira/browse/LUCENE-9563 This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Commented] (SOLR-14066) Deprecate DIH and migrate to a community supported package

2020-10-06 Thread Erich Siffert (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209282#comment-17209282 ] Erich Siffert commented on SOLR-14066: -- Hi Rui no, I didn't. But I guess if you plac

[jira] [Commented] (SOLR-14151) Make schema components load from packages

2020-10-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209289#comment-17209289 ] ASF subversion and git services commented on SOLR-14151: Commit 2

[jira] [Commented] (SOLR-14151) Make schema components load from packages

2020-10-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209291#comment-17209291 ] ASF subversion and git services commented on SOLR-14151: Commit 0

[GitHub] [lucene-solr] rmuir commented on pull request #1956: LUCENE-9563: Add .editorconfig

2020-10-06 Thread GitBox
rmuir commented on pull request #1956: URL: https://github.com/apache/lucene-solr/pull/1956#issuecomment-704713478 if we want to use https://issues.apache.org/jira/browse/LUCENE-9564 to auto-format code, why add David Smiley's personal code style and not the one supported by the formatter:

[jira] [Commented] (SOLR-14870) gradle build does not validate ref-guide -> javadoc links

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209320#comment-17209320 ] Dawid Weiss commented on SOLR-14870: The "configure" method changes the scope for the

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209325#comment-17209325 ] Dawid Weiss commented on LUCENE-9564: - Well, I expected more resistance. ;) And seri

[jira] [Commented] (LUCENE-9563) Add .editorConfig

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209332#comment-17209332 ] Dawid Weiss commented on LUCENE-9563: - If we decide to move on with automatic code f

<    1   2