uschindler commented on a change in pull request #1837:
URL: https://github.com/apache/lucene-solr/pull/1837#discussion_r484222322
##
File path:
lucene/expressions/src/test/org/apache/lucene/expressions/js/TestCustomFunctions.java
##
@@ -263,7 +263,7 @@ public void testThrowin
uschindler commented on a change in pull request #1837:
URL: https://github.com/apache/lucene-solr/pull/1837#discussion_r484223373
##
File path:
lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptCompiler.java
##
@@ -206,6 +247,12 @@ private Expression comp
dweiss commented on a change in pull request #1837:
URL: https://github.com/apache/lucene-solr/pull/1837#discussion_r484223431
##
File path:
lucene/expressions/src/test/org/apache/lucene/expressions/js/TestCustomFunctions.java
##
@@ -263,7 +263,7 @@ public void testThrowingExc
uschindler commented on a change in pull request #1837:
URL: https://github.com/apache/lucene-solr/pull/1837#discussion_r484229443
##
File path:
lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptCompiler.java
##
@@ -191,9 +220,21 @@ private Expression comp
[
https://issues.apache.org/jira/browse/LUCENE-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191579#comment-17191579
]
Simon Willnauer commented on LUCENE-9504:
-
there is no need for measuring impact
uschindler commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688194137
Hi, I am reviewing: Actually the whole task does not scan any files, as the
"extensions" are wrongly expanded. Should be `**/*.${it}`. I will commit a fix
together with m
uschindler edited a comment on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688194137
Hi, I am reviewing: Actually the whole task does not scan any files, as the
"extensions" are wrongly expanded. Should be `**/*.${it}`. I will commit a fix
together
uschindler commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688199213
Actually for me the splitted tasks take much longer to complete: almost
30 seconds. Maybe it's caused by the progress meter.
uschindler commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688200016
The other problem is that for ":solr" and ":lucene" it scans files twice, as
the fileTree includes again the subprojects!
---
dweiss commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688201937
bq. Actually the whole task does not scan any files
Ah, so this would explain the speedup. :)
Let me reiterate, sorry about the noise.
-
uschindler commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688203183
I committed my changes. You see the duplicate scanning now, because it
reports hadoop errors in `:solr`, becaus ethe exclude does not work correctly.
In fact `:solr` shou
uschindler edited a comment on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688203183
I committed my changes. You see the duplicate scanning now, because it
reports hadoop errors in `:solr`, because the exclude does not work correctly.
In fact `:sol
dweiss commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688210409
I'll take a look, but not now - working.
On Mon, Sep 7, 2020 at 11:38 AM Uwe Schindler
wrote:
> I committed my changes. You see the duplicate scanning now, be
[
https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191617#comment-17191617
]
ASF subversion and git services commented on LUCENE-9509:
-
Commi
mocobeta merged pull request #1835:
URL: https://github.com/apache/lucene-solr/pull/1835
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-9509.
---
Resolution: Fixed
> Refine lucene/BUILD.md (move Solr related contents to top-level README)
[
https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191618#comment-17191618
]
Tomoko Uchida commented on LUCENE-9509:
---
Thanks Erick for reviewing. I also think
[
https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-9509:
--
Fix Version/s: master (9.0)
> Refine lucene/BUILD.md (move Solr related contents to top-level
[
https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191622#comment-17191622
]
Uwe Schindler commented on LUCENE-9509:
---
The way how to build documentation looks
[
https://issues.apache.org/jira/browse/LUCENE-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191638#comment-17191638
]
Jim Ferenczi commented on LUCENE-9507:
--
Thanks for looking [~sokolov] , I was think
Fadi Mohsen created SOLR-14837:
--
Summary: prometheus-exporter: different metrics ports publishes
mixed metrics
Key: SOLR-14837
URL: https://issues.apache.org/jira/browse/SOLR-14837
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fadi Mohsen updated SOLR-14837:
---
Affects Version/s: 8.6.2
> prometheus-exporter: different metrics ports publishes mixed metrics
> ---
[
https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-9509:
--
Attachment: LUCENE-9509-fix-gradle-command-documentation.patch
> Refine lucene/BUILD.md (move
[
https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191658#comment-17191658
]
ASF subversion and git services commented on LUCENE-9509:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191662#comment-17191662
]
Tomoko Uchida commented on LUCENE-9509:
---
I changed the command to build documentat
Erick Erickson created SOLR-14838:
-
Summary: Atomic updates when the destination for a copyField has
stored=true
Key: SOLR-14838
URL: https://issues.apache.org/jira/browse/SOLR-14838
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191714#comment-17191714
]
Joe Doupnik commented on SOLR-14768:
git is already installed and working. Thus o
[
https://issues.apache.org/jira/browse/LUCENE-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191749#comment-17191749
]
Uwe Schindler commented on LUCENE-9509:
---
Thanks!
> Refine lucene/BUILD.md (move S
Mark Robert Miller created SOLR-14839:
-
Summary: Address Alias impl.
Key: SOLR-14839
URL: https://issues.apache.org/jira/browse/SOLR-14839
Project: Solr
Issue Type: Sub-task
Securit
[
https://issues.apache.org/jira/browse/SOLR-14825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191765#comment-17191765
]
Mark Robert Miller commented on SOLR-14825:
---
I think I've gotten the majority o
[
https://issues.apache.org/jira/browse/SOLR-14834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Rafalovitch updated SOLR-14834:
-
Fix Version/s: master (9.0)
> Update all public-visible links from wiki.apache.or
[
https://issues.apache.org/jira/browse/SOLR-14834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Rafalovitch updated SOLR-14834:
-
Priority: Blocker (was: Major)
> Update all public-visible links from wiki.apach
[
https://issues.apache.org/jira/browse/SOLR-14834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191774#comment-17191774
]
Alexandre Rafalovitch commented on SOLR-14834:
--
I am marking this as a block
sigram commented on pull request #1758:
URL: https://github.com/apache/lucene-solr/pull/1758#issuecomment-688426745
FWIW, the scheduler part is now in PR 1831.
This is an automated message from the Apache Git Service.
To resp
sigram commented on a change in pull request #1758:
URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r484517789
##
File path: solr/core/src/java/org/apache/solr/cluster/events/ScheduledEvent.java
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundat
Cassandra Targett created SOLR-14840:
Summary: Convert Overseer Google doc to asciidoc for addition to
Git repo
Key: SOLR-14840
URL: https://issues.apache.org/jira/browse/SOLR-14840
Project: Solr
Alexandre Rafalovitch created SOLR-14841:
Summary: Update RefGuide with information in config files
Key: SOLR-14841
URL: https://issues.apache.org/jira/browse/SOLR-14841
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-14841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Rafalovitch reassigned SOLR-14841:
Assignee: Alexandre Rafalovitch
> Update RefGuide with information in conf
[
https://issues.apache.org/jira/browse/SOLR-14840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191841#comment-17191841
]
Cassandra Targett commented on SOLR-14840:
--
Here is the branch:
https://github.
[
https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191847#comment-17191847
]
Cassandra Targett commented on SOLR-14829:
--
The docs changes are fine from my PO
dweiss commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688492819
You're right, Uwe - the subproject scan inclusion sucks. I don't know how to
avoid it in an elegant way. This could be done with worker API as well but it's
not the same - pe
[
https://issues.apache.org/jira/browse/SOLR-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191849#comment-17191849
]
Alexandre Rafalovitch commented on SOLR-12963:
--
Could we implement this for
Simon Willnauer created LUCENE-9511:
---
Summary: Include StoredFieldsWriter in DWPT accounting
Key: LUCENE-9511
URL: https://issues.apache.org/jira/browse/LUCENE-9511
Project: Lucene - Core
I
s1monw opened a new pull request #1839:
URL: https://github.com/apache/lucene-solr/pull/1839
StoredFieldsWriter might consume some heap space memory that
can have a significant impact on decisions made in the IW if
writers should be stalled or DWPTs should be flushed if memory
setti
[
https://issues.apache.org/jira/browse/SOLR-14815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191853#comment-17191853
]
Mark Robert Miller commented on SOLR-14815:
---
I'm starting to actually work on t
uschindler commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688514787
Hi,
I was able to prevent gradle from scanning duplicates:
```
// Don't go into subprojects (scanned separately).
childProjects.keySet().each{
exclude
uschindler edited a comment on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688514787
Hi,
I was able to prevent gradle from scanning duplicates:
```gradle
// Don't go into subprojects (scanned separately).
childProjects.keySet().each{
uschindler commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688516919
Hi,
this now passes build, but speed is on my laptop (Windows 10) only sligthly
faster: 32s before, 24s with this PR (including configuration and without
gradle da
uschindler commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688517196
The reason why the speed difference is so small may be related in the fact
that "project configuration" (collecting those file trees, one for each
project) take much long
vthacker merged pull request #1816:
URL: https://github.com/apache/lucene-solr/pull/1816
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/LUCENE-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191869#comment-17191869
]
ASF subversion and git services commented on LUCENE-9497:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191870#comment-17191870
]
ASF subversion and git services commented on LUCENE-9497:
-
Commi
vthacker closed pull request #1828:
URL: https://github.com/apache/lucene-solr/pull/1828
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
uschindler commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688524908
I refactored the config a bit (project-specific excludes moved to separate
configure-blocks). I also added `*.md` to the list of scanned files.
Looks ready now.
-
noblepaul merged pull request #1815:
URL: https://github.com/apache/lucene-solr/pull/1815
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191887#comment-17191887
]
ASF subversion and git services commented on SOLR-14151:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Rafalovitch updated SOLR-14097:
-
Attachment: solr_test_no_dir.log
> coreRootDirectory should be solr_home/cores
>
[
https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191890#comment-17191890
]
Noble Paul commented on SOLR-14613:
---
I think we have addressed the API surface area iss
[
https://issues.apache.org/jira/browse/SOLR-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191891#comment-17191891
]
Alexandre Rafalovitch commented on SOLR-14097:
--
This seems broken in 8.6.1.
[
https://issues.apache.org/jira/browse/SOLR-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Rafalovitch updated SOLR-14097:
-
Attachment: solr_test_yes_dir.log
> coreRootDirectory should be solr_home/cores
>
[
https://issues.apache.org/jira/browse/SOLR-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Rafalovitch updated SOLR-14097:
-
Attachment: solr_yes_trace.log
> coreRootDirectory should be solr_home/cores
> --
[
https://issues.apache.org/jira/browse/SOLR-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191900#comment-17191900
]
Alexandre Rafalovitch commented on SOLR-14097:
--
Argh, it seems that this is
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191923#comment-17191923
]
ASF subversion and git services commented on SOLR-14151:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul resolved SOLR-14151.
---
Resolution: Fixed
> Make schema components load from packages
> -
[
https://issues.apache.org/jira/browse/LUCENE-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191925#comment-17191925
]
ASF subversion and git services commented on LUCENE-9497:
-
Commi
Mark Robert Miller created SOLR-14842:
-
Summary: Address Tolerant search feature and tests.
Key: SOLR-14842
URL: https://issues.apache.org/jira/browse/SOLR-14842
Project: Solr
Issue Type:
dweiss commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688642607
bq. 32s before, 24s with this PR
Well, that's 25% faster. The biggest gain should come from running
incrementally? If you modify a file in just one of the projects, o
dweiss commented on a change in pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#discussion_r484674873
##
File path: gradle/validation/validate-source-patterns.gradle
##
@@ -29,50 +33,127 @@ buildscript {
}
}
-configure(rootProject) {
- task("vali
noblepaul commented on pull request #1831:
URL: https://github.com/apache/lucene-solr/pull/1831#issuecomment-688645297
Can we just commit the `ClusterSingleton` as one PR please? `Scheduler` and
`ClusterSingleton` doesn't have to go in together
dweiss commented on a change in pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#discussion_r484678759
##
File path: gradle/validation/precommit.gradle
##
@@ -26,7 +26,6 @@ configure(rootProject) {
dependsOn ":verifyLocks"
dependsOn ":versionsP
sigram edited a comment on pull request #1758:
URL: https://github.com/apache/lucene-solr/pull/1758#issuecomment-688426745
FWIW, the scheduler part is now in PR #1831.
This is an automated message from the Apache Git Service.
noblepaul commented on a change in pull request #1813:
URL: https://github.com/apache/lucene-solr/pull/1813#discussion_r484682298
##
File path: solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java
##
@@ -551,11 +555,29 @@ public AssignStrategyFactory(SolrCloudMa
dweiss commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688650077
I have a suspicion those filetree filters (exclusion filters) are fairly
dumb and scan paths that can't be traversed anyway. I'd have to confirm to be
sure (which I can't do
noblepaul commented on a change in pull request #1813:
URL: https://github.com/apache/lucene-solr/pull/1813#discussion_r484682298
##
File path: solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java
##
@@ -551,11 +555,29 @@ public AssignStrategyFactory(SolrCloudMa
noblepaul commented on a change in pull request #1813:
URL: https://github.com/apache/lucene-solr/pull/1813#discussion_r484682298
##
File path: solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java
##
@@ -551,11 +555,29 @@ public AssignStrategyFactory(SolrCloudMa
uschindler commented on a change in pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#discussion_r484690577
##
File path: gradle/validation/precommit.gradle
##
@@ -26,7 +26,6 @@ configure(rootProject) {
dependsOn ":verifyLocks"
dependsOn ":versi
uschindler commented on a change in pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#discussion_r484691201
##
File path: gradle/validation/precommit.gradle
##
@@ -26,7 +26,6 @@ configure(rootProject) {
dependsOn ":verifyLocks"
dependsOn ":versi
dweiss commented on a change in pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#discussion_r484691497
##
File path: gradle/validation/precommit.gradle
##
@@ -26,7 +26,6 @@ configure(rootProject) {
dependsOn ":verifyLocks"
dependsOn ":versionsP
uschindler commented on a change in pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#discussion_r484692069
##
File path: gradle/validation/validate-source-patterns.gradle
##
@@ -29,50 +33,127 @@ buildscript {
}
}
-configure(rootProject) {
- task("
dweiss commented on a change in pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#discussion_r484691998
##
File path: gradle/validation/precommit.gradle
##
@@ -26,7 +26,6 @@ configure(rootProject) {
dependsOn ":verifyLocks"
dependsOn ":versionsP
80 matches
Mail list logo
