atris commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465515250
##
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Found
atris commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465515893
##
File path: solr/core/src/java/org/apache/solr/servlet/RateLimitManager.java
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache Software Foundation (
atris commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465519971
##
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Found
atris commented on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-669024693
@anshumg @madrob Updated. Please see and let me know if this looks ready to
go.
This is an automated message
anshumg commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465524940
##
File path: solr/solr-ref-guide/src/index.adoc
##
@@ -124,6 +125,8 @@ The *<>* section guides yo
*<>*: This section tells you how to grow a Solr
d
atris commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465527550
##
File path: solr/solr-ref-guide/src/index.adoc
##
@@ -124,6 +125,8 @@ The *<>* section guides yo
*<>*: This section tells you how to grow a Solr
dis
anshumg commented on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-669035416
LGTM. If there's nothing else pending w.r.t. other reviewers, feel free to
merge this in.
This is an automa
anshumg commented on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-669040596
The precommit checks seem to be failing though. please make sure the
precommit and the tests pass as expected before merging.
--
chatman commented on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-669044203
Can you please wait until tomorrow (say 36 hours more) for me to take a
look? Extremely busy with some client work, but I would love to take a look, if
you don't mind. If I
noblepaul closed pull request #1088:
URL: https://github.com/apache/lucene-solr/pull/1088
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
MarcusSorealheis commented on pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711#issuecomment-669052935
Everyone this is ready to go. Thanks @tflobbe for wr
atris commented on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-669054609
Thanks @anshumg !
@chatman Sure. I will leave the PR open until Friday morning IST post which,
barring objections, I plan to merge.
---
MarcusSorealheis commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-669070647
closing this in favor of the finished product:
https://github.com/apache/lucene-solr/pull/1711
Thi
MarcusSorealheis commented on pull request #1710:
URL: https://github.com/apache/lucene-solr/pull/1710#issuecomment-669071729
this was merged via CLI
This is an automated message from the Apache Git Service.
To respond to the
MarcusSorealheis closed pull request #1710:
URL: https://github.com/apache/lucene-solr/pull/1710
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
MarcusSorealheis closed pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
mikemccand commented on pull request #1543:
URL: https://github.com/apache/lucene-solr/pull/1543#issuecomment-669227131
Thinking more above the above proposal, specifically this line, which is OK
for our usage but I think not so great for other users who would like to reduce
or turn off th
[
https://issues.apache.org/jira/browse/SOLR-13972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171495#comment-17171495
]
Jan Høydahl commented on SOLR-13972:
See comment from user list
[https://lists.apach
[
https://issues.apache.org/jira/browse/SOLR-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171530#comment-17171530
]
Houston Putman commented on SOLR-14706:
---
Thanks for testing Gus. I've added the pre
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171518#comment-17171518
]
Michael McCandless commented on LUCENE-9444:
Actually, I think a dedicated h
HoustonPutman commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r465806654
##
File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc
##
@@ -34,17 +34,24 @@ Detailed steps for upgrading a Solr cluster are in the
sec
HoustonPutman opened a new pull request #1717:
URL: https://github.com/apache/lucene-solr/pull/1717
Changing from builds.apache.org to ci-builds.apache.org
This is an automated message from the Apache Git Service.
To respond
gus-asf commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r465871109
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Clause.java
##
@@ -117,10 +117,10 @@ private Clause(Map m) {
st
gus-asf commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r465875461
##
File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc
##
@@ -34,17 +34,24 @@ Detailed steps for upgrading a Solr cluster are in the
section <
tflobbe commented on a change in pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711#discussion_r465922385
##
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##
@@ -406,15 +436,15 @@ static Long getCheckSum(Checksum checksum, F
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171697#comment-17171697
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14702:
--
I plan to me
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171711#comment-17171711
]
Cassandra Targett commented on SOLR-14702:
--
bq. We probably want to rename the "
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171721#comment-17171721
]
Mikhail Khludnev commented on SOLR-14557:
-
Right. {{\{!v="syntax"}}} works as wel
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171720#comment-17171720
]
Mikhail Khludnev commented on SOLR-14557:
-
Right. {{\{!v="syntax"}}} works as wel
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-14557:
Comment: was deleted
(was: Right. {{\{!v="syntax"}}} works as well since it has explicit te
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev closed SOLR-14557.
---
> Unable to parse local params followed by parenthesis like {!lucene}(gigabyte)
> ---
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171726#comment-17171726
]
Cassandra Targett commented on SOLR-14702:
--
bq. Currently it says "leader/follow
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171744#comment-17171744
]
Leonel Atencio commented on SOLR-12367:
---
I'm getting a ClassCastException when uplo
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171744#comment-17171744
]
Leonel Atencio edited comment on SOLR-12367 at 8/5/20, 8:38 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171744#comment-17171744
]
Leonel Atencio edited comment on SOLR-12367 at 8/5/20, 8:39 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171752#comment-17171752
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14702:
--
bq. I could
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171755#comment-17171755
]
Marcus Eagan commented on SOLR-14702:
-
Makes sense to me.
Sent via Superhuman iOS (
tflobbe commented on a change in pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711#discussion_r466006354
##
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##
@@ -406,15 +436,15 @@ static Long getCheckSum(Checksum checksum, F
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171757#comment-17171757
]
David Smiley commented on SOLR-14354:
-
It seems there is reasonable consensus on my p
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171759#comment-17171759
]
Ankur commented on LUCENE-9444:
---
> ...and it returns another class for actually iterating
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171784#comment-17171784
]
David Smiley commented on SOLR-14557:
-
Cool. The only example of this in the ref-guid
tflobbe merged pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171786#comment-17171786
]
ASF subversion and git services commented on SOLR-14702:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171789#comment-17171789
]
ASF subversion and git services commented on SOLR-14702:
Commit 6
unrelational commented on a change in pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711#discussion_r466031051
##
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##
@@ -406,15 +436,15 @@ static Long getCheckSum(Checksum checks
MarcusSorealheis commented on a change in pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711#discussion_r466031953
##
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##
@@ -406,15 +436,15 @@ static Long getCheckSum(Checksum ch
tflobbe opened a new pull request #1718:
URL: https://github.com/apache/lucene-solr/pull/1718
This is just the CHANGES.txt entries, including upgrade notes
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171792#comment-17171792
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14702:
--
Upgrade Note
MarcusSorealheis commented on a change in pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711#discussion_r466033859
##
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##
@@ -406,15 +436,15 @@ static Long getCheckSum(Checksum ch
tflobbe commented on a change in pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711#discussion_r466037673
##
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##
@@ -406,15 +436,15 @@ static Long getCheckSum(Checksum checksum, F
tflobbe commented on a change in pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711#discussion_r466047049
##
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##
@@ -406,15 +436,15 @@ static Long getCheckSum(Checksum checksum, F
[
https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171841#comment-17171841
]
Ilan Ginzburg commented on SOLR-14613:
--
I just pushed to the [PR|https://github.com/
murblanc commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-669606676
The PR has reached what I consider a satisfying and ready to merge state
with the last commit.
Please see some description in the
[Jira](https://issues.apache.org/jira/b
tflobbe opened a new pull request #1719:
URL: https://github.com/apache/lucene-solr/pull/1719
This PR brings the changes from
https://github.com/apache/lucene-solr/pull/1711 into 8.x and add a commit to
bring back compatibility. With this code change, a Solr instance running 8.7
should be
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171848#comment-17171848
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14702:
--
8.x PR: http
tflobbe commented on a change in pull request #1719:
URL: https://github.com/apache/lucene-solr/pull/1719#discussion_r466076118
##
File path: solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java
##
@@ -76,12 +76,12 @@ public void startReplication(boolean switchTran
MarcusSorealheis commented on a change in pull request #1719:
URL: https://github.com/apache/lucene-solr/pull/1719#discussion_r466112781
##
File path: solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java
##
@@ -76,12 +76,12 @@ public void startReplication(boolean s
MarcusSorealheis commented on a change in pull request #1719:
URL: https://github.com/apache/lucene-solr/pull/1719#discussion_r466112890
##
File path: solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java
##
@@ -76,12 +76,12 @@ public void startReplication(boolean s
MarcusSorealheis commented on a change in pull request #1719:
URL: https://github.com/apache/lucene-solr/pull/1719#discussion_r466113106
##
File path: solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java
##
@@ -76,12 +76,12 @@ public void startReplication(boolean s
noblepaul commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-669720088
I think we should we commit the interfaces and one sample impl together
This is an automated message from
[
https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172050#comment-17172050
]
Robert Muir commented on LUCENE-8626:
-
I'm gonna reiterate my numbers: 2/3 of all te
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172059#comment-17172059
]
Noble Paul commented on SOLR-14576:
---
I've changed it to UUID as the key. Plan to commit
[
https://issues.apache.org/jira/browse/SOLR-14654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172061#comment-17172061
]
ASF subversion and git services commented on SOLR-14654:
Commit 6
noblepaul merged pull request #1677:
URL: https://github.com/apache/lucene-solr/pull/1677
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-14654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172070#comment-17172070
]
ASF subversion and git services commented on SOLR-14654:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-14654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul resolved SOLR-14654.
---
Fix Version/s: master (9.0)
Resolution: Fixed
> Remove plugin loading from .system collection
66 matches
Mail list logo
