[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141741#comment-17141741
]
Dawid Weiss commented on LUCENE-9411:
-
{quote}Check/precommit are failing until I cr
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141809#comment-17141809
]
Simon Willnauer commented on LUCENE-8962:
-
It seems like this caused this test f
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141811#comment-17141811
]
Simon Willnauer commented on LUCENE-8962:
-
{quote}
I'm surprised to see that
In
noblepaul commented on a change in pull request #1592:
URL: https://github.com/apache/lucene-solr/pull/1592#discussion_r443408369
##
File path:
solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimClusterStateProvider.java
##
@@ -351,10 +340,10 @@ public void simSetClus
noblepaul commented on pull request #1592:
URL: https://github.com/apache/lucene-solr/pull/1592#issuecomment-647378856
-1
don't commit this
This is an automated message from the Apache Git Service.
To respond to the me
noblepaul commented on pull request #1592:
URL: https://github.com/apache/lucene-solr/pull/1592#issuecomment-647379273
`o -> new HashMap()`
this creates a new lambda class.
OTOH `Utils.NEW_HASHMAP_FUN` is created once and reused everywhere.
--
[
https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141832#comment-17141832
]
Noble Paul commented on SOLR-14579:
---
the NEW_HASHMAP_FUN was added for a purpose (effic
noblepaul commented on pull request #1432:
URL: https://github.com/apache/lucene-solr/pull/1432#issuecomment-647382398
thanks @dsmiley , I shall fix them
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141846#comment-17141846
]
Noble Paul commented on SOLR-14579:
---
people misunderstand lambdas
let's look at a very
[
https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul reassigned SOLR-14579:
-
Assignee: Noble Paul
> Remove SolrJ 'Utils' generic map functions
>
[
https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141860#comment-17141860
]
Andrzej Bialecki commented on SOLR-14579:
-
That's only partially true because Hot
[
https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141874#comment-17141874
]
Noble Paul commented on SOLR-14579:
---
Our code still compiles with java 8 for the curren
[
https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141874#comment-17141874
]
Noble Paul edited comment on SOLR-14579 at 6/22/20, 10:15 AM:
-
Roman Kosenko created SOLR-14585:
Summary: Check the current user in SysV init script
Key: SOLR-14585
URL: https://issues.apache.org/jira/browse/SOLR-14585
Project: Solr
Issue Type: Bug
[
https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141911#comment-17141911
]
Ilan Ginzburg commented on SOLR-14579:
--
I second [~ab] here. When we write non obvio
[
https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141964#comment-17141964
]
Erick Erickson commented on SOLR-14579:
---
Get used to me asking this ;). But will it
[
https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141972#comment-17141972
]
Noble Paul commented on SOLR-14579:
---
Didn't you suppress all the warnings [~erickericks
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141504#comment-17141504
]
Erick Erickson edited comment on LUCENE-9411 at 6/22/20, 12:07 PM:
---
janhoy commented on pull request #1597:
URL: https://github.com/apache/lucene-solr/pull/1597#issuecomment-647483591
There is also a reference in jetty-ssl.xml, which is the defaults to
`./etc/solr-ssl.keystore.jks`. Don't know if it is useful with a default here
at all?
-
mikemccand commented on pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-647487636
Thanks @s1monw @msfroh @msokolov! What an awesome feature and great OSS
collaboration bringing it to Lucene!
---
[
https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142003#comment-17142003
]
Erick Erickson commented on SOLR-14579:
---
I'm still working on it. 9x should compile
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142010#comment-17142010
]
Michael Sokolov commented on LUCENE-8962:
-
Re: the TestIndexWriter failure. I tr
msokolov commented on a change in pull request #1592:
URL: https://github.com/apache/lucene-solr/pull/1592#discussion_r443535745
##
File path:
solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimClusterStateProvider.java
##
@@ -351,10 +340,10 @@ public void simSetClust
mikemccand commented on a change in pull request #1590:
URL: https://github.com/apache/lucene-solr/pull/1590#discussion_r443538263
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -4286,25 +4287,30 @@ private synchronized void
mergeFinish(Merge
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142022#comment-17142022
]
Michael Sokolov commented on LUCENE-9411:
-
Does the presence of a SpotBugs annot
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142026#comment-17142026
]
Michael McCandless commented on LUCENE-8962:
{quote}It seems like this cause
jpountz commented on pull request #1593:
URL: https://github.com/apache/lucene-solr/pull/1593#issuecomment-647511693
I like the CorruptIndexException because it tells me that the problem is
that the file got altered after being written, while I would otherwise wonder
if there is a bug in L
mikemccand commented on a change in pull request #1222:
URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443549705
##
File path:
lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software
mikemccand commented on a change in pull request #1222:
URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443550217
##
File path:
lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java
##
@@ -0,0 +1,202 @@
+/*
Review comment:
I think thi
mikemccand commented on a change in pull request #1222:
URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443549705
##
File path:
lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software
mikemccand commented on a change in pull request #1222:
URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443554965
##
File path:
lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software
Noble Paul created SOLR-14586:
-
Summary: replace the second function parameter in computeIfAbsent
with static vars
Key: SOLR-14586
URL: https://issues.apache.org/jira/browse/SOLR-14586
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-14586:
--
Description:
people misunderstand lambdas
let's look at a very innocuous looking piece of code
{code:j
noblepaul opened a new pull request #1599:
URL: https://github.com/apache/lucene-solr/pull/1599
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
mikemccand commented on a change in pull request #1576:
URL: https://github.com/apache/lucene-solr/pull/1576#discussion_r443573360
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -2144,39 +2145,43 @@ private synchronized boolean
updatePendingM
[
https://issues.apache.org/jira/browse/LUCENE-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142058#comment-17142058
]
Michael McCandless commented on LUCENE-9414:
{quote}[~mikemccand]: I forked
[
https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142059#comment-17142059
]
Michael McCandless commented on LUCENE-9286:
+1 to simply download/extract d
noblepaul commented on pull request #1568:
URL: https://github.com/apache/lucene-solr/pull/1568#issuecomment-647542614
Any benchmark numbers?
This is an automated message from the Apache Git Service.
To respond to the message
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142108#comment-17142108
]
Gus Heck commented on LUCENE-9411:
--
There seem to be a number of Apache projects that h
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142110#comment-17142110
]
Erick Erickson commented on LUCENE-8962:
[~mikemccand] Ever since I changed Solr
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142112#comment-17142112
]
Mike Drob commented on SOLR-14586:
--
Why not simply {{HashMap::new}}
> replace the secon
dsmiley opened a new pull request #1600:
URL: https://github.com/apache/lucene-solr/pull/1600
Convert String and File paths to Path API.
CoreContainer seems to me the proper place for the node to expose key
directories at a node level. It's already doing this. It looked a bit clums
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142110#comment-17142110
]
Erick Erickson edited comment on LUCENE-8962 at 6/22/20, 2:44 PM:
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142118#comment-17142118
]
Mike Drob commented on SOLR-14586:
--
bq. Now imagine that method getting called millions
[
https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142136#comment-17142136
]
Tomoko Uchida commented on LUCENE-9286:
---
My words might not be clear enough...
+1
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142147#comment-17142147
]
Andrzej Bialecki commented on SOLR-14586:
-
[~mdrob] this lambda was probably inli
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142147#comment-17142147
]
Andrzej Bialecki edited comment on SOLR-14586 at 6/22/20, 3:05 PM:
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142173#comment-17142173
]
Erick Erickson commented on LUCENE-9411:
Hmmm, maybe we're OK if we restrict it
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142184#comment-17142184
]
Simon Willnauer commented on LUCENE-8962:
-
I can reproduce this every 10 iterati
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142190#comment-17142190
]
Erick Erickson commented on LUCENE-8962:
Sounds like it may _not_ be related to
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer updated LUCENE-8962:
Attachment: failure_log.txt
> Can we merge small segments during refresh, for faster searc
[
https://issues.apache.org/jira/browse/SOLR-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142196#comment-17142196
]
Mike Drob commented on SOLR-14576:
--
Do you have GC logs or a heap dump analysis highligh
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142197#comment-17142197
]
Simon Willnauer commented on LUCENE-8962:
-
I attached a log file with a failure
[
https://issues.apache.org/jira/browse/SOLR-8885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142206#comment-17142206
]
Mike Drob commented on SOLR-8885:
-
[~marcussorealheis] - this probably interests you.
> U
[
https://issues.apache.org/jira/browse/LUCENE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved LUCENE-6232.
---
Resolution: Duplicate
This was cleaned up by the recent work on removing warnings.
> Replace ValueS
[
https://issues.apache.org/jira/browse/LUCENE-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved LUCENE-7631.
---
Assignee: Erick Erickson
Resolution: Duplicate
Handled by Erick elsewhere.
> Enforce javac wa
[
https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142221#comment-17142221
]
Michael Sokolov commented on LUCENE-9286:
-
[~tomoko] thanks! I think you could s
murblanc merged pull request #1575:
URL: https://github.com/apache/lucene-solr/pull/1575
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142227#comment-17142227
]
ASF subversion and git services commented on SOLR-12823:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142226#comment-17142226
]
ASF subversion and git services commented on SOLR-12823:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilan Ginzburg reassigned SOLR-12823:
Assignee: Ilan Ginzburg (was: Mike Drob)
> remove clusterstate.json in Lucene/Solr 9.0
>
murblanc commented on pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#issuecomment-647633475
@madrob do you want to have another look or shall I merge it? (now that I
can :)
This is an automated mess
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142249#comment-17142249
]
Mike Drob commented on SOLR-14586:
--
HashMap::new doesn't work here because computeIfAbse
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142264#comment-17142264
]
Andrzej Bialecki commented on SOLR-14586:
-
There's some back story behind this ..
[
https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilan Ginzburg reassigned SOLR-14546:
Assignee: Ilan Ginzburg
> OverseerTaskProcessor can process messages out of order
> --
Ilan Ginzburg created SOLR-14587:
Summary: Need a test for SolrCloud Zookeeper chroot
Key: SOLR-14587
URL: https://issues.apache.org/jira/browse/SOLR-14587
Project: Solr
Issue Type: Test
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilan Ginzburg resolved SOLR-12823.
--
Resolution: Fixed
> remove clusterstate.json in Lucene/Solr 9.0
> -
s1monw commented on a change in pull request #1601:
URL: https://github.com/apache/lucene-solr/pull/1601#discussion_r443727012
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -3234,15 +3234,23 @@ private long prepareCommitInternal() throws IOEx
s1monw opened a new pull request #1601:
URL: https://github.com/apache/lucene-solr/pull/1601
IW might drop segments that are merged into a fully deleted segment on the
floor
and deletes the newly created files right away. We should not include these
segments
in a commit since we can'
s1monw commented on pull request #1601:
URL: https://github.com/apache/lucene-solr/pull/1601#issuecomment-647679593
@mikemccand can you take a look
This is an automated message from the Apache Git Service.
To respond to the m
s1monw commented on a change in pull request #1601:
URL: https://github.com/apache/lucene-solr/pull/1601#discussion_r443727356
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -4341,27 +4342,33 @@ private synchronized void
mergeFinish(MergePoli
s1monw commented on a change in pull request #1590:
URL: https://github.com/apache/lucene-solr/pull/1590#discussion_r443728610
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -4286,25 +4287,30 @@ private synchronized void
mergeFinish(MergePoli
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142303#comment-17142303
]
Simon Willnauer commented on LUCENE-8962:
-
I opened a PR [here|https://github.co
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142309#comment-17142309
]
Mike Drob commented on SOLR-14586:
--
Oh, interesting. Would love to see the perf numbers
murblanc commented on pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#issuecomment-647690709
Something went wrong here it seems when I tried to add just one commit for
CHANGES.txt
Need to sort this out, possibly cancelling this PR and starting fresh if I
don't m
mikemccand commented on a change in pull request #1601:
URL: https://github.com/apache/lucene-solr/pull/1601#discussion_r443772827
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -4341,27 +4342,33 @@ private synchronized void
mergeFinish(Merge
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142370#comment-17142370
]
Andrzej Bialecki commented on SOLR-14586:
-
It was relatively recently (a couple m
megancarey commented on a change in pull request #1592:
URL: https://github.com/apache/lucene-solr/pull/1592#discussion_r443788954
##
File path:
solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimClusterStateProvider.java
##
@@ -351,10 +340,10 @@ public void simSetClu
megancarey commented on a change in pull request #1592:
URL: https://github.com/apache/lucene-solr/pull/1592#discussion_r443788954
##
File path:
solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimClusterStateProvider.java
##
@@ -351,10 +340,10 @@ public void simSetClu
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142380#comment-17142380
]
David Smiley commented on LUCENE-8962:
--
bq. If we decide to do this in the future w
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142384#comment-17142384
]
Megan Carey commented on SOLR-14586:
Admittedly, I was not aware that Java lambda fun
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142388#comment-17142388
]
Simon Willnauer commented on LUCENE-8962:
-
[~msoko...@gmail.com] I think I have
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142389#comment-17142389
]
Simon Willnauer commented on LUCENE-8962:
-
This would also explain the failure I
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142395#comment-17142395
]
Michael McCandless commented on LUCENE-8962:
{quote}[~mikemccand] WDYT I thi
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless reopened LUCENE-8962:
Reopening to get to the bottom of {{updateDocument}}'s atomicity.
I am also curious w
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142410#comment-17142410
]
Michael Sokolov commented on LUCENE-8962:
-
OK I'll revert from master and branch
[
https://issues.apache.org/jira/browse/LUCENE-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142414#comment-17142414
]
David Smiley commented on LUCENE-9414:
--
https://issues.apache.org/jira/browse/LUCEN
[
https://issues.apache.org/jira/browse/SOLR-14581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142416#comment-17142416
]
David Smiley commented on SOLR-14581:
-
Commits themselves take time too so we can't r
dsmiley commented on pull request #1222:
URL: https://github.com/apache/lucene-solr/pull/1222#issuecomment-647776562
The `setCheapLimitConcurrentMergeSegments` limit was simply a precautionary
addition given that I knew these cheap merges would up the write amplification
and so I wanted to
dsmiley commented on a change in pull request #1222:
URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443837114
##
File path:
lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Fo
dsmiley commented on a change in pull request #1222:
URL: https://github.com/apache/lucene-solr/pull/1222#discussion_r443837114
##
File path:
lucene/core/src/java/org/apache/lucene/index/EagerCheapMergePolicy.java
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Fo
David Smiley created LUCENE-9415:
Summary: Rename MergePolicy.size to sizeInBytes
Key: LUCENE-9415
URL: https://issues.apache.org/jira/browse/LUCENE-9415
Project: Lucene - Core
Issue Type: Im
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142431#comment-17142431
]
ASF subversion and git services commented on LUCENE-8962:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142433#comment-17142433
]
ASF subversion and git services commented on LUCENE-8962:
-
Commi
murblanc commented on pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#issuecomment-647793592
I guess I didn't take the shortest route to rebase this PR, but at least the
diff is easy to see now.
I plan to merge this tomorrow, in case somebody wants to have a look
[
https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142446#comment-17142446
]
Ilan Ginzburg commented on SOLR-14546:
--
I will merge this tomorrow (after re running
tflobbe opened a new pull request #1602:
URL: https://github.com/apache/lucene-solr/pull/1602
LUCENE-8962 added the ability to merge segments synchronously on commit.
This isn't done by default and the default MergePolicy won't do it, but custom
merge policies can take advantage of this. S
tflobbe merged pull request #1596:
URL: https://github.com/apache/lucene-solr/pull/1596
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tflobbe merged pull request #1566:
URL: https://github.com/apache/lucene-solr/pull/1566
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142488#comment-17142488
]
ASF subversion and git services commented on SOLR-14554:
Commit a
1 - 100 of 114 matches
Mail list logo
