[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1432: SOLR-14404 CoreContainer level custom requesthandlers

2020-05-17 Thread GitBox
noblepaul commented on a change in pull request #1432: URL: https://github.com/apache/lucene-solr/pull/1432#discussion_r426237404 ## File path: solr/core/src/java/org/apache/solr/pkg/PackageListeners.java ## @@ -63,13 +63,13 @@ public synchronized void removeListener(Listener l

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1432: SOLR-14404 CoreContainer level custom requesthandlers

2020-05-17 Thread GitBox
noblepaul commented on a change in pull request #1432: URL: https://github.com/apache/lucene-solr/pull/1432#discussion_r426237573 ## File path: solr/core/src/test/org/apache/solr/handler/TestContainerPlugin.java ## @@ -0,0 +1,250 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [lucene-solr] uschindler commented on pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-17 Thread GitBox
uschindler commented on pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#issuecomment-629789289 Hi, I split the documentation tasks of Lucene and Solr, so you can also just build lucene or just solr documentation (still building all dependencies in a correct way)

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1522: LUCENE-9374: Add doclumentationLint gradle task

2020-05-17 Thread GitBox
uschindler commented on a change in pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#discussion_r426146539 ## File path: gradle/validation/documentation-lint.gradle ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1522: LUCENE-9374: Add doclumentationLint gradle task

2020-05-17 Thread GitBox
uschindler commented on a change in pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#discussion_r426256097 ## File path: gradle/validation/documentation-lint.gradle ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1522: LUCENE-9374: Add doclumentationLint gradle task

2020-05-17 Thread GitBox
uschindler commented on a change in pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#discussion_r426256285 ## File path: gradle/validation/documentation-lint.gradle ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1522: LUCENE-9374: Add doclumentationLint gradle task

2020-05-17 Thread GitBox
uschindler commented on a change in pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#discussion_r426256449 ## File path: gradle/validation/documentation-lint.gradle ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1522: LUCENE-9374: Add doclumentationLint gradle task

2020-05-17 Thread GitBox
uschindler commented on a change in pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#discussion_r426256449 ## File path: gradle/validation/documentation-lint.gradle ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene-solr] uschindler merged pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-17 Thread GitBox
uschindler merged pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109459#comment-17109459 ] ASF subversion and git services commented on LUCENE-9321: - Commi

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1522: LUCENE-9374: Add doclumentationLint gradle task

2020-05-17 Thread GitBox
uschindler commented on a change in pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#discussion_r426257605 ## File path: gradle/validation/documentation-lint.gradle ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1522: LUCENE-9374: Add doclumentationLint gradle task

2020-05-17 Thread GitBox
uschindler commented on a change in pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#discussion_r426258537 ## File path: gradle/validation/documentation-lint.gradle ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1522: LUCENE-9374: Add checkBrokenLinks gradle task

2020-05-17 Thread GitBox
mocobeta commented on a change in pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#discussion_r426263459 ## File path: gradle/validation/documentation-lint.gradle ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [lucene-solr] mocobeta commented on pull request #1522: LUCENE-9374: Add checkBrokenLinks gradle task

2020-05-17 Thread GitBox
mocobeta commented on pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#issuecomment-629801544 I changed the top-level 'documentationLint' task name to 'checkBrokenLinks' This is an automated message fr

[jira] [Updated] (LUCENE-6807) AbstractRangeQueryNode toQueryString not working as intended

2020-05-17 Thread Peter Barna (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Barna updated LUCENE-6807: Attachment: LUCENE-6807-option1.patch > AbstractRangeQueryNode toQueryString not working as intend

[jira] [Updated] (LUCENE-6807) AbstractRangeQueryNode toQueryString not working as intended

2020-05-17 Thread Peter Barna (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Barna updated LUCENE-6807: Status: Open (was: Patch Available) > AbstractRangeQueryNode toQueryString not working as intende

[jira] [Commented] (SOLR-12336) Remove Filter from Solr

2020-05-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109539#comment-17109539 ] David Smiley commented on SOLR-12336: - I see some inconsistency in what some "constan

[jira] [Updated] (LUCENE-6807) AbstractRangeQueryNode toQueryString not working as intended

2020-05-17 Thread Peter Barna (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Barna updated LUCENE-6807: Attachment: LUCENE-6807-option2.patch > AbstractRangeQueryNode toQueryString not working as intend

[jira] [Updated] (LUCENE-6807) AbstractRangeQueryNode toQueryString not working as intended

2020-05-17 Thread Peter Barna (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Barna updated LUCENE-6807: Attachment: LUCENE-6807-option3.patch > AbstractRangeQueryNode toQueryString not working as intend

[jira] [Updated] (LUCENE-6807) AbstractRangeQueryNode toQueryString not working as intended

2020-05-17 Thread Peter Barna (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Barna updated LUCENE-6807: Status: Patch Available (was: Open) > AbstractRangeQueryNode toQueryString not working as intende

[jira] [Updated] (SOLR-14476) Add percentiles and standard deviation aggregations to stats, facet and timeseries Streaming Expressions

2020-05-17 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14476: -- Attachment: SOLR-14476.patch > Add percentiles and standard deviation aggregations to stats, fa

[jira] [Updated] (SOLR-14476) Add percentiles and standard deviation aggregations to stats, facet and timeseries Streaming Expressions

2020-05-17 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14476: -- Attachment: (was: Screen Shot 2020-05-15 at 11.32.26 AM.png) > Add percentiles and standard

[jira] [Updated] (SOLR-14476) Add percentiles and standard deviation aggregations to stats, facet and timeseries Streaming Expressions

2020-05-17 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14476: -- Description: This ticket will add the *per* (percentile) and *std* (standard deviation)  aggreg

[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 8.0

2020-05-17 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109611#comment-17109611 ] Erick Erickson commented on SOLR-12823: --- [~murblanc] Responding to your dev-list q

[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 8.0

2020-05-17 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109625#comment-17109625 ] Ilan Ginzburg commented on SOLR-12823: -- Thanks [~erickerickson]. After implementing

[jira] [Commented] (LUCENE-6807) AbstractRangeQueryNode toQueryString not working as intended

2020-05-17 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109668#comment-17109668 ] Lucene/Solr QA commented on LUCENE-6807: | (/) *{color:green}+1 overall{color}*

[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 8.0

2020-05-17 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109678#comment-17109678 ] Erick Erickson commented on SOLR-12823: --- Sounds like you're on top of it. Yeah, upd

[jira] [Comment Edited] (SOLR-12823) remove clusterstate.json in Lucene/Solr 8.0

2020-05-17 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109682#comment-17109682 ] Ilan Ginzburg edited comment on SOLR-12823 at 5/17/20, 10:24 PM: --

[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 8.0

2020-05-17 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109682#comment-17109682 ] Ilan Ginzburg commented on SOLR-12823: -- When {{/clusterstate.json}} is not empty Sol

[jira] [Updated] (SOLR-14482) Fix compile-time warnings in solr/search/facet

2020-05-17 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14482: -- Summary: Fix compile-time warnings in solr/search/facet (was: Fix compile-time warnings in sol

[jira] [Created] (SOLR-14495) Get warnings out of solr/search/function

2020-05-17 Thread Erick Erickson (Jira)
Erick Erickson created SOLR-14495: - Summary: Get warnings out of solr/search/function Key: SOLR-14495 URL: https://issues.apache.org/jira/browse/SOLR-14495 Project: Solr Issue Type: Sub-task

[GitHub] [lucene-solr] dsmiley commented on pull request #1523: SOLR-14494: Refactor BlockJoin to not use Filter

2020-05-17 Thread GitBox
dsmiley commented on pull request #1523: URL: https://github.com/apache/lucene-solr/pull/1523#issuecomment-629888596 Just checking -- you have no concerns my simplification of use of the cache, and caching the BitSetProducer as the value instead of some Filter/Query wrapper? And I'm

[jira] [Updated] (SOLR-14476) Add percentiles and standard deviation aggregations to stats, facet and timeseries Streaming Expressions

2020-05-17 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14476: -- Attachment: SOLR-14476.patch > Add percentiles and standard deviation aggregations to stats, fa

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1440: LUCENE-9330: Make SortFields responsible for index sorting and serialization

2020-05-17 Thread GitBox
jpountz commented on a change in pull request #1440: URL: https://github.com/apache/lucene-solr/pull/1440#discussion_r426378746 ## File path: lucene/core/src/java/org/apache/lucene/search/SortedNumericSortField.java ## @@ -83,6 +89,86 @@ public SortedNumericSortField(String fi

[GitHub] [lucene-solr] dsmiley opened a new pull request #1524: SOLR-XXXX: Rewrite Hash query

2020-05-17 Thread GitBox
dsmiley opened a new pull request #1524: URL: https://github.com/apache/lucene-solr/pull/1524 * Simpler * Don't use Filter (to be removed) * Do use TwoPhaseIterator, not PostFilter * Don't pre-compute matching docs (wasteful) * Support more fields, and more field types * Faste

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1522: LUCENE-9374: Add checkBrokenLinks gradle task

2020-05-17 Thread GitBox
uschindler commented on a change in pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#discussion_r426401368 ## File path: gradle/validation/documentation-lint.gradle ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or