[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-05-01 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097678#comment-17097678 ] Mike Drob commented on SOLR-13289: -- Based on my understanding, I favor the boolean appro

[jira] [Created] (SOLR-14454) support for UTF-8 (string) types with DocValuesType.BINARY

2020-05-01 Thread Michael Gibney (Jira)
Michael Gibney created SOLR-14454: - Summary: support for UTF-8 (string) types with DocValuesType.BINARY Key: SOLR-14454 URL: https://issues.apache.org/jira/browse/SOLR-14454 Project: Solr Iss

[GitHub] [lucene-solr] magibney opened a new pull request #1478: SOLR-14454: support for UTF-8 (string) types with DocValuesType.BINARY

2020-05-01 Thread GitBox
magibney opened a new pull request #1478: URL: https://github.com/apache/lucene-solr/pull/1478 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [lucene-solr] madrob commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
madrob commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418739528 ## File path: solr/core/src/java/org/apache/solr/response/GeoJSONResponseWriter.java ## @@ -292,11 +293,18 @@ else if(geo instanceof WriteableGeoJSON)

[jira] [Commented] (SOLR-14454) support for UTF-8 (string) types with DocValuesType.BINARY

2020-05-01 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097683#comment-17097683 ] Michael Gibney commented on SOLR-14454: --- [PR #1478|https://github.com/apache/lucene

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418748102 ## File path: solr/core/src/java/org/apache/solr/response/GeoJSONResponseWriter.java ## @@ -292,11 +293,18 @@ else if(geo instanceof WriteableGeoJSON

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418749058 ## File path: solr/core/src/java/org/apache/solr/response/JSONWriter.java ## @@ -132,11 +133,16 @@ public void writeSolrDocument(String name, SolrDocu

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418750165 ## File path: solr/core/src/java/org/apache/solr/search/MaxScoreCollector.java ## @@ -37,9 +37,7 @@ public float getMaxScore() { @Override pub

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-05-01 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097689#comment-17097689 ] David Smiley commented on SOLR-13289: - Yeah; lets just go with a simple-to-understand

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418752582 ## File path: solr/core/src/java/org/apache/solr/search/QueryResultKey.java ## @@ -65,6 +70,7 @@ public QueryResultKey(Query query, List filters, Sort

[GitHub] [lucene-solr] anshumg commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
anshumg commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418678327 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -401,6 +403,14 @@ public void process(ResponseBuilder rb

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418756851 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -401,6 +403,14 @@ public void process(ResponseBuilder rb

[GitHub] [lucene-solr] madrob commented on a change in pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-01 Thread GitBox
madrob commented on a change in pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#discussion_r418758313 ## File path: solr/core/src/test/org/apache/solr/security/PrincipalWithUserRoles.java ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [lucene-solr] janhoy commented on pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-01 Thread GitBox
janhoy commented on pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#issuecomment-622592651 > Wait, what happened to the ref guide changes? Hmm, will try to get them back This is an automated mess

[GitHub] [lucene-solr] uschindler opened a new pull request #1479: LUCENE-9278: Improved options file creation

2020-05-01 Thread GitBox
uschindler opened a new pull request #1479: URL: https://github.com/apache/lucene-solr/pull/1479 Improved version of the options file creator in the renderJavadocs task: All parameters are escaped automatically, arguments don't need to be strings (they are converted during building options

[jira] [Commented] (SOLR-13132) Improve JSON "terms" facet performance when sorted by relatedness

2020-05-01 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097725#comment-17097725 ] Chris M. Hostetter commented on SOLR-13132: --- {quote}... If you don't think it's

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-01 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097726#comment-17097726 ] Uwe Schindler commented on LUCENE-9278: --- Here is a new PR: https://github.com/apac

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-05-01 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r418772556 ## File path: solr/core/src/java/org/apache/solr/response/JSONWriter.java ## @@ -132,11 +133,16 @@ public void writeSolrDocument(String name, SolrDocu

[GitHub] [lucene-solr] uschindler commented on pull request #1479: LUCENE-9278: Improved options file creation

2020-05-01 Thread GitBox
uschindler commented on pull request #1479: URL: https://github.com/apache/lucene-solr/pull/1479#issuecomment-622603848 Example options file like created on my computer: ``` -overview 'C:\\Users\\Uwe Schindler\\Projects\\lucene\\trunk-lusolr1\\lucene\\core\\src\\java\\overview.htm

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-05-01 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097729#comment-17097729 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-13289: -- Sounds good.

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1479: LUCENE-9278: Improved options file creation

2020-05-01 Thread GitBox
uschindler edited a comment on pull request #1479: URL: https://github.com/apache/lucene-solr/pull/1479#issuecomment-622603848 Example options file like created on my computer: ``` -overview 'C:\\Users\\Uwe Schindler\\Projects\\lucene\\trunk-lusolr1\\lucene\\core\\src\\java\\overv

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1479: LUCENE-9278: Improved options file creation

2020-05-01 Thread GitBox
uschindler edited a comment on pull request #1479: URL: https://github.com/apache/lucene-solr/pull/1479#issuecomment-622603848 Example options file like created on my computer: ``` -overview 'C:\\Users\\Uwe Schindler\\Projects\\lucene\\trunk-lusolr1\\lucene\\core\\src\\java\\overv

[GitHub] [lucene-solr] janhoy commented on a change in pull request #341: SOLR-12131: ExternalRoleRuleBasedAuthorizationPlugin

2020-05-01 Thread GitBox
janhoy commented on a change in pull request #341: URL: https://github.com/apache/lucene-solr/pull/341#discussion_r418774258 ## File path: solr/solr-ref-guide/src/rule-based-authorization-plugin.adoc ## @@ -64,6 +66,34 @@ There are several things defined in this example: <5> T

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418779755 ## File path: solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java ## @@ -24,29 +31,26 @@ import org.apache.solr.core.CoreCont

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1471: Revised SOLR-14014 PR Against Master

2020-05-01 Thread GitBox
MarcusSorealheis commented on a change in pull request #1471: URL: https://github.com/apache/lucene-solr/pull/1471#discussion_r418779981 ## File path: solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java ## @@ -24,29 +31,26 @@ import org.apache.solr.core.CoreCont

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
uschindler commented on a change in pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#discussion_r418783252 ## File path: gradle/documentation/documentation.gradle ## @@ -34,4 +36,11 @@ configure(subprojects.findAll { it.path == ':lucene' || it.path == '

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
uschindler commented on a change in pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#discussion_r418783353 ## File path: gradle/documentation/markdown.gradle ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
uschindler commented on a change in pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#discussion_r418783252 ## File path: gradle/documentation/documentation.gradle ## @@ -34,4 +36,11 @@ configure(subprojects.findAll { it.path == ':lucene' || it.path == '

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097754#comment-17097754 ] Tomoko Uchida commented on LUCENE-9321: --- As to precommit / javadoc linting, at the

[jira] [Comment Edited] (LUCENE-9321) Port documentation task to gradle

2020-05-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097754#comment-17097754 ] Tomoko Uchida edited comment on LUCENE-9321 at 5/2/20, 12:16 AM: -

[jira] [Commented] (LUCENE-9354) Refresh French stop words to remove homonyms

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097771#comment-17097771 ] ASF subversion and git services commented on LUCENE-9354: - Commi

[jira] [Commented] (LUCENE-9354) Refresh French stop words to remove homonyms

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097772#comment-17097772 ] ASF subversion and git services commented on LUCENE-9354: - Commi

[jira] [Commented] (LUCENE-9354) Refresh French stop words to remove homonyms

2020-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097770#comment-17097770 ] ASF subversion and git services commented on LUCENE-9354: - Commi

[jira] [Assigned] (LUCENE-9354) Refresh French stop words to remove homonyms

2020-05-01 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir reassigned LUCENE-9354: --- Assignee: Robert Muir > Refresh French stop words to remove homonyms >

[jira] [Updated] (LUCENE-9354) Refresh French stop words to remove homonyms

2020-05-01 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9354: Fix Version/s: trunk > Refresh French stop words to remove homonyms >

[jira] [Resolved] (LUCENE-9354) Refresh French stop words to remove homonyms

2020-05-01 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9354. - Resolution: Fixed Thanks [~philippe@camellia] for submitting these improvements to snowball and

[GitHub] [lucene-solr] mocobeta commented on pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
mocobeta commented on pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#issuecomment-622650279 I was not aware of that this task depends on projects' relative paths. To me, before proceeding it we need to manage to reach a consensus about the destination (output) dir

[GitHub] [lucene-solr] mocobeta commented on pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-01 Thread GitBox
mocobeta commented on pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#issuecomment-622650749 I am not sure if it's worth here, "render-javadoc.gradle" has a utility method to convert project path into output doc folder path: https://github.com/apache/lucene-solr/bl

[jira] [Commented] (LUCENE-9355) missing releases from testbackwardscompatibility

2020-05-01 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097799#comment-17097799 ] Noble Paul commented on LUCENE-9355: How do you see this error? [~janhoy] any inputs

<    1   2