[jira] [Updated] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-28 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-14237: Attachment: SOLR-14237-2.patch Screenshot from 2020-04-28 12-48-45.p

[jira] [Comment Edited] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-28 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094236#comment-17094236 ] Ishan Chattopadhyaya edited comment on SOLR-14237 at 4/28/20, 7:25 AM:

[jira] [Updated] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-28 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-14237: Attachment: Screenshot from 2020-04-28 12-48-45.png SOLR-14237-2.pat

[jira] [Updated] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-28 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-14237: Attachment: (was: Screenshot from 2020-04-28 12-48-45.png) > Add authenticated

[jira] [Updated] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-28 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-14237: Attachment: (was: SOLR-14237-2.patch) > Add authenticated user principal in Sol

[jira] [Commented] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-28 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094244#comment-17094244 ] Noble Paul commented on SOLR-14237: --- The changes to the Authorization plugin is fine. g

[jira] [Commented] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-28 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094252#comment-17094252 ] Ishan Chattopadhyaya commented on SOLR-14237: - Thanks [~noble.paul]. I'll com

[jira] [Commented] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-28 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094254#comment-17094254 ] Ishan Chattopadhyaya commented on SOLR-14237: - [~moshebla] please review. >

[jira] [Assigned] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-28 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-14237: -- Assignee: Ishan Chattopadhyaya (was: Jan Høydahl) > Add authenticated user principal in Solr

[jira] [Commented] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-28 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094288#comment-17094288 ] Jan Høydahl commented on SOLR-14237: Nice! Perhaps this can be a starting point for

[jira] [Assigned] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-28 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-14237: -- Assignee: Jan Høydahl (was: Ishan Chattopadhyaya) > Add authenticated user principal in Solr

[jira] [Commented] (SOLR-14237) Add authenticated user principal in Solr admin UI

2020-04-28 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094296#comment-17094296 ] Ishan Chattopadhyaya commented on SOLR-14237: - {quote}Imagine if we could som

[jira] [Commented] (SOLR-14428) FuzzyQuery has severe memory usage in 8.5

2020-04-28 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094304#comment-17094304 ] Alan Woodward commented on SOLR-14428: -- There's some prior art on this one: https:/

[jira] [Commented] (SOLR-14428) FuzzyQuery has severe memory usage in 8.5

2020-04-28 Thread Colvin Cowie (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094309#comment-17094309 ] Colvin Cowie commented on SOLR-14428: - {quote}The QueryResultKey could cache by the o

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2020-04-28 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094321#comment-17094321 ] Alan Woodward commented on LUCENE-8811: --- Hi [~zabetak], the idea is to try and pre

[jira] [Updated] (SOLR-14409) Existing violations allow bypassing policy rules when adding new replicas

2020-04-28 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-14409: Priority: Blocker (was: Critical) > Existing violations allow bypassing policy rules when

[jira] [Commented] (SOLR-14409) Existing violations allow bypassing policy rules when adding new replicas

2020-04-28 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094356#comment-17094356 ] Andrzej Bialecki commented on SOLR-14409: - Escalating to Blocker - doesn't make s

[GitHub] [lucene-solr] iverase commented on pull request #1324: LUCENE-9033 Update ReleaseWizard for new website instructions

2020-04-28 Thread GitBox
iverase commented on pull request #1324: URL: https://github.com/apache/lucene-solr/pull/1324#issuecomment-620513754 Thanks @janhoy, I will review it in the next few days. Thanks you so much! This is an automated message from

[GitHub] [lucene-solr] janhoy commented on pull request #1424: Enable shared store via system property only

2020-04-28 Thread GitBox
janhoy commented on pull request #1424: URL: https://github.com/apache/lucene-solr/pull/1424#issuecomment-620517628 Please link this PR with SOLR-13101 by prefixing the title. This is an automated message from the Apache Git

[GitHub] [lucene-solr] janhoy commented on pull request #807: Remove solr.jetty.https.port when SSL is not used

2020-04-28 Thread GitBox
janhoy commented on pull request #807: URL: https://github.com/apache/lucene-solr/pull/807#issuecomment-620518940 @upendrasoft can you please file a JIRA issue for this and prefix the title of the PR with the JIRA number? Also add a line to CHANGES.txt. Also see the rest of the checklist a

[jira] [Commented] (SOLR-14428) FuzzyQuery has severe memory usage in 8.5

2020-04-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094401#comment-17094401 ] Adrien Grand commented on SOLR-14428: - We currently store automata on the Query becau

[jira] [Commented] (SOLR-14428) FuzzyQuery has severe memory usage in 8.5

2020-04-28 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094411#comment-17094411 ] Alan Woodward commented on SOLR-14428: -- I think we can try building the automata in

[jira] [Updated] (LUCENE-9089) FST.Builder with fluent-style constructor

2020-04-28 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-9089: -- Attachment: fix-fst-package-summary.patch > FST.Builder with fluent-style constructor > --

[jira] [Commented] (LUCENE-9089) FST.Builder with fluent-style constructor

2020-04-28 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094469#comment-17094469 ] Tomoko Uchida commented on LUCENE-9089: --- Hi, I happened to notice that the packag

[jira] [Commented] (SOLR-14173) Ref Guide Redesign

2020-04-28 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094477#comment-17094477 ] Cassandra Targett commented on SOLR-14173: -- bq. You could share on the user-list

[jira] [Comment Edited] (SOLR-14173) Ref Guide Redesign

2020-04-28 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094477#comment-17094477 ] Cassandra Targett edited comment on SOLR-14173 at 4/28/20, 12:58 PM: --

[jira] [Created] (SOLR-14441) Upgrade Tika to 1.24.1

2020-04-28 Thread mibo (Jira)
mibo created SOLR-14441: --- Summary: Upgrade Tika to 1.24.1 Key: SOLR-14441 URL: https://issues.apache.org/jira/browse/SOLR-14441 Project: Solr Issue Type: Task Security Level: Public (Default Secu

[jira] [Resolved] (SOLR-14441) Upgrade Tika to 1.24.1

2020-04-28 Thread mibo (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mibo resolved SOLR-14441. - Resolution: Duplicate Sorry, wrongly created duplicate of: https://issues.apache.org/jira/browse/SOLR-14439 > U

[jira] [Updated] (SOLR-11005) inconsistency when maxShardsPerNode used along with policies

2020-04-28 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett updated SOLR-11005: - Fix Version/s: (was: 7.3) (was: 8.0) > inconsistency when maxS

[jira] [Resolved] (SOLR-14276) At various times when we restart Solr or following a hard reboot, Solr generates multiple replicas beyond the defined amount

2020-04-28 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-14276. Resolution: Invalid Hi Jason, As a community we use the JIRA bugtracker for known or suspe

[jira] [Updated] (LUCENE-9087) Should the BKD tree use a fixed maxPointsInLeafNode?

2020-04-28 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-9087: - Attachment: Study of BKD tree performance with different values for max points per leaf.pdf

[GitHub] [lucene-solr] madrob commented on pull request #1463: SOLR-14440 Cert Auth plugin

2020-04-28 Thread GitBox
madrob commented on pull request #1463: URL: https://github.com/apache/lucene-solr/pull/1463#issuecomment-620725921 > Would it be useful to be able to configure from where to pull the username that will be passed in to Solr I think so, but that is probably better with something like

[jira] [Created] (SOLR-14442) bin/solr to attempt jstack before killing hung Solr instance

2020-04-28 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-14442: -- Summary: bin/solr to attempt jstack before killing hung Solr instance Key: SOLR-14442 URL: https://issues.apache.org/jira/browse/SOLR-14442 Project: Solr

[GitHub] [lucene-solr] iverase opened a new pull request #1464: LUCENE-9087: Build always trees with full leaves and lower the default value for maxPointsPerLeafNode

2020-04-28 Thread GitBox
iverase opened a new pull request #1464: URL: https://github.com/apache/lucene-solr/pull/1464 This commit changes the logic used to build BKD trees to always construct trees with full leaves (except the last one). This change gives more control in the expected behaviour of the tree. In add

[jira] [Updated] (SOLR-14442) bin/solr to attempt jstack before killing hung Solr instance

2020-04-28 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-14442: --- Attachment: SOLR-14442.patch > bin/solr to attempt jstack before killing hung Solr in

[jira] [Commented] (SOLR-14442) bin/solr to attempt jstack before killing hung Solr instance

2020-04-28 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094680#comment-17094680 ] Christine Poerschke commented on SOLR-14442: Attached work-in-progress patch

[jira] [Commented] (LUCENE-9087) Should the BKD tree use a fixed maxPointsInLeafNode?

2020-04-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094692#comment-17094692 ] Adrien Grand commented on LUCENE-9087: -- +1 I like the idea of making the 1D and mu

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-04-28 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r416796194 ## File path: solr/core/src/java/org/apache/solr/search/MaxScoreCollector.java ## @@ -39,7 +39,7 @@ public float getMaxScore() { public ScoreMode s

[jira] [Commented] (SOLR-14173) Ref Guide Redesign

2020-04-28 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094756#comment-17094756 ] Cassandra Targett commented on SOLR-14173: -- I thought of another sort of comprom

[jira] [Closed] (SOLR-13663) XML Query Parser to Support SpanPositionRangeQuery

2020-04-28 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev closed SOLR-13663. --- > XML Query Parser to Support SpanPositionRangeQuery > --

[jira] [Updated] (SOLR-14173) Ref Guide Redesign

2020-04-28 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett updated SOLR-14173: - Attachment: SOLR-14173.patch > Ref Guide Redesign > -- > >

[jira] [Commented] (SOLR-14173) Ref Guide Redesign

2020-04-28 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094759#comment-17094759 ] Cassandra Targett commented on SOLR-14173: -- Also attached a new patch with the c

[GitHub] [lucene-solr] mkhludnev commented on pull request #812: [SOLR-13663] Span Positional Range Support in XML Query Parser + test

2020-04-28 Thread GitBox
mkhludnev commented on pull request #812: URL: https://github.com/apache/lucene-solr/pull/812#issuecomment-620777554 @alessandrobenedetti would you mind to close this PR. This is an automated message from the Apache Git Servi

[GitHub] [lucene-solr] alessandrobenedetti commented on pull request #812: [SOLR-13663] Span Positional Range Support in XML Query Parser + test

2020-04-28 Thread GitBox
alessandrobenedetti commented on pull request #812: URL: https://github.com/apache/lucene-solr/pull/812#issuecomment-620779177 Done! This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (SOLR-14412) NPE in MetricsHistoryHandler when running single node in cloud mode with SSL

2020-04-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094764#comment-17094764 ] ASF subversion and git services commented on SOLR-14412: Commit 0

[jira] [Created] (SOLR-14443) Make SolrLogPostTool resilient to unexpected requests

2020-04-28 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-14443: -- Summary: Make SolrLogPostTool resilient to unexpected requests Key: SOLR-14443 URL: https://issues.apache.org/jira/browse/SOLR-14443 Project: Solr Issue

[jira] [Commented] (SOLR-14173) Ref Guide Redesign

2020-04-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094802#comment-17094802 ] ASF subversion and git services commented on SOLR-14173: Commit f

[jira] [Commented] (LUCENE-9089) FST.Builder with fluent-style constructor

2020-04-28 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094819#comment-17094819 ] Dawid Weiss commented on LUCENE-9089: - Go ahead, Tomoko. Thank you. > FST.Builder w

[jira] [Created] (SOLR-14444) Ref Guide Redesign Phase 2: Page Organization Overhaul

2020-04-28 Thread Cassandra Targett (Jira)
Cassandra Targett created SOLR-1: Summary: Ref Guide Redesign Phase 2: Page Organization Overhaul Key: SOLR-1 URL: https://issues.apache.org/jira/browse/SOLR-1 Project: Solr I

[jira] [Updated] (SOLR-14173) Ref Guide Redesign Phase 1: Page Design

2020-04-28 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett updated SOLR-14173: - Summary: Ref Guide Redesign Phase 1: Page Design (was: Ref Guide Redesign) > Ref Guide R

[jira] [Updated] (SOLR-14173) Ref Guide Redesign Phase 1: Page Design

2020-04-28 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett updated SOLR-14173: - Description: The current design of the Ref Guide was essentially copied from a Jekyll-bas

[jira] [Created] (LUCENE-9349) Avoid parsing all terms in TermInSetQuery.visit()

2020-04-28 Thread Alan Woodward (Jira)
Alan Woodward created LUCENE-9349: - Summary: Avoid parsing all terms in TermInSetQuery.visit() Key: LUCENE-9349 URL: https://issues.apache.org/jira/browse/LUCENE-9349 Project: Lucene - Core I

[GitHub] [lucene-solr] romseygeek opened a new pull request #1465: LUCENE-9349: TermInSetQuery should use consumeMatchingTerms in visit()

2020-04-28 Thread GitBox
romseygeek opened a new pull request #1465: URL: https://github.com/apache/lucene-solr/pull/1465 TermInSetQuery currently iterates through all its prefix-encoded terms in order to build an array to pass back to its visitor when visit() is called. This seems like a waste, particular

[GitHub] [lucene-solr] romseygeek commented on pull request #1465: LUCENE-9349: TermInSetQuery should use consumeMatchingTerms in visit()

2020-04-28 Thread GitBox
romseygeek commented on pull request #1465: URL: https://github.com/apache/lucene-solr/pull/1465#issuecomment-620825699 This will also make FuzzyQuery's visit() method nicer if we switch back to not holding its automaton directly on the query. -

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2020-04-28 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094845#comment-17094845 ] Alan Woodward commented on LUCENE-8811: --- I opened LUCENE-9349 to address TermInSet

[jira] [Commented] (SOLR-14428) FuzzyQuery has severe memory usage in 8.5

2020-04-28 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094850#comment-17094850 ] Mike Drob commented on SOLR-14428: -- bq. I don't think we need to give queries the abili

[jira] [Updated] (LUCENE-9087) Should the BKD tree use a fixed maxPointsInLeafNode?

2020-04-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-9087: - Description: Currently the BKD tree uses a fixed maxPointsInLeafNode provided in the constructo

[GitHub] [lucene-solr] mkhludnev commented on pull request #1465: LUCENE-9349: TermInSetQuery should use consumeMatchingTerms in visit()

2020-04-28 Thread GitBox
mkhludnev commented on pull request #1465: URL: https://github.com/apache/lucene-solr/pull/1465#issuecomment-620839186 ok. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene-solr] dragonsinth commented on a change in pull request #1446: SOLR-14425: Aliases: ZK sync() needs to be synchronous

2020-04-28 Thread GitBox
dragonsinth commented on a change in pull request #1446: URL: https://github.com/apache/lucene-solr/pull/1446#discussion_r416945913 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java ## @@ -843,6 +847,31 @@ public void downloadFromZK(String zkPath,

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1446: SOLR-14425: Aliases: ZK sync() needs to be synchronous

2020-04-28 Thread GitBox
dsmiley commented on a change in pull request #1446: URL: https://github.com/apache/lucene-solr/pull/1446#discussion_r416947064 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java ## @@ -843,6 +847,31 @@ public void downloadFromZK(String zkPath, Pat

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-04-28 Thread GitBox
tflobbe commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r416956723 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -401,6 +403,14 @@ public void process(ResponseBuilder rb

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1456: SOLR-13289: Support for BlockMax WAND

2020-04-28 Thread GitBox
jpountz commented on a change in pull request #1456: URL: https://github.com/apache/lucene-solr/pull/1456#discussion_r416972950 ## File path: solr/core/src/java/org/apache/solr/search/MaxScoreCollector.java ## @@ -39,7 +39,7 @@ public float getMaxScore() { public ScoreMode s

[jira] [Reopened] (LUCENE-9191) Fix linefiledocs compression or replace in tests

2020-04-28 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter reopened LUCENE-9191: Apache jenkins found some reproducing failures originating from {{BasePostingsFormatT

[jira] [Comment Edited] (LUCENE-9191) Fix linefiledocs compression or replace in tests

2020-04-28 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094921#comment-17094921 ] Chris M. Hostetter edited comment on LUCENE-9191 at 4/28/20, 11:19 PM: ---

[jira] [Comment Edited] (LUCENE-9191) Fix linefiledocs compression or replace in tests

2020-04-28 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094921#comment-17094921 ] Chris M. Hostetter edited comment on LUCENE-9191 at 4/28/20, 11:21 PM: ---

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-04-28 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094923#comment-17094923 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-13289: -- This is how

[GitHub] [lucene-solr] madrob commented on pull request #807: Remove solr.jetty.https.port when SSL is not used

2020-04-28 Thread GitBox
madrob commented on pull request #807: URL: https://github.com/apache/lucene-solr/pull/807#issuecomment-620909328 @janhoy I didn't see this PR until you made your comment, but had to make the same changes as part of SOLR-14412. We can certainly add a CHANGES entry (and credit upendrasoft)

[GitHub] [lucene-solr] madrob edited a comment on pull request #807: Remove solr.jetty.https.port when SSL is not used

2020-04-28 Thread GitBox
madrob edited a comment on pull request #807: URL: https://github.com/apache/lucene-solr/pull/807#issuecomment-620909328 @janhoy I didn't see this PR until you made your comment, but had to make the same changes as part of SOLR-14412 (0fc5179c6a7). We can certainly add a CHANGES entry (and

[jira] [Commented] (LUCENE-9191) Fix linefiledocs compression or replace in tests

2020-04-28 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094930#comment-17094930 ] Chris M. Hostetter commented on LUCENE-9191: Similar root causes in other te

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

2020-04-28 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095141#comment-17095141 ] Dawid Weiss commented on LUCENE-7788: - Erick there are "nocommit" substrings in vali