Re: [PR] script to run microbenchmarks across different ec2 instance types [lucene]

2023-11-10 Thread via GitHub
rmuir merged PR #12787: URL: https://github.com/apache/lucene/pull/12787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [PR] script to run microbenchmarks across different ec2 instance types [lucene]

2023-11-09 Thread via GitHub
uschindler commented on code in PR #12787: URL: https://github.com/apache/lucene/pull/12787#discussion_r1388668515 ## gradle/validation/rat-sources.gradle: ## @@ -53,6 +53,9 @@ allprojects { include "**/*.sh" include "**/*.bat" +// exclude

Re: [PR] script to run microbenchmarks across different ec2 instance types [lucene]

2023-11-09 Thread via GitHub
uschindler commented on code in PR #12787: URL: https://github.com/apache/lucene/pull/12787#discussion_r1388648419 ## gradle/validation/rat-sources.gradle: ## @@ -53,6 +53,9 @@ allprojects { include "**/*.sh" include "**/*.bat" +// exclude

Re: [PR] script to run microbenchmarks across different ec2 instance types [lucene]

2023-11-09 Thread via GitHub
uschindler commented on code in PR #12787: URL: https://github.com/apache/lucene/pull/12787#discussion_r1388642702 ## gradle/validation/rat-sources.gradle: ## @@ -53,6 +53,9 @@ allprojects { include "**/*.sh" include "**/*.bat" +// exclude

Re: [PR] script to run microbenchmarks across different ec2 instance types [lucene]

2023-11-09 Thread via GitHub
rmuir commented on code in PR #12787: URL: https://github.com/apache/lucene/pull/12787#discussion_r1388647325 ## gradle/validation/rat-sources.gradle: ## @@ -53,6 +53,9 @@ allprojects { include "**/*.sh" include "**/*.bat" +// exclude anyt

Re: [PR] script to run microbenchmarks across different ec2 instance types [lucene]

2023-11-09 Thread via GitHub
uschindler commented on code in PR #12787: URL: https://github.com/apache/lucene/pull/12787#discussion_r1388643017 ## gradle/validation/rat-sources.gradle: ## @@ -53,6 +53,9 @@ allprojects { include "**/*.sh" include "**/*.bat" +// exclude

Re: [PR] script to run microbenchmarks across different ec2 instance types [lucene]

2023-11-09 Thread via GitHub
uschindler commented on code in PR #12787: URL: https://github.com/apache/lucene/pull/12787#discussion_r1388643017 ## gradle/validation/rat-sources.gradle: ## @@ -53,6 +53,9 @@ allprojects { include "**/*.sh" include "**/*.bat" +// exclude

Re: [PR] script to run microbenchmarks across different ec2 instance types [lucene]

2023-11-09 Thread via GitHub
rmuir commented on code in PR #12787: URL: https://github.com/apache/lucene/pull/12787#discussion_r1388642669 ## gradle/validation/rat-sources.gradle: ## @@ -53,6 +53,9 @@ allprojects { include "**/*.sh" include "**/*.bat" +// exclude anyt

Re: [PR] script to run microbenchmarks across different ec2 instance types [lucene]

2023-11-09 Thread via GitHub
uschindler commented on code in PR #12787: URL: https://github.com/apache/lucene/pull/12787#discussion_r1388639477 ## gradle/validation/rat-sources.gradle: ## @@ -53,6 +53,9 @@ allprojects { include "**/*.sh" include "**/*.bat" +// exclude

Re: [PR] script to run microbenchmarks across different ec2 instance types [lucene]

2023-11-09 Thread via GitHub
rmuir commented on code in PR #12787: URL: https://github.com/apache/lucene/pull/12787#discussion_r1388639032 ## gradle/validation/rat-sources.gradle: ## @@ -53,6 +53,9 @@ allprojects { include "**/*.sh" include "**/*.bat" +// exclude anyt

Re: [PR] script to run microbenchmarks across different ec2 instance types [lucene]

2023-11-09 Thread via GitHub
rmuir commented on code in PR #12787: URL: https://github.com/apache/lucene/pull/12787#discussion_r1388637999 ## gradle/validation/rat-sources.gradle: ## @@ -53,6 +53,9 @@ allprojects { include "**/*.sh" include "**/*.bat" +// exclude anyt

Re: [PR] script to run microbenchmarks across different ec2 instance types [lucene]

2023-11-09 Thread via GitHub
uschindler commented on code in PR #12787: URL: https://github.com/apache/lucene/pull/12787#discussion_r1388633378 ## gradle/validation/rat-sources.gradle: ## @@ -53,6 +53,9 @@ allprojects { include "**/*.sh" include "**/*.bat" +// exclude

Re: [PR] script to run microbenchmarks across different ec2 instance types [lucene]

2023-11-09 Thread via GitHub
rmuir commented on PR #12787: URL: https://github.com/apache/lucene/pull/12787#issuecomment-1804143223 I still struggle with the noise, it is even more than when you run the benchmarks manually. I inspected an instance under test and saw e.g. scheduled job burning up CPU rebuilding m

Re: [PR] script to run microbenchmarks across different ec2 instance types [lucene]

2023-11-09 Thread via GitHub
rmuir commented on PR #12787: URL: https://github.com/apache/lucene/pull/12787#issuecomment-1803343093 When I run `make PATCH_BRANCH=rmuir:microbenchmark_ec2` we will just see no differences but it demonstrates it (sorry: no speedups in this branch!). It spins up/tears down `lucene-jm