github-actions[bot] commented on PR #13993:
URL: https://github.com/apache/lucene/pull/13993#issuecomment-257824
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
kotman12 commented on PR #13993:
URL: https://github.com/apache/lucene/pull/13993#issuecomment-2502018488
Hey @romseygeek , this PR might not be the best forum but figure I'd mention
this anyway.. I'm working on a
[ReverseSearchQuery](https://github.com/kotman12/solr/pull/6/files) (name
su
kotman12 commented on PR #13993:
URL: https://github.com/apache/lucene/pull/13993#issuecomment-2481770909
> The monitor was initially written as a stand-alone application, and I
didn't have integrations in mind at all when I was designing the API. But we
can definitely re-work things a bit
romseygeek commented on PR #13993:
URL: https://github.com/apache/lucene/pull/13993#issuecomment-2480565223
The monitor was initially written as a stand-alone application, and I didn't
have integrations in mind at all when I was designing the API. But we can
definitely re-work things a bit
kotman12 commented on PR #13993:
URL: https://github.com/apache/lucene/pull/13993#issuecomment-2477481565
Following up briefly, I just don't see a lot of use for a QueryIndex or a
Monitor in a more "advanced" set-up such a Solr. The QueryIndex api is quite
large and most of the operations a
cpoerschke commented on PR #13993:
URL: https://github.com/apache/lucene/pull/13993#issuecomment-2476326328
Opened #13995 as an alternative i.e. `of` method visibility to match the
class. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
kotman12 commented on PR #13993:
URL: https://github.com/apache/lucene/pull/13993#issuecomment-2476322270
> Cacheing of parsed queries is pretty tightly coupled to how the query
index is implemented so separating them out might be trickier
The current "solr monitor" PR avoids this pro
romseygeek commented on PR #13993:
URL: https://github.com/apache/lucene/pull/13993#issuecomment-2476301351
I'm definitely up for making this more extensible. We already have two
separate QueryIndex implementations, so maybe that's the best place to start?
Cacheing of parsed queries is pr
kotman12 commented on PR #13993:
URL: https://github.com/apache/lucene/pull/13993#issuecomment-2476125066
Author here, so the current monitor API makes it really hard to integrate
into anything more "custom" like solr. This is because it tightly seals
relevant implementation details like ca
romseygeek commented on PR #13993:
URL: https://github.com/apache/lucene/pull/13993#issuecomment-2475955653
DocumentBatch is really an implementation detail of the Monitor, so I'm not
sure why client code would need to refer to it? The linked Solr PR is quite
big so it's difficult to see w
10 matches
Mail list logo
