Re: [PR] build: generate CaseFolding.java from "gradle regenerate" [lucene]

2025-04-05 Thread via GitHub
uschindler commented on code in PR #14384: URL: https://github.com/apache/lucene/pull/14384#discussion_r2008497905 ## lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java: ## @@ -759,23 +759,14 @@ private Automaton toAutomaton( * @return the original codepoint a

Re: [PR] build: generate CaseFolding.java from "gradle regenerate" [lucene]

2025-03-22 Thread via GitHub
rmuir commented on code in PR #14384: URL: https://github.com/apache/lucene/pull/14384#discussion_r2008648506 ## lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java: ## @@ -759,23 +759,14 @@ private Automaton toAutomaton( * @return the original codepoint and th

Re: [PR] build: generate CaseFolding.java from "gradle regenerate" [lucene]

2025-03-21 Thread via GitHub
rmuir merged PR #14384: URL: https://github.com/apache/lucene/pull/14384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [PR] build: generate CaseFolding.java from "gradle regenerate" [lucene]

2025-03-21 Thread via GitHub
rmuir commented on PR #14384: URL: https://github.com/apache/lucene/pull/14384#issuecomment-2743831323 There was something about gradle itself that was upset about dependencies wrt generation tasks, if i recall... cycle detection or something was complaining about it. -- This is an autom

Re: [PR] build: generate CaseFolding.java from "gradle regenerate" [lucene]

2025-03-21 Thread via GitHub
rmuir commented on PR #14384: URL: https://github.com/apache/lucene/pull/14384#issuecomment-2743736828 I will followup with an ICU upgrade PR to this one. I don't expect that this file will change except for the version in the comment though. -- This is an automated message from the Apach

Re: [PR] build: generate CaseFolding.java from "gradle regenerate" [lucene]

2025-03-21 Thread via GitHub
dweiss commented on PR #14384: URL: https://github.com/apache/lucene/pull/14384#issuecomment-2743758629 I mean the entire structure of tasks that are used in regenerate. It's complex. I remember I couldn't do it in any easier way before - maybe something has changed that would allow it to b

Re: [PR] build: generate CaseFolding.java from "gradle regenerate" [lucene]

2025-03-21 Thread via GitHub
rmuir commented on PR #14384: URL: https://github.com/apache/lucene/pull/14384#issuecomment-2743717079 It was easy because @uschindler already created a similar groovy script before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] build: generate CaseFolding.java from "gradle regenerate" [lucene]

2025-03-21 Thread via GitHub
rmuir commented on PR #14384: URL: https://github.com/apache/lucene/pull/14384#issuecomment-2743662885 This one is pretty easy to understand, the `CaseFolding` class now just gives you `UnicodeSet(ch).closeOver(UnicodeSet.SIMPLE_CASE_INSENSITIVE)` without requiring that you have ICU.