Re: [PR] add Automaton.toMermaid() for emitting mermaid state charts [lucene]

2025-03-31 Thread via GitHub
github-actions[bot] commented on PR #14360: URL: https://github.com/apache/lucene/pull/14360#issuecomment-2767713257 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] add Automaton.toMermaid() for emitting mermaid state charts [lucene]

2025-03-17 Thread via GitHub
rmuir commented on PR #14360: URL: https://github.com/apache/lucene/pull/14360#issuecomment-2730119438 i'll keep the PR up here. Actually as a first step, I'd rather improve existing toDot() and regex toString(). It would help the logic here, too. There's no need to escape codepoints

Re: [PR] add Automaton.toMermaid() for emitting mermaid state charts [lucene]

2025-03-17 Thread via GitHub
dweiss commented on PR #14360: URL: https://github.com/apache/lucene/pull/14360#issuecomment-2728443809 I've looked at the docs of mermaid and toyed around a bit. I agree that infinite loops are so ugly that one's eyes start to bleed. Maybe we should stick to graphviz. -- This is an auto

Re: [PR] add Automaton.toMermaid() for emitting mermaid state charts [lucene]

2025-03-16 Thread via GitHub
rmuir commented on PR #14360: URL: https://github.com/apache/lucene/pull/14360#issuecomment-2727699099 Mermaid definitely doesn't handle infinite automata very well at all: ```mermaid stateDiagram direction LR classDef accept border-width:5px;stroke-width:5px,s

Re: [PR] add Automaton.toMermaid() for emitting mermaid state charts [lucene]

2025-03-16 Thread via GitHub
rmuir commented on PR #14360: URL: https://github.com/apache/lucene/pull/14360#issuecomment-2727698038 Here's the same Automaton, but via `toDot()` tossed into https://dreampuf.github.io/GraphvizOnline with all defaults. I guess I'm still a fan of that output style, I feel it is more readab