mayya-sharipova merged PR #13268:
URL: https://github.com/apache/lucene/pull/13268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lu
mayya-sharipova commented on code in PR #13268:
URL: https://github.com/apache/lucene/pull/13268#discussion_r1559895242
##
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java:
##
@@ -360,6 +366,22 @@ public Builder withFieldMatcher(Predicate v
jimczi commented on code in PR #13268:
URL: https://github.com/apache/lucene/pull/13268#discussion_r1559420851
##
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java:
##
@@ -360,6 +366,22 @@ public Builder withFieldMatcher(Predicate value) {
mayya-sharipova commented on code in PR #13268:
URL: https://github.com/apache/lucene/pull/13268#discussion_r1558043257
##
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java:
##
@@ -712,17 +712,21 @@ public String[] highlight(String field, Qu
jimczi commented on code in PR #13268:
URL: https://github.com/apache/lucene/pull/13268#discussion_r1556370339
##
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java:
##
@@ -712,17 +712,21 @@ public String[] highlight(String field, Query query
mayya-sharipova commented on PR #13268:
URL: https://github.com/apache/lucene/pull/13268#issuecomment-2043534438
@jimczi Thanks for your initial review. I've tried to address all your
comments, so this is ready for another review.
--
This is an automated message from the Apache Git Servic
mayya-sharipova commented on code in PR #13268:
URL: https://github.com/apache/lucene/pull/13268#discussion_r1556357241
##
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java:
##
@@ -712,17 +712,21 @@ public String[] highlight(String field, Qu
mayya-sharipova commented on code in PR #13268:
URL: https://github.com/apache/lucene/pull/13268#discussion_r1556357241
##
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java:
##
@@ -712,17 +712,21 @@ public String[] highlight(String field, Qu
jimczi commented on code in PR #13268:
URL: https://github.com/apache/lucene/pull/13268#discussion_r1555668470
##
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java:
##
@@ -712,17 +712,21 @@ public String[] highlight(String field, Query query
