uschindler commented on PR #14597:
URL: https://github.com/apache/lucene/pull/14597#issuecomment-2845352242
I made some followup changes here: #14602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
uschindler commented on PR #14597:
URL: https://github.com/apache/lucene/pull/14597#issuecomment-2844596152
Finally here is an example Classfile output with this PR for this code:
```java
public void testNamespacesWithoutDirectMH() throws Exception {
Map functions =
uschindler commented on PR #14597:
URL: https://github.com/apache/lucene/pull/14597#issuecomment-2844245278
I made a small followup commit to make usage more like recommended by
Classfile API docs: e2d06855cc09df4b1293817c99d767ef7d8adc6d
--
This is an automated message from the Apache Gi
dweiss commented on PR #14597:
URL: https://github.com/apache/lucene/pull/14597#issuecomment-2844181355
Uncanny resemblance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rmuir commented on PR #14597:
URL: https://github.com/apache/lucene/pull/14597#issuecomment-2843582527
lol the day we have an army of Uwe AIs, I feel like I've already seen this
[movie](https://www.youtube.com/watch?v=wN6F1l4cJ1Y)
--
This is an automated message from the Apache Git Servi
uschindler merged PR #14597:
URL: https://github.com/apache/lucene/pull/14597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
dweiss commented on PR #14597:
URL: https://github.com/apache/lucene/pull/14597#issuecomment-2843319741
> The hard part was more to understand and figure out how it works.
For the fun of it, I asked chatgpt to do it. Uwe - you're still much, much
better. :)
--
This is an automated
uschindler commented on PR #14597:
URL: https://github.com/apache/lucene/pull/14597#issuecomment-2843271854
> Looks great! It seems like ASM translated relatively well (in this case)
to the ClassFile API (much of it was just changing imports/methods to call but
looks very similar).
T
uschindler commented on PR #14597:
URL: https://github.com/apache/lucene/pull/14597#issuecomment-2843218827
I did some final cleanup and added changes entry. Will merge soon.
Thanks for the reviews by @rjernst and @jdconrad, very appreciated.
--
This is an automated message from the
